keybinds: fix xkb keybind name to keysym comparison (#5917)

This commit is contained in:
Ikalco 2024-05-07 01:20:06 -05:00 committed by GitHub
parent 0c446ec5f4
commit 57e76f91d9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -576,9 +576,10 @@ bool CKeybindManager::handleKeybinds(const uint32_t modmask, const SPressedKeyWi
} else { } else {
// oMg such performance hit!!11! // oMg such performance hit!!11!
// this little maneouver is gonna cost us 4µs // this little maneouver is gonna cost us 4µs
const auto KBKEY = xkb_keysym_from_name(k.key.c_str(), XKB_KEYSYM_CASE_INSENSITIVE); const auto KBKEY = xkb_keysym_from_name(k.key.c_str(), XKB_KEYSYM_NO_FLAGS);
const auto KBKEYLOWER = xkb_keysym_from_name(k.key.c_str(), XKB_KEYSYM_CASE_INSENSITIVE);
if (KBKEY == 0) { if (KBKEY == 0 && KBKEYLOWER == 0) {
// Keysym failed to resolve from the key name of the currently iterated bind. // Keysym failed to resolve from the key name of the currently iterated bind.
// This happens for names such as `switch:off:Lid Switch` as well as some keys // This happens for names such as `switch:off:Lid Switch` as well as some keys
// (such as yen and ro). // (such as yen and ro).
@ -589,9 +590,7 @@ bool CKeybindManager::handleKeybinds(const uint32_t modmask, const SPressedKeyWi
continue; continue;
} }
const auto KBKEYUPPER = xkb_keysym_to_upper(KBKEY); if (key.keysym != KBKEY && key.keysym != KBKEYLOWER)
if (key.keysym != KBKEY && key.keysym != KBKEYUPPER)
continue; continue;
} }