hyprwm/Hyprland
1
0
Fork 0
mirror of https://github.com/hyprwm/Hyprland synced 2025-01-10 17:09:49 +01:00
Code Issues Projects Releases Packages Wiki Activity

core/compositor: fix too early buffer release (#8966)

Browse source
This commit is contained in:
UjinT34 2025-01-06 19:52:35 +03:00 committed by GitHub
parent 602d6b7356
commit 6a90b50545
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/protocols/core/Compositor.cpp
View file

@ -428,6 +428,7 @@ void CWLSurfaceResource::commitPendingState() {
pending.damage.clear(); pending.damage.clear();
pending.bufferDamage.clear(); pending.bufferDamage.clear();
pending.newBuffer = false; pending.newBuffer = false;
dropPendingBuffer(); // at this point current.buffer holds the same SP and we don't use pending anymore
events.roleCommit.emit(); events.roleCommit.emit();
@ -448,10 +449,9 @@ void CWLSurfaceResource::commitPendingState() {
// release the buffer if it's synchronous as update() has done everything thats needed // release the buffer if it's synchronous as update() has done everything thats needed
// so we can let the app know we're done. // so we can let the app know we're done.
if (current.buffer->buffer->isSynchronous()) { // Some clients aren't ready to receive a release this early. Should be fine to release it on the next commitPendingState.
dropCurrentBuffer(); // if (current.buffer->buffer->isSynchronous())
dropPendingBuffer(); // pending atm is just a copied ref of the current, drop it too to send a release // dropCurrentBuffer();
}
} }
// TODO: we should _accumulate_ and not replace above if sync // TODO: we should _accumulate_ and not replace above if sync