From 844da8db561f00f99d7e861b4b9a8bf51bbcd10c Mon Sep 17 00:00:00 2001 From: Dickby Date: Sat, 11 Nov 2023 16:43:31 +0100 Subject: [PATCH] shaders: Avoid calculating unused values in hsl2rgb. (#3827) --- src/render/shaders/Textures.hpp | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/render/shaders/Textures.hpp b/src/render/shaders/Textures.hpp index daa7bc9b..8108f451 100644 --- a/src/render/shaders/Textures.hpp +++ b/src/render/shaders/Textures.hpp @@ -258,19 +258,18 @@ vec3 hsl2rgb(vec3 col) { float sat = col.y; float lum = col.z; - vec3 xt = vec3(rcpsixth * (hue - twothird), 0.0, rcpsixth * (1.0 - hue)); - - if (hue < twothird) { - xt.r = 0.0; - xt.g = rcpsixth * (twothird - hue); - xt.b = rcpsixth * (hue - onethird); - } + vec3 xt = vec3(0.0); if (hue < onethird) { xt.r = rcpsixth * (onethird - hue); xt.g = rcpsixth * hue; xt.b = 0.0; - } + } else if (hue < twothird) { + xt.r = 0.0; + xt.g = rcpsixth * (twothird - hue); + xt.b = rcpsixth * (hue - onethird); + } else + xt = vec3(rcpsixth * (hue - twothird), 0.0, rcpsixth * (1.0 - hue)); xt = min(xt, 1.0);