From bccc81d306dd35cca2eeac2897e19064c7b3d24f Mon Sep 17 00:00:00 2001 From: Dickby Date: Fri, 23 Sep 2022 19:13:05 +0200 Subject: [PATCH] Fixing my last change It wasn't a problem with the bug i tried to fix. But there would be a problem if some function would dereference pPreviousGroupMember from the node that was PHEAD->pNextGroupMember. Please don't be mean! --- src/layout/DwindleLayout.cpp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/layout/DwindleLayout.cpp b/src/layout/DwindleLayout.cpp index 26536728..59b36156 100644 --- a/src/layout/DwindleLayout.cpp +++ b/src/layout/DwindleLayout.cpp @@ -821,15 +821,14 @@ void CHyprDwindleLayout::toggleWindowGroup(CWindow* pWindow) { PWINDOW->m_bHidden = false; } - if (PHEAD->pPreviousGroupMember) { + if (PHEAD->pPreviousGroupMember) PHEAD->pPreviousGroupMember->pNextGroupMember = PHEAD->pNextGroupMember; - PHEAD->pPreviousGroupMember = nullptr; - } - if (PHEAD->pNextGroupMember) { + if (PHEAD->pNextGroupMember) PHEAD->pNextGroupMember->pPreviousGroupMember = PHEAD->pPreviousGroupMember; - PHEAD->pNextGroupMember = nullptr; - } + + PHEAD->pPreviousGroupMember = nullptr; + PHEAD->pNextGroupMember = nullptr; onWindowRemoved(PHEAD->pWindow);