mirror of
https://github.com/hyprwm/Hyprland
synced 2024-11-02 15:45:59 +01:00
configmanager: set a limit to config variable substitutions
fixes #4198
This commit is contained in:
parent
d1b8a63a8e
commit
b4f4bd38e8
1 changed files with 10 additions and 0 deletions
|
@ -1478,7 +1478,10 @@ std::string CConfigManager::parseKeyword(const std::string& COMMAND, const std::
|
|||
void CConfigManager::applyUserDefinedVars(std::string& line, const size_t equalsPlace) {
|
||||
auto dollarPlace = line.find_first_of('$', equalsPlace);
|
||||
|
||||
int times = 0;
|
||||
|
||||
while (dollarPlace != std::string::npos) {
|
||||
times++;
|
||||
|
||||
const auto STRAFTERDOLLAR = line.substr(dollarPlace + 1);
|
||||
bool found = false;
|
||||
|
@ -1501,6 +1504,13 @@ void CConfigManager::applyUserDefinedVars(std::string& line, const size_t equals
|
|||
}
|
||||
|
||||
dollarPlace = line.find_first_of('$', dollarPlace + 1);
|
||||
|
||||
if (times > 256 /* arbitrary limit */) {
|
||||
line = "";
|
||||
parseError = "Maximum variable recursion limit hit. Evaluating the line led to too many variable substitutions.";
|
||||
Debug::log(ERR, "Variable recursion limit hit in configmanager");
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue