hyprwm/Hyprland
1
0
Fork 0
mirror of https://github.com/hyprwm/Hyprland synced 2025-01-11 23:09:49 +01:00
Code Issues Projects Releases Packages Wiki Activity

animation: avoid crashes in ::tick() on mutations

Browse source 
mutating the active variables is valid during a tick, we can't let it crash
This commit is contained in:
Vaxry 2025-01-10 21:55:19 +01:00
parent a8b568c6c4
commit cef09fbfe6
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/managers/AnimationManager.cpp
View file

@ -215,7 +215,11 @@ void CHyprAnimationManager::tick() {
lastTick = std::chrono::high_resolution_clock::now(); lastTick = std::chrono::high_resolution_clock::now();
static auto PANIMENABLED = CConfigValue<Hyprlang::INT>("animations:enabled"); static auto PANIMENABLED = CConfigValue<Hyprlang::INT>("animations:enabled");
for (auto const& pav : m_vActiveAnimatedVariables) {
// We need to do this because it's perfectly valid to add/change a var during this (via callbacks)
// FIXME: instead of doing this, make a fn to defer adding until tick is done and not in progress anymore.
const auto PAVS = m_vActiveAnimatedVariables;
for (auto const& pav : PAVS) {
const auto PAV = pav.lock(); const auto PAV = pav.lock();
if (!PAV) if (!PAV)
continue; continue;