From d1340bd1d8eedd274283e0cb2568a3ed67b58c81 Mon Sep 17 00:00:00 2001 From: Vaxry Date: Mon, 17 Jun 2024 17:53:44 +0200 Subject: [PATCH] keybinds: ignore missing keysyms if no other methods match fixes #6548 --- src/managers/KeybindManager.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/managers/KeybindManager.cpp b/src/managers/KeybindManager.cpp index 14fadf02..875ba239 100644 --- a/src/managers/KeybindManager.cpp +++ b/src/managers/KeybindManager.cpp @@ -636,6 +636,12 @@ bool CKeybindManager::handleKeybinds(const uint32_t modmask, const SPressedKeyWi if (found || key.submapAtPress != m_szCurrentSelectedSubmap) continue; } else { + // in this case, we only have the keysym to go off. + // if the keysym failed resolving, we can't do anything. It's likely missing + // from the keymap. + if (key.keysym == 0) + return false; + // oMg such performance hit!!11! // this little maneouver is gonna cost us 4µs const auto KBKEY = xkb_keysym_from_name(k.key.c_str(), XKB_KEYSYM_NO_FLAGS);