hyprwm/Hyprland
1
0
Fork 0
mirror of https://github.com/hyprwm/Hyprland synced 2024-11-26 12:45:59 +01:00
Code Issues Projects Releases Packages Wiki Activity

xwayland: break cyclic loop of parents (#6722)

Browse source 
in X11 some surfaces is a parent of itself and creates a cyclic loop
when trying to find its parent. check for old parent and break if its
beginning to roll over.
This commit is contained in:
Tom Englund 2024-07-01 00:26:08 +02:00 committed by GitHub
parent 4d6f96f74f
commit d7ea1b7785
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/desktop/Window.cpp
View file

@ -444,9 +444,11 @@ PHLWINDOW CWindow::X11TransientFor() {
if (!m_pXWaylandSurface || !m_pXWaylandSurface->parent) if (!m_pXWaylandSurface || !m_pXWaylandSurface->parent)
return nullptr; return nullptr;
auto s = m_pXWaylandSurface->parent; auto s = m_pXWaylandSurface->parent;
auto oldParent = s;
while (s) { while (s) {
if (!s->parent) // break cyclic loop of m_pXWaylandSurface being parent of itself, #TODO reject this from even being created?
if (!s->parent || s->parent == oldParent)
break; break;
s = s->parent; s = s->parent;
} }