Initialize priority managers before server init

src/Compositor.cpp

@@ -35,8 +35,6 @@ void handleUnrecoverableSignal(int sig) {
 }
 
 CCompositor::CCompositor() {
-    wlr_log_init(WLR_INFO, NULL);
-
     m_iHyprlandPID = getpid();
 
     m_szInstanceSignature = GIT_COMMIT_HASH + std::string("_") + std::to_string(time(NULL));
@@ -72,7 +70,21 @@ CCompositor::CCompositor() {
     setRandomSplash();
 
     Debug::log(LOG, "\nCurrent splash: %s\n\n", m_szCurrentSplash.c_str());
+}
 
+CCompositor::~CCompositor() {
+    cleanup();
+}
+
+void CCompositor::setRandomSplash() {
+    std::random_device              dev;
+    std::mt19937                    engine(dev());
+    std::uniform_int_distribution<> distribution(0, SPLASHES.size() - 1);
+
+    m_szCurrentSplash = SPLASHES[distribution(engine)];
+}
+
+void CCompositor::initServer() {
     m_sWLDisplay = wl_display_create();
 
     m_sWLEventLoop = wl_display_get_event_loop(m_sWLDisplay);
@@ -83,6 +95,14 @@ CCompositor::CCompositor() {
     signal(SIGABRT, handleUnrecoverableSignal);
     //wl_event_loop_add_signal(m_sWLEventLoop, SIGINT, handleCritSignal, nullptr);
 
+    initManagers(STAGE_PRIORITY);
+
+    wlr_log_init(WLR_INFO, NULL);
+
+    const auto LOGWLR = getenv("HYPRLAND_LOG_WLR");
+    if (LOGWLR && std::string(LOGWLR) == "1")
+        wlr_log_init(WLR_DEBUG, Debug::wlrLog);
+
     m_sWLRBackend = wlr_backend_autocreate(m_sWLDisplay, &m_sWLRSession);
 
     if (!m_sWLRBackend) {
@@ -226,18 +246,8 @@ CCompositor::CCompositor() {
     wlr_single_pixel_buffer_manager_v1_create(m_sWLDisplay);
 
     wlr_multi_backend_add(m_sWLRBackend, m_sWLRHeadlessBackend);
-}
 
-CCompositor::~CCompositor() {
+    initManagers(STAGE_LATE);
-    cleanup();
-}
-
-void CCompositor::setRandomSplash() {
-    std::random_device              dev;
-    std::mt19937                    engine(dev());
-    std::uniform_int_distribution<> distribution(0, SPLASHES.size() - 1);
-
-    m_szCurrentSplash = SPLASHES[distribution(engine)];
 }
 
 void CCompositor::initAllSignals() {
@@ -337,11 +347,9 @@ void CCompositor::cleanup() {
                                                                                       // the PID should not be reused.
 }
 
-void CCompositor::startCompositor() {
+void CCompositor::initManagers(eManagersInitStage stage) {
-    // Init all the managers BEFORE we start with the wayland server so that ALL of the stuff is initialized
+    switch (stage) {
-    // properly and we dont get any bad mem reads.
+        case STAGE_PRIORITY: {
-    //
-
             Debug::log(LOG, "Creating the HookSystem!");
             g_pHookSystem = std::make_unique<CHookSystemManager>();
 
@@ -351,15 +359,18 @@ void CCompositor::startCompositor() {
             Debug::log(LOG, "Creating the AnimationManager!");
             g_pAnimationManager = std::make_unique<CAnimationManager>();
 
-    Debug::log(LOG, "Creating the LayoutManager!");
-    g_pLayoutManager = std::make_unique<CLayoutManager>();
-
             Debug::log(LOG, "Creating the ConfigManager!");
             g_pConfigManager = std::make_unique<CConfigManager>();
 
             Debug::log(LOG, "Creating the CHyprError!");
             g_pHyprError = std::make_unique<CHyprError>();
 
+            Debug::log(LOG, "Creating the LayoutManager!");
+            g_pLayoutManager = std::make_unique<CLayoutManager>();
+
+            g_pConfigManager->init();
+        } break;
+        case STAGE_LATE: {
             Debug::log(LOG, "Creating the ThreadManager!");
             g_pThreadManager = std::make_unique<CThreadManager>();
 
@@ -393,14 +404,12 @@ void CCompositor::startCompositor() {
 
             Debug::log(LOG, "Creating the PluginSystem!");
             g_pPluginSystem = std::make_unique<CPluginSystem>();
-    //
+        } break;
-    //
+        default: UNREACHABLE();
-
+    }
-    // firefox wont detect wl
+}
-    setenv("MOZ_ENABLE_WAYLAND", "1", 1);
-
-    setenv("XDG_CURRENT_DESKTOP", "Hyprland", 1);
 
+void CCompositor::startCompositor() {
     initAllSignals();
 
     // get socket, avoid using 0

src/Compositor.hpp

@@ -28,6 +28,12 @@
 #include "hyprerror/HyprError.hpp"
 #include "plugins/PluginSystem.hpp"
 
+enum eManagersInitStage
+{
+    STAGE_PRIORITY = 0,
+    STAGE_LATE
+};
+
 class CCompositor {
   public:
     CCompositor();
@@ -93,6 +99,7 @@ class CCompositor {
     std::vector<CWindow*>                     m_vWindowsFadingOut;
     std::vector<SLayerSurface*>               m_vSurfacesFadingOut;
 
+    void                                      initServer();
     void                                      startCompositor();
     void                                      cleanup();
 
@@ -188,6 +195,7 @@ class CCompositor {
   private:
     void     initAllSignals();
     void     setRandomSplash();
+    void     initManagers(eManagersInitStage stage);
 
     uint64_t m_iHyprlandPID = 0;
 };

src/main.cpp

@@ -20,6 +20,8 @@ int main(int argc, char** argv) {
     setenv("HYPRLAND_CMD", cmd.c_str(), 1);
     setenv("XDG_BACKEND", "wayland", 1);
     setenv("_JAVA_AWT_WM_NONREPARENTING", "1", 1);
+    setenv("MOZ_ENABLE_WAYLAND", "1", 1);
+    setenv("XDG_CURRENT_DESKTOP", "Hyprland", 1);
 
     // parse some args
     std::string configPath;
@@ -50,15 +52,13 @@ int main(int argc, char** argv) {
 
     std::cout << "Welcome to Hyprland!\n";
 
-    const auto LOGWLR = getenv("HYPRLAND_LOG_WLR");
-    if (LOGWLR && std::string(LOGWLR) == "1")
-        wlr_log_init(WLR_DEBUG, Debug::wlrLog);
-
     // let's init the compositor.
     // it initializes basic Wayland stuff in the constructor.
     g_pCompositor                     = std::make_unique<CCompositor>();
     g_pCompositor->explicitConfigPath = configPath;
 
+    g_pCompositor->initServer();
+
     Debug::log(LOG, "Hyprland init finished.");
 
     // If all's good to go, start.

src/managers/ThreadManager.cpp

@@ -18,8 +18,6 @@ int handleTimer(void* data) {
 }
 
 CThreadManager::CThreadManager() {
-    g_pConfigManager->init();
-
     HyprCtl::startHyprCtlSocket();
 
     m_esConfigTimer = wl_event_loop_add_timer(g_pCompositor->m_sWLEventLoop, handleTimer, this);