hyprwm/hyprlock
1
0
Fork 0
mirror of https://github.com/hyprwm/hyprlock.git synced 2024-12-22 13:29:48 +01:00
Code Issues Projects Releases Packages Wiki Activity

asyncResourceGatherer: do not detach worker threads (#477)

Browse source 
Worker threads become non-joinable once they are detached, and `await()` will not wait for them to
finish. This can lead to a crash when `asyncResourceGatherer` is destroyed in the main thread while it
is still being used in worker threads.
This commit is contained in:
Yang, Ying-chao 2024-09-05 03:58:38 +08:00 committed by GitHub
parent 73b0fc26c0
commit 0b030d33c8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/renderer/AsyncResourceGatherer.cpp
View file

@ -18,10 +18,7 @@ CAsyncResourceGatherer::CAsyncResourceGatherer() {
enqueueDMAFrames(); enqueueDMAFrames();
initialGatherThread = std::thread([this]() { this->gather(); }); initialGatherThread = std::thread([this]() { this->gather(); });
initialGatherThread.detach(); asyncLoopThread = std::thread([this]() { this->asyncAssetSpinLock(); });
asyncLoopThread = std::thread([this]() { this->asyncAssetSpinLock(); });
asyncLoopThread.detach();
} }
void CAsyncResourceGatherer::enqueueDMAFrames() { void CAsyncResourceGatherer::enqueueDMAFrames() {