hyprwm/hyprlock
1
0
Fork 0
mirror of https://github.com/hyprwm/hyprlock.git synced 2025-01-27 04:49:48 +01:00
Code Issues Projects Releases Packages Wiki Activity

DBusManager: Remove unnecessary locks from getters in singleton

Browse source
This commit is contained in:
iamanaws 2025-01-04 08:34:54 -08:00
parent 00b02c005f
commit b22009f992
2 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/core/DBusManager.cpp
View file

@ -33,12 +33,10 @@ void DBusManager::initializeConnection() {
} }
std::shared_ptr<sdbus::IConnection> DBusManager::getConnection() { std::shared_ptr<sdbus::IConnection> DBusManager::getConnection() {
std::lock_guard<std::mutex> lock(m_mutex);
return m_pConnection; return m_pConnection;
} }
std::shared_ptr<sdbus::IProxy> DBusManager::getLoginProxy() { std::shared_ptr<sdbus::IProxy> DBusManager::getLoginProxy() {
std::lock_guard<std::mutex> lock(m_mutex);
if (!m_pLoginProxy) if (!m_pLoginProxy)
initializeConnection(); initializeConnection();
@ -46,7 +44,6 @@ std::shared_ptr<sdbus::IProxy> DBusManager::getLoginProxy() {
} }
std::shared_ptr<sdbus::IProxy> DBusManager::getSessionProxy() { std::shared_ptr<sdbus::IProxy> DBusManager::getSessionProxy() {
std::lock_guard<std::mutex> lock(m_mutex);
if (!m_pSessionProxy) if (!m_pSessionProxy)
initializeConnection(); initializeConnection();
@ -54,7 +51,6 @@ std::shared_ptr<sdbus::IProxy> DBusManager::getSessionProxy() {
} }
void DBusManager::setLockedHint(bool locked) { void DBusManager::setLockedHint(bool locked) {
std::lock_guard<std::mutex> lock(m_mutex);
if (!m_pSessionProxy) { if (!m_pSessionProxy) {
Debug::log(WARN, "[DBusManager] Cannot set locked hint: Proxy is not initialized."); Debug::log(WARN, "[DBusManager] Cannot set locked hint: Proxy is not initialized.");
return; return;
@ -71,7 +67,6 @@ void DBusManager::setLockedHint(bool locked) {
} }
void DBusManager::sendUnlockSignal() { void DBusManager::sendUnlockSignal() {
std::lock_guard<std::mutex> lock(m_mutex);
if (!m_pSessionProxy) { if (!m_pSessionProxy) {
Debug::log(WARN, "[DBusManager] Unlock signal skipped: Proxy is not initialized."); Debug::log(WARN, "[DBusManager] Unlock signal skipped: Proxy is not initialized.");
return; return;

3
src/core/DBusManager.hpp
View file

@ -2,7 +2,6 @@
#include <memory> #include <memory>
#include <string> #include <string>
#include <mutex>
#include <sdbus-c++/sdbus-c++.h> #include <sdbus-c++/sdbus-c++.h>
class DBusManager { class DBusManager {
@ -25,6 +24,4 @@ private:
std::shared_ptr<sdbus::IConnection> m_pConnection; std::shared_ptr<sdbus::IConnection> m_pConnection;
std::shared_ptr<sdbus::IProxy> m_pLoginProxy; std::shared_ptr<sdbus::IProxy> m_pLoginProxy;
std::shared_ptr<sdbus::IProxy> m_pSessionProxy; std::shared_ptr<sdbus::IProxy> m_pSessionProxy;
std::mutex m_mutex;
}; };