misc: fix some compile warnings (#25)

- Cleans up compile warnings
- Formats code
- Cleans up unused vars
- etc

include/hyprutils/math/Vector2D.hpp

@@ -102,7 +102,7 @@ namespace Hyprutils {
 }
 
 // absolutely ridiculous formatter spec parsing
-#define AQ_FORMAT_PARSE(specs__, type__)                                                                                                                                              \
+#define AQ_FORMAT_PARSE(specs__, type__)                                                                                                                                           \
     template <typename FormatContext>                                                                                                                                              \
     constexpr auto parse(FormatContext& ctx) {                                                                                                                                     \
         auto it = ctx.begin();                                                                                                                                                     \
@@ -112,10 +112,10 @@ namespace Hyprutils {
         return it;                                                                                                                                                                 \
     }
 
-#define AQ_FORMAT_FLAG(spec__, flag__)                                                                                                                                                \
+#define AQ_FORMAT_FLAG(spec__, flag__)                                                                                                                                             \
     case spec__: (flag__) = true; break;
 
-#define AQ_FORMAT_NUMBER(buf__)                                                                                                                                                       \
+#define AQ_FORMAT_NUMBER(buf__)                                                                                                                                                    \
     case '0':                                                                                                                                                                      \
     case '1':                                                                                                                                                                      \
     case '2':                                                                                                                                                                      \
@@ -139,9 +139,9 @@ struct std::formatter<Hyprutils::Math::Vector2D, CharT> : std::formatter<CharT>
     bool        formatX    = false;
     std::string precision  = "";
     AQ_FORMAT_PARSE(AQ_FORMAT_FLAG('j', formatJson) //
-                 AQ_FORMAT_FLAG('X', formatX)    //
+                    AQ_FORMAT_FLAG('X', formatX)    //
-                 AQ_FORMAT_NUMBER(precision),
+                    AQ_FORMAT_NUMBER(precision),
-                 Hyprutils::Math::Vector2D)
+                    Hyprutils::Math::Vector2D)
 
     template <typename FormatContext>
     auto format(const Hyprutils::Math::Vector2D& vec, FormatContext& ctx) const {

include/hyprutils/string/String.hpp

@@ -5,7 +5,7 @@ namespace Hyprutils {
     namespace String {
         // trims beginning and end of whitespace characters
         std::string trim(const std::string& in);
-        bool isNumber(const std::string& str, bool allowfloat = false);
+        bool        isNumber(const std::string& str, bool allowfloat = false);
-        void replaceInString(std::string& string, const std::string& what, const std::string& to);
+        void        replaceInString(std::string& string, const std::string& what, const std::string& to);
     };
 };

src/math/Box.cpp

@@ -200,7 +200,7 @@ Vector2D Hyprutils::Math::CBox::size() const {
 }
 
 Vector2D Hyprutils::Math::CBox::extent() const {
-  return pos() + size();
+    return pos() + size();
 }
 
 Vector2D Hyprutils::Math::CBox::closestPoint(const Vector2D& vec) const {

src/os/Process.cpp

@@ -86,14 +86,8 @@ bool Hyprutils::OS::CProcess::runSync() {
             return false;
 
         pollfd pollfds[2] = {
-            {
+            {.fd = outPipe[0], .events = POLLIN, .revents = 0},
-                .fd     = outPipe[0],
+            {.fd = errPipe[0], .events = POLLIN, .revents = 0},
-                .events = POLLIN,
-            },
-            {
-                .fd     = errPipe[0],
-                .events = POLLIN,
-            },
         };
 
         while (1337) {
@@ -188,26 +182,33 @@ bool Hyprutils::OS::CProcess::runAsync() {
             std::vector<const char*> argsC;
             argsC.emplace_back(strdup(binary.c_str()));
             for (auto& arg : args) {
-                // TODO: does this leak? Can we just pipe c_str() as the strings won't be realloc'd?
                 argsC.emplace_back(strdup(arg.c_str()));
             }
 
             argsC.emplace_back(nullptr);
 
             execvp(binary.c_str(), (char* const*)argsC.data());
-            // exit grandchild
             _exit(0);
         }
         close(socket[0]);
-        write(socket[1], &grandchild, sizeof(grandchild));
+        if (write(socket[1], &grandchild, sizeof(grandchild)) != sizeof(grandchild)) {
+            close(socket[1]);
+            _exit(1);
+        }
         close(socket[1]);
-        // exit child
         _exit(0);
     }
+
     // run in parent
     close(socket[1]);
-    read(socket[0], &grandchild, sizeof(grandchild));
+    ssize_t bytesRead = read(socket[0], &grandchild, sizeof(grandchild));
     close(socket[0]);
+
+    if (bytesRead != sizeof(grandchild)) {
+        waitpid(child, nullptr, 0);
+        return false;
+    }
+
     // clear child and leave grandchild to init
     waitpid(child, nullptr, 0);
 

src/signal/Signal.cpp

@@ -27,7 +27,7 @@ void Hyprutils::Signal::CSignal::emit(std::any data) {
         // vector and was removed during our iteration
         if (l.strongRef() == 1)
             continue;
-        
+
         l->emit(data);
     }
 
@@ -38,7 +38,7 @@ void Hyprutils::Signal::CSignal::emit(std::any data) {
     // release SPs
     listeners.clear();
 
-    // we cannot release any expired refs here as one of the listeners could've removed this object and 
+    // we cannot release any expired refs here as one of the listeners could've removed this object and
     // as such we'd be doing a UAF
 }
 
@@ -48,7 +48,7 @@ CHyprSignalListener Hyprutils::Signal::CSignal::registerListener(std::function<v
 
     // housekeeping: remove any stale listeners
     std::erase_if(m_vListeners, [](const auto& other) { return other.expired(); });
-    
+
     return listener;
 }
 

src/string/VarList.cpp

@@ -12,8 +12,7 @@ Hyprutils::String::CVarList::CVarList(const std::string& in, const size_t lastAr
     std::string args{in};
     size_t      idx = 0;
     size_t      pos = 0;
-    std::ranges::replace_if(
+    std::ranges::replace_if(args, [&](const char& c) { return delim == 's' ? std::isspace(c) : c == delim; }, 0);
-        args, [&](const char& c) { return delim == 's' ? std::isspace(c) : c == delim; }, 0);
 
     for (const auto& s : args | std::views::split(0)) {
         if (removeEmpty && s.empty())

tests/os.cpp

@@ -8,7 +8,7 @@
 using namespace Hyprutils::OS;
 
 int main(int argc, char** argv, char** envp) {
-    int ret = 0;
+    int      ret = 0;
 
     CProcess process("sh", {"-c", "echo \"Hello $WORLD!\""});
     process.addEnv("WORLD", "World");

tests/signal.cpp

@@ -10,7 +10,7 @@ int main(int argc, char** argv, char** envp) {
 
     CSignal signal;
     int     data     = 0;
-    auto    listener = signal.registerListener([&](std::any d) { data = 1; });
+    auto    listener = signal.registerListener([&]([[maybe_unused]] std::any d) { data = 1; });
 
     signal.emit();