From 0695324de7efc2bd3070de162e230327b2d15441 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Antonin=20D=C3=A9cimo?= Date: Fri, 9 Aug 2019 15:29:33 +0200 Subject: [PATCH] xdg_shell: remove variable self-assignment --- types/xdg_shell/wlr_xdg_positioner.c | 8 ++------ types/xdg_shell_v6/wlr_xdg_positioner_v6.c | 8 ++------ 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/types/xdg_shell/wlr_xdg_positioner.c b/types/xdg_shell/wlr_xdg_positioner.c index 6f902f92..95d5dbd3 100644 --- a/types/xdg_shell/wlr_xdg_positioner.c +++ b/types/xdg_shell/wlr_xdg_positioner.c @@ -222,20 +222,16 @@ struct wlr_box wlr_xdg_positioner_get_geometry( if (positioner_gravity_has_edge(positioner->gravity, XDG_POSITIONER_GRAVITY_TOP)) { geometry.y -= geometry.height; - } else if (positioner_gravity_has_edge(positioner->gravity, + } else if (!positioner_gravity_has_edge(positioner->gravity, XDG_POSITIONER_GRAVITY_BOTTOM)) { - geometry.y = geometry.y; - } else { geometry.y -= geometry.height / 2; } if (positioner_gravity_has_edge(positioner->gravity, XDG_POSITIONER_GRAVITY_LEFT)) { geometry.x -= geometry.width; - } else if (positioner_gravity_has_edge(positioner->gravity, + } else if (!positioner_gravity_has_edge(positioner->gravity, XDG_POSITIONER_GRAVITY_RIGHT)) { - geometry.x = geometry.x; - } else { geometry.x -= geometry.width / 2; } diff --git a/types/xdg_shell_v6/wlr_xdg_positioner_v6.c b/types/xdg_shell_v6/wlr_xdg_positioner_v6.c index 837f9290..eda19f30 100644 --- a/types/xdg_shell_v6/wlr_xdg_positioner_v6.c +++ b/types/xdg_shell_v6/wlr_xdg_positioner_v6.c @@ -154,17 +154,13 @@ struct wlr_box wlr_xdg_positioner_v6_get_geometry( if (positioner->gravity & ZXDG_POSITIONER_V6_GRAVITY_TOP) { geometry.y -= geometry.height; - } else if (positioner->gravity & ZXDG_POSITIONER_V6_GRAVITY_BOTTOM) { - geometry.y = geometry.y; - } else { + } else if (!(positioner->gravity & ZXDG_POSITIONER_V6_GRAVITY_BOTTOM)) { geometry.y -= geometry.height / 2; } if (positioner->gravity & ZXDG_POSITIONER_V6_GRAVITY_LEFT) { geometry.x -= geometry.width; - } else if (positioner->gravity & ZXDG_POSITIONER_V6_GRAVITY_RIGHT) { - geometry.x = geometry.x; - } else { + } else if (!(positioner->gravity & ZXDG_POSITIONER_V6_GRAVITY_RIGHT)) { geometry.x -= geometry.width / 2; }