From 072f6ed9775f7df8e17fad34459809c1d721b6ed Mon Sep 17 00:00:00 2001 From: Kirill Primak Date: Sat, 23 Mar 2024 23:33:14 +0300 Subject: [PATCH] viewporter: fix "has buffer" check Previously, cases when a viewport source box was updated without attaching a buffer weren't checked for correctness properly because the state's buffer would be NULL. Use wlr_surface_state_has_buffer() instead. --- types/wlr_viewporter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/wlr_viewporter.c b/types/wlr_viewporter.c index c6bda48a..38c20438 100644 --- a/types/wlr_viewporter.c +++ b/types/wlr_viewporter.c @@ -158,7 +158,7 @@ static void viewport_handle_surface_client_commit(struct wl_listener *listener, return; } - if (state->viewport.has_src && state->buffer != NULL && + if (state->viewport.has_src && wlr_surface_state_has_buffer(state) && !check_src_buffer_bounds(state)) { wlr_surface_reject_pending(viewport->surface, viewport->resource, WP_VIEWPORT_ERROR_OUT_OF_BUFFER,