From 0db191d3bfd7715b0609792a3117d04acc700063 Mon Sep 17 00:00:00 2001 From: Tudor Brindus Date: Sun, 24 Jan 2021 20:25:00 -0500 Subject: [PATCH] xwayland/selection: prevent fd leak on unsupported MIME type Since we never end up calling xcb_convert_selection, the file descriptor ends up getting leaked (i.e., not cleaned up within xwm_data_source_write). --- xwayland/selection/incoming.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xwayland/selection/incoming.c b/xwayland/selection/incoming.c index 7e2a0c14..257cccf1 100644 --- a/xwayland/selection/incoming.c +++ b/xwayland/selection/incoming.c @@ -158,6 +158,7 @@ static void source_send(struct wlr_xwm_selection *selection, if (!found) { wlr_log(WLR_DEBUG, "Cannot send X11 selection to Wayland: " "unsupported MIME type"); + close(fd); return; }