From f4e6b138fb442085787712d71029f8d16c663a27 Mon Sep 17 00:00:00 2001 From: Dominique Martinet Date: Mon, 14 Aug 2017 19:22:28 +0200 Subject: [PATCH 1/5] Move wl_shell into wlroots --- examples/compositor.h | 20 -------- examples/compositor/main.c | 5 +- examples/meson.build | 1 - include/wlr/types/wlr_wl_shell.h | 23 +++++++++ types/meson.build | 1 + .../wl_shell.c => types/wlr_wl_shell.c | 51 +++++++++++-------- 6 files changed, 58 insertions(+), 43 deletions(-) create mode 100644 include/wlr/types/wlr_wl_shell.h rename examples/compositor/wl_shell.c => types/wlr_wl_shell.c (74%) diff --git a/examples/compositor.h b/examples/compositor.h index 2847808f..b382cc7f 100644 --- a/examples/compositor.h +++ b/examples/compositor.h @@ -17,24 +17,4 @@ void wl_compositor_init(struct wl_display *display, struct wlr_surface; void wl_compositor_surface_destroyed(struct wl_compositor_state *compositor, struct wlr_surface *surface); - -struct wl_shell_state { - struct wl_global *wl_global; - struct wl_list wl_resources; -}; - -struct xdg_shell_state { - struct wl_global *wl_global; - struct wl_list wl_resources; - struct wl_display *display; -}; - -void wl_shell_init(struct wl_display *display, - struct wl_shell_state *state); - -void xdg_shell_init(struct wl_display *display, - struct xdg_shell_state *state); - -void xdg_shell_release(struct xdg_shell_state *state); - #endif diff --git a/examples/compositor/main.c b/examples/compositor/main.c index 16851614..1d3cb237 100644 --- a/examples/compositor/main.c +++ b/examples/compositor/main.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -21,7 +22,7 @@ struct sample_state { struct wlr_renderer *renderer; struct wl_compositor_state compositor; - struct wl_shell_state shell; + struct wlr_wl_shell wl_shell; struct wlr_xdg_shell_v6 *xdg_shell; }; @@ -75,7 +76,7 @@ int main() { state.renderer = wlr_gles2_renderer_init(compositor.backend); wl_display_init_shm(compositor.display); wl_compositor_init(compositor.display, &state.compositor, state.renderer); - wl_shell_init(compositor.display, &state.shell); + wlr_wl_shell_init(&state.wl_shell, compositor.display); state.xdg_shell = wlr_xdg_shell_v6_init(compositor.display); compositor_run(&compositor); diff --git a/examples/meson.build b/examples/meson.build index b40f7d8f..1ce9c342 100644 --- a/examples/meson.build +++ b/examples/meson.build @@ -11,7 +11,6 @@ executable('tablet', 'tablet.c', dependencies: wlroots, link_with: lib_shared) compositor_src = [ 'compositor/main.c', 'compositor/wl_compositor.c', - 'compositor/wl_shell.c', ] executable('compositor', compositor_src, diff --git a/include/wlr/types/wlr_wl_shell.h b/include/wlr/types/wlr_wl_shell.h new file mode 100644 index 00000000..f96cf702 --- /dev/null +++ b/include/wlr/types/wlr_wl_shell.h @@ -0,0 +1,23 @@ +#ifndef _WLR_WL_SHELL_H +#define _WLR_WL_SHELL_H +#include + +struct wlr_wl_shell { + struct wl_global *wl_global; + struct wl_list wl_resources; + + void *data; +}; + +struct wlr_wl_shell_surface { + struct wlr_texture *wlr_texture; + + void *data; +}; + + +void wlr_wl_shell_init(struct wlr_wl_shell *wlr_wl_shell, + struct wl_display *display); +void wlr_wl_shell_destroy(struct wlr_wl_shell *wlr_wl_shell); + +#endif diff --git a/types/meson.build b/types/meson.build index f97d7db8..943c83c3 100644 --- a/types/meson.build +++ b/types/meson.build @@ -9,6 +9,7 @@ lib_wlr_types = static_library('wlr_types', files( 'wlr_tablet_tool.c', 'wlr_touch.c', 'wlr_xdg_shell_v6.c', + 'wlr_wl_shell.c', ), include_directories: wlr_inc, dependencies: [wayland_server, pixman, wlr_protos]) diff --git a/examples/compositor/wl_shell.c b/types/wlr_wl_shell.c similarity index 74% rename from examples/compositor/wl_shell.c rename to types/wlr_wl_shell.c index e56f5c9e..a4fd896a 100644 --- a/examples/compositor/wl_shell.c +++ b/types/wlr_wl_shell.c @@ -1,8 +1,8 @@ #include #include #include +#include #include -#include "compositor.h" static void shell_surface_pong(struct wl_client *client, struct wl_resource *resource, uint32_t serial) { @@ -71,20 +71,18 @@ struct wl_shell_surface_interface shell_surface_interface = { .set_class = shell_surface_set_class, }; -struct shell_surface_state { - struct wlr_texture *wlr_texture; -}; - static void destroy_shell_surface(struct wl_resource *resource) { - struct shell_surface_state *state = wl_resource_get_user_data(resource); + struct wlr_wl_shell_surface *state = wl_resource_get_user_data(resource); + wl_list_remove(wl_resource_get_link(resource)); free(state); } -void wl_shell_get_shell_surface(struct wl_client *client, +static void wl_shell_get_shell_surface(struct wl_client *client, struct wl_resource *resource, uint32_t id, struct wl_resource *surface) { struct wlr_texture *wlr_texture = wl_resource_get_user_data(surface); - struct shell_surface_state *state = malloc(sizeof(struct shell_surface_state)); + struct wlr_wl_shell_surface *state = + calloc(1, sizeof(struct wlr_wl_shell_surface)); state->wlr_texture = wlr_texture; struct wl_resource *shell_surface_resource = wl_resource_create(client, &wl_shell_surface_interface, wl_resource_get_version(resource), id); @@ -97,9 +95,9 @@ static struct wl_shell_interface wl_shell_impl = { }; static void wl_shell_destroy(struct wl_resource *resource) { - struct wl_shell_state *state = wl_resource_get_user_data(resource); + struct wlr_wl_shell *wl_shell = wl_resource_get_user_data(resource); struct wl_resource *_resource = NULL; - wl_resource_for_each(_resource, &state->wl_resources) { + wl_resource_for_each(_resource, &wl_shell->wl_resources) { if (_resource == resource) { struct wl_list *link = wl_resource_get_link(_resource); wl_list_remove(link); @@ -108,10 +106,10 @@ static void wl_shell_destroy(struct wl_resource *resource) { } } -static void wl_shell_bind(struct wl_client *wl_client, void *_state, +static void wl_shell_bind(struct wl_client *wl_client, void *_wl_shell, uint32_t version, uint32_t id) { - struct wl_shell_state *state = _state; - assert(wl_client && state); + struct wlr_wl_shell *wl_shell = _wl_shell; + assert(wl_client && wl_shell); if (version > 1) { wlr_log(L_ERROR, "Client requested unsupported wl_shell version, disconnecting"); wl_client_destroy(wl_client); @@ -120,14 +118,27 @@ static void wl_shell_bind(struct wl_client *wl_client, void *_state, struct wl_resource *wl_resource = wl_resource_create( wl_client, &wl_shell_interface, version, id); wl_resource_set_implementation(wl_resource, &wl_shell_impl, - state, wl_shell_destroy); - wl_list_insert(&state->wl_resources, wl_resource_get_link(wl_resource)); + wl_shell, wl_shell_destroy); + wl_list_insert(&wl_shell->wl_resources, wl_resource_get_link(wl_resource)); } -void wl_shell_init(struct wl_display *display, - struct wl_shell_state *state) { +void wlr_wl_shell_init(struct wlr_wl_shell *wlr_wl_shell, + struct wl_display *display) { struct wl_global *wl_global = wl_global_create(display, - &wl_shell_interface, 1, state, wl_shell_bind); - state->wl_global = wl_global; - wl_list_init(&state->wl_resources); + &wl_shell_interface, 1, wlr_wl_shell, wl_shell_bind); + wlr_wl_shell->wl_global = wl_global; + wl_list_init(&wlr_wl_shell->wl_resources); +} + +void wlr_wl_shell_destroy(struct wlr_wl_shell *wlr_wl_shell) { + if (!wlr_wl_shell) { + return; + } + struct wl_resource *resource = NULL, *temp = NULL; + wl_resource_for_each_safe(resource, temp, &wlr_wl_shell->wl_resources) { + struct wl_list *link = wl_resource_get_link(resource); + wl_list_remove(link); + } + // TODO: destroy surfaces + wl_global_destroy(wlr_wl_shell->wl_global); } From 5dae8e1be81e12299d78b4319fd63c1edd24c08a Mon Sep 17 00:00:00 2001 From: Dominique Martinet Date: Tue, 15 Aug 2017 02:08:32 +0200 Subject: [PATCH 2/5] example compositor: only iterate over wl_shell and xdg_shell surfaces --- examples/compositor/main.c | 45 +++++++++++++++++------------ examples/compositor/wl_compositor.c | 3 +- include/wlr/types/wlr_wl_shell.h | 3 ++ types/wlr_wl_shell.c | 10 ++++++- types/wlr_xdg_shell_v6.c | 1 + 5 files changed, 42 insertions(+), 20 deletions(-) diff --git a/examples/compositor/main.c b/examples/compositor/main.c index 1d3cb237..2db4199c 100644 --- a/examples/compositor/main.c +++ b/examples/compositor/main.c @@ -33,6 +33,26 @@ static inline int64_t timespec_to_msec(const struct timespec *a) { return (int64_t)a->tv_sec * 1000 + a->tv_nsec / 1000000; } +void output_frame_handle_surface(struct sample_state *sample, + struct wlr_output *wlr_output, struct timespec *ts, + struct wl_resource *_res) { + struct wlr_surface *surface = wl_resource_get_user_data(_res); + float matrix[16]; + float transform[16]; + wlr_surface_flush_damage(surface); + if (surface->texture->valid) { + wlr_matrix_translate(&transform, 200, 200, 0); + wlr_surface_get_matrix(surface, &matrix, + &wlr_output->transform_matrix, &transform); + wlr_render_with_matrix(sample->renderer, surface->texture, &matrix); + + struct wlr_frame_callback *cb, *cnext; + wl_list_for_each_safe(cb, cnext, &surface->frame_callback_list, link) { + wl_callback_send_done(cb->resource, timespec_to_msec(ts)); + wl_resource_destroy(cb->resource); + } + } +} void handle_output_frame(struct output_state *output, struct timespec *ts) { struct compositor_state *state = output->compositor; struct sample_state *sample = state->data; @@ -41,24 +61,13 @@ void handle_output_frame(struct output_state *output, struct timespec *ts) { wlr_output_make_current(wlr_output); wlr_renderer_begin(sample->renderer, wlr_output); - struct wl_resource *_res; - float matrix[16]; - float transform[16]; - wl_list_for_each(_res, &sample->compositor.surfaces, link) { - struct wlr_surface *surface = wl_resource_get_user_data(_res); - wlr_surface_flush_damage(surface); - if (surface->texture->valid) { - wlr_matrix_translate(&transform, 200, 200, 0); - wlr_surface_get_matrix(surface, &matrix, - &wlr_output->transform_matrix, &transform); - wlr_render_with_matrix(sample->renderer, surface->texture, &matrix); - - struct wlr_frame_callback *cb, *cnext; - wl_list_for_each_safe(cb, cnext, &surface->frame_callback_list, link) { - wl_callback_send_done(cb->resource, timespec_to_msec(ts)); - wl_resource_destroy(cb->resource); - } - } + struct wlr_wl_shell_surface *wl_shell_surface; + wl_list_for_each(wl_shell_surface, &sample->wl_shell.surfaces, link) { + output_frame_handle_surface(sample, wlr_output, ts, wl_shell_surface->surface); + } + struct wlr_xdg_surface_v6 *xdg_surface; + wl_list_for_each(xdg_surface, &sample->xdg_shell->surfaces, link) { + output_frame_handle_surface(sample, wlr_output, ts, xdg_surface->surface); } wlr_renderer_end(sample->renderer); diff --git a/examples/compositor/wl_compositor.c b/examples/compositor/wl_compositor.c index e25dddac..034a7ff0 100644 --- a/examples/compositor/wl_compositor.c +++ b/examples/compositor/wl_compositor.c @@ -9,11 +9,12 @@ static void destroy_surface_listener(struct wl_listener *listener, void *data) { struct wlr_surface *surface = wl_resource_get_user_data(data); struct wl_compositor_state *state = surface->compositor_data; + assert(data == surface->resource); struct wl_resource *res = NULL; wl_list_for_each(res, &state->surfaces, link) { if (res == surface->resource) { - wl_list_remove(&res->link); + wl_list_remove(wl_resource_get_link(res)); break; } } diff --git a/include/wlr/types/wlr_wl_shell.h b/include/wlr/types/wlr_wl_shell.h index f96cf702..80583ae9 100644 --- a/include/wlr/types/wlr_wl_shell.h +++ b/include/wlr/types/wlr_wl_shell.h @@ -5,12 +5,15 @@ struct wlr_wl_shell { struct wl_global *wl_global; struct wl_list wl_resources; + struct wl_list surfaces; void *data; }; struct wlr_wl_shell_surface { + struct wl_resource *surface; struct wlr_texture *wlr_texture; + struct wl_list link; void *data; }; diff --git a/types/wlr_wl_shell.c b/types/wlr_wl_shell.c index a4fd896a..d84775d9 100644 --- a/types/wlr_wl_shell.c +++ b/types/wlr_wl_shell.c @@ -73,7 +73,7 @@ struct wl_shell_surface_interface shell_surface_interface = { static void destroy_shell_surface(struct wl_resource *resource) { struct wlr_wl_shell_surface *state = wl_resource_get_user_data(resource); - wl_list_remove(wl_resource_get_link(resource)); + wl_list_remove(&state->link); free(state); } @@ -81,13 +81,16 @@ static void wl_shell_get_shell_surface(struct wl_client *client, struct wl_resource *resource, uint32_t id, struct wl_resource *surface) { struct wlr_texture *wlr_texture = wl_resource_get_user_data(surface); + struct wlr_wl_shell *wlr_wl_shell = wl_resource_get_user_data(resource); struct wlr_wl_shell_surface *state = calloc(1, sizeof(struct wlr_wl_shell_surface)); state->wlr_texture = wlr_texture; + state->surface = surface; struct wl_resource *shell_surface_resource = wl_resource_create(client, &wl_shell_surface_interface, wl_resource_get_version(resource), id); wl_resource_set_implementation(shell_surface_resource, &shell_surface_interface, state, destroy_shell_surface); + wl_list_insert(&wlr_wl_shell->surfaces, &state->link); } static struct wl_shell_interface wl_shell_impl = { @@ -126,8 +129,13 @@ void wlr_wl_shell_init(struct wlr_wl_shell *wlr_wl_shell, struct wl_display *display) { struct wl_global *wl_global = wl_global_create(display, &wl_shell_interface, 1, wlr_wl_shell, wl_shell_bind); + if (!wl_global) { + // TODO: return failure somehow + return; + } wlr_wl_shell->wl_global = wl_global; wl_list_init(&wlr_wl_shell->wl_resources); + wl_list_init(&wlr_wl_shell->surfaces); } void wlr_wl_shell_destroy(struct wlr_wl_shell *wlr_wl_shell) { diff --git a/types/wlr_xdg_shell_v6.c b/types/wlr_xdg_shell_v6.c index 46f1c98e..465e55d7 100644 --- a/types/wlr_xdg_shell_v6.c +++ b/types/wlr_xdg_shell_v6.c @@ -93,6 +93,7 @@ static const struct zxdg_toplevel_v6_interface zxdg_toplevel_v6_implementation = static void xdg_surface_destroy(struct wl_resource *resource) { struct wlr_xdg_surface_v6 *surface = wl_resource_get_user_data(resource); + wl_list_remove(&surface->link); free(surface); } From d49edc8243c9ccba7a4a5dc210f87e9fba03a444 Mon Sep 17 00:00:00 2001 From: Dominique Martinet Date: Tue, 15 Aug 2017 15:27:28 +0200 Subject: [PATCH 3/5] wl_shell/compositor surface: do not check if it's in list before removing --- examples/compositor/wl_compositor.c | 12 +----------- types/wlr_wl_shell.c | 10 +--------- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/examples/compositor/wl_compositor.c b/examples/compositor/wl_compositor.c index 034a7ff0..0bab345d 100644 --- a/examples/compositor/wl_compositor.c +++ b/examples/compositor/wl_compositor.c @@ -7,17 +7,7 @@ #include "compositor.h" static void destroy_surface_listener(struct wl_listener *listener, void *data) { - struct wlr_surface *surface = wl_resource_get_user_data(data); - struct wl_compositor_state *state = surface->compositor_data; - assert(data == surface->resource); - - struct wl_resource *res = NULL; - wl_list_for_each(res, &state->surfaces, link) { - if (res == surface->resource) { - wl_list_remove(wl_resource_get_link(res)); - break; - } - } + wl_list_remove(wl_resource_get_link(data)); } static void wl_compositor_create_surface(struct wl_client *client, diff --git a/types/wlr_wl_shell.c b/types/wlr_wl_shell.c index d84775d9..154e54f9 100644 --- a/types/wlr_wl_shell.c +++ b/types/wlr_wl_shell.c @@ -98,15 +98,7 @@ static struct wl_shell_interface wl_shell_impl = { }; static void wl_shell_destroy(struct wl_resource *resource) { - struct wlr_wl_shell *wl_shell = wl_resource_get_user_data(resource); - struct wl_resource *_resource = NULL; - wl_resource_for_each(_resource, &wl_shell->wl_resources) { - if (_resource == resource) { - struct wl_list *link = wl_resource_get_link(_resource); - wl_list_remove(link); - break; - } - } + wl_list_remove(wl_resource_get_link(resource)); } static void wl_shell_bind(struct wl_client *wl_client, void *_wl_shell, From f9b55dfa952f3e405399cabf2963b2df376f044d Mon Sep 17 00:00:00 2001 From: Dominique Martinet Date: Tue, 15 Aug 2017 15:33:54 +0200 Subject: [PATCH 4/5] Make wlr_wl_shell_create work like xdg Also: - rename wlr_xdg_shell_v6_init to create as that is what it does - free wlr_xdg_shell on failure to create wl_global, the struct is not initialized enough to call destroy at that point --- examples/compositor/main.c | 11 +++++++---- include/wlr/types/wlr_wl_shell.h | 3 +-- include/wlr/types/wlr_xdg_shell_v6.h | 2 +- types/wlr_wl_shell.c | 14 ++++++++++---- types/wlr_xdg_shell_v6.c | 4 ++-- 5 files changed, 21 insertions(+), 13 deletions(-) diff --git a/examples/compositor/main.c b/examples/compositor/main.c index 2db4199c..243b1837 100644 --- a/examples/compositor/main.c +++ b/examples/compositor/main.c @@ -22,7 +22,7 @@ struct sample_state { struct wlr_renderer *renderer; struct wl_compositor_state compositor; - struct wlr_wl_shell wl_shell; + struct wlr_wl_shell *wl_shell; struct wlr_xdg_shell_v6 *xdg_shell; }; @@ -62,7 +62,7 @@ void handle_output_frame(struct output_state *output, struct timespec *ts) { wlr_renderer_begin(sample->renderer, wlr_output); struct wlr_wl_shell_surface *wl_shell_surface; - wl_list_for_each(wl_shell_surface, &sample->wl_shell.surfaces, link) { + wl_list_for_each(wl_shell_surface, &sample->wl_shell->surfaces, link) { output_frame_handle_surface(sample, wlr_output, ts, wl_shell_surface->surface); } struct wlr_xdg_surface_v6 *xdg_surface; @@ -85,8 +85,11 @@ int main() { state.renderer = wlr_gles2_renderer_init(compositor.backend); wl_display_init_shm(compositor.display); wl_compositor_init(compositor.display, &state.compositor, state.renderer); - wlr_wl_shell_init(&state.wl_shell, compositor.display); - state.xdg_shell = wlr_xdg_shell_v6_init(compositor.display); + state.wl_shell = wlr_wl_shell_create(compositor.display); + state.xdg_shell = wlr_xdg_shell_v6_create(compositor.display); compositor_run(&compositor); + + wlr_wl_shell_destroy(state.wl_shell); + wlr_xdg_shell_v6_destroy(state.xdg_shell); } diff --git a/include/wlr/types/wlr_wl_shell.h b/include/wlr/types/wlr_wl_shell.h index 80583ae9..a085711b 100644 --- a/include/wlr/types/wlr_wl_shell.h +++ b/include/wlr/types/wlr_wl_shell.h @@ -19,8 +19,7 @@ struct wlr_wl_shell_surface { }; -void wlr_wl_shell_init(struct wlr_wl_shell *wlr_wl_shell, - struct wl_display *display); +struct wlr_wl_shell *wlr_wl_shell_create(struct wl_display *display); void wlr_wl_shell_destroy(struct wlr_wl_shell *wlr_wl_shell); #endif diff --git a/include/wlr/types/wlr_xdg_shell_v6.h b/include/wlr/types/wlr_xdg_shell_v6.h index 07380a96..41cf483a 100644 --- a/include/wlr/types/wlr_xdg_shell_v6.h +++ b/include/wlr/types/wlr_xdg_shell_v6.h @@ -18,7 +18,7 @@ struct wlr_xdg_surface_v6 { void *data; }; -struct wlr_xdg_shell_v6 *wlr_xdg_shell_v6_init(struct wl_display *display); +struct wlr_xdg_shell_v6 *wlr_xdg_shell_v6_create(struct wl_display *display); void wlr_xdg_shell_v6_destroy(struct wlr_xdg_shell_v6 *xdg_shell); #endif diff --git a/types/wlr_wl_shell.c b/types/wlr_wl_shell.c index 154e54f9..c95845e8 100644 --- a/types/wlr_wl_shell.c +++ b/types/wlr_wl_shell.c @@ -117,17 +117,22 @@ static void wl_shell_bind(struct wl_client *wl_client, void *_wl_shell, wl_list_insert(&wl_shell->wl_resources, wl_resource_get_link(wl_resource)); } -void wlr_wl_shell_init(struct wlr_wl_shell *wlr_wl_shell, - struct wl_display *display) { +struct wlr_wl_shell *wlr_wl_shell_create(struct wl_display *display) { + struct wlr_wl_shell *wlr_wl_shell = + calloc(1, sizeof(struct wlr_wl_shell)); + if (!wlr_wl_shell) { + return NULL; + } struct wl_global *wl_global = wl_global_create(display, &wl_shell_interface, 1, wlr_wl_shell, wl_shell_bind); if (!wl_global) { - // TODO: return failure somehow - return; + free(wlr_wl_shell); + return NULL; } wlr_wl_shell->wl_global = wl_global; wl_list_init(&wlr_wl_shell->wl_resources); wl_list_init(&wlr_wl_shell->surfaces); + return wlr_wl_shell; } void wlr_wl_shell_destroy(struct wlr_wl_shell *wlr_wl_shell) { @@ -141,4 +146,5 @@ void wlr_wl_shell_destroy(struct wlr_wl_shell *wlr_wl_shell) { } // TODO: destroy surfaces wl_global_destroy(wlr_wl_shell->wl_global); + free(wlr_wl_shell); } diff --git a/types/wlr_xdg_shell_v6.c b/types/wlr_xdg_shell_v6.c index 465e55d7..da3c05df 100644 --- a/types/wlr_xdg_shell_v6.c +++ b/types/wlr_xdg_shell_v6.c @@ -179,7 +179,7 @@ static void xdg_shell_bind(struct wl_client *wl_client, void *_xdg_shell, wl_list_insert(&xdg_shell->wl_resources, wl_resource_get_link(wl_resource)); } -struct wlr_xdg_shell_v6 *wlr_xdg_shell_v6_init(struct wl_display *display) { +struct wlr_xdg_shell_v6 *wlr_xdg_shell_v6_create(struct wl_display *display) { struct wlr_xdg_shell_v6 *xdg_shell = calloc(1, sizeof(struct wlr_xdg_shell_v6)); if (!xdg_shell) { @@ -188,7 +188,7 @@ struct wlr_xdg_shell_v6 *wlr_xdg_shell_v6_init(struct wl_display *display) { struct wl_global *wl_global = wl_global_create(display, &zxdg_shell_v6_interface, 1, xdg_shell, xdg_shell_bind); if (!wl_global) { - wlr_xdg_shell_v6_destroy(xdg_shell); + free(xdg_shell); return NULL; } xdg_shell->wl_global = wl_global; From dca3f630ddeaa85b90e863cd181f2d27282a9cd3 Mon Sep 17 00:00:00 2001 From: Dominique Martinet Date: Tue, 15 Aug 2017 15:38:30 +0200 Subject: [PATCH 5/5] Fix wlr_wl/xdg_shell_destroy segfault - Implement xdg_shell_destroy and use it at the right place (impl->destroy is never called) - Remove wl_global_destroy for now, something is missing with the display/registry_resource_list --- types/wlr_wl_shell.c | 3 ++- types/wlr_xdg_shell_v6.c | 10 +++++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/types/wlr_wl_shell.c b/types/wlr_wl_shell.c index c95845e8..378758e8 100644 --- a/types/wlr_wl_shell.c +++ b/types/wlr_wl_shell.c @@ -145,6 +145,7 @@ void wlr_wl_shell_destroy(struct wlr_wl_shell *wlr_wl_shell) { wl_list_remove(link); } // TODO: destroy surfaces - wl_global_destroy(wlr_wl_shell->wl_global); + // TODO: this segfault (wl_display->registry_resource_list is not init) + // wl_global_destroy(wlr_wl_shell->wl_global); free(wlr_wl_shell); } diff --git a/types/wlr_xdg_shell_v6.c b/types/wlr_xdg_shell_v6.c index da3c05df..45c5a3f0 100644 --- a/types/wlr_xdg_shell_v6.c +++ b/types/wlr_xdg_shell_v6.c @@ -158,12 +158,15 @@ static void xdg_shell_pong(struct wl_client *client, } static struct zxdg_shell_v6_interface xdg_shell_impl = { - .destroy = resource_destroy, .create_positioner = xdg_shell_create_positioner, .get_xdg_surface = xdg_shell_get_xdg_surface, .pong = xdg_shell_pong, }; +static void xdg_shell_destroy(struct wl_resource *resource) { + wl_list_remove(wl_resource_get_link(resource)); +} + static void xdg_shell_bind(struct wl_client *wl_client, void *_xdg_shell, uint32_t version, uint32_t id) { struct wlr_xdg_shell_v6 *xdg_shell = _xdg_shell; @@ -175,7 +178,7 @@ static void xdg_shell_bind(struct wl_client *wl_client, void *_xdg_shell, } struct wl_resource *wl_resource = wl_resource_create( wl_client, &zxdg_shell_v6_interface, version, id); - wl_resource_set_implementation(wl_resource, &xdg_shell_impl, xdg_shell, NULL); + wl_resource_set_implementation(wl_resource, &xdg_shell_impl, xdg_shell, xdg_shell_destroy); wl_list_insert(&xdg_shell->wl_resources, wl_resource_get_link(wl_resource)); } @@ -207,6 +210,7 @@ void wlr_xdg_shell_v6_destroy(struct wlr_xdg_shell_v6 *xdg_shell) { wl_list_remove(link); } // TODO: destroy surfaces - wl_global_destroy(xdg_shell->wl_global); + // TODO: this segfault (wl_display->registry_resource_list is not init) + // wl_global_destroy(xdg_shell->wl_global); free(xdg_shell); }