From 2fddec56e8bac17c4c5b5e8ae396fe024fd76b40 Mon Sep 17 00:00:00 2001 From: Manuel Stoeckl Date: Sun, 9 Feb 2020 10:24:44 -0500 Subject: [PATCH] output: fix output transform compositions This change ensures that wlr_output_transform_compose correctly composes transforms when the first transform includes a rotation and the second transform includes a flip. --- types/wlr_output.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/types/wlr_output.c b/types/wlr_output.c index 2207c2e5..611309db 100644 --- a/types/wlr_output.c +++ b/types/wlr_output.c @@ -1118,7 +1118,15 @@ enum wl_output_transform wlr_output_transform_invert( enum wl_output_transform wlr_output_transform_compose( enum wl_output_transform tr_a, enum wl_output_transform tr_b) { uint32_t flipped = (tr_a ^ tr_b) & WL_OUTPUT_TRANSFORM_FLIPPED; - uint32_t rotated = - (tr_a + tr_b) & (WL_OUTPUT_TRANSFORM_90 | WL_OUTPUT_TRANSFORM_180); + uint32_t rotation_mask = WL_OUTPUT_TRANSFORM_90 | WL_OUTPUT_TRANSFORM_180; + uint32_t rotated; + if (tr_b & WL_OUTPUT_TRANSFORM_FLIPPED) { + // When a rotation of k degrees is followed by a flip, the + // equivalent transform is a flip followed by a rotation of + // -k degrees. + rotated = (tr_b - tr_a) & rotation_mask; + } else { + rotated = (tr_a + tr_b) & rotation_mask; + } return flipped | rotated; }