From 4ec683ad1c62fe47e0a3bc238446ae8e79f08246 Mon Sep 17 00:00:00 2001
From: Kirill Primak <vyivel@eclair.cafe>
Date: Thu, 13 Jan 2022 11:55:09 +0300
Subject: [PATCH] surface: introduce events.client_commit

wlr_surface.events.client_commit is fired when wl_surface.commit
request is received.
---
 include/wlr/types/wlr_surface.h |  2 ++
 types/wlr_surface.c             | 46 ++++++++++++++++++---------------
 2 files changed, 27 insertions(+), 21 deletions(-)

diff --git a/include/wlr/types/wlr_surface.h b/include/wlr/types/wlr_surface.h
index 59168eaa..ca1a55ac 100644
--- a/include/wlr/types/wlr_surface.h
+++ b/include/wlr/types/wlr_surface.h
@@ -140,6 +140,7 @@ struct wlr_surface {
 	void *role_data; // role-specific data
 
 	struct {
+		struct wl_signal client_commit;
 		struct wl_signal commit;
 		struct wl_signal new_subsurface;
 		struct wl_signal destroy;
@@ -188,6 +189,7 @@ struct wlr_subsurface {
 	bool added;
 
 	struct wl_listener surface_destroy;
+	struct wl_listener surface_client_commit;
 	struct wl_listener parent_destroy;
 
 	struct {
diff --git a/types/wlr_surface.c b/types/wlr_surface.c
index fc4a509c..1b49a21b 100644
--- a/types/wlr_surface.c
+++ b/types/wlr_surface.c
@@ -520,32 +520,13 @@ static void subsurface_parent_commit(struct wlr_subsurface *subsurface) {
 	}
 }
 
-static void subsurface_commit(struct wlr_subsurface *subsurface) {
-	struct wlr_surface *surface = subsurface->surface;
-
-	if (subsurface_is_synchronized(subsurface)) {
-		if (subsurface->has_cache) {
-			// We already lock a previous commit. The prevents any future
-			// commit to be applied before we release the previous commit.
-			return;
-		}
-		subsurface->has_cache = true;
-		subsurface->cached_seq = wlr_surface_lock_pending(surface);
-	}
-}
-
 static void surface_handle_commit(struct wl_client *client,
 		struct wl_resource *resource) {
 	struct wlr_surface *surface = wlr_surface_from_resource(resource);
-
-	struct wlr_subsurface *subsurface = wlr_surface_is_subsurface(surface) ?
-		wlr_subsurface_from_wlr_surface(surface) : NULL;
-	if (subsurface != NULL) {
-		subsurface_commit(subsurface);
-	}
-
 	surface_finalize_pending(surface);
 
+	wlr_signal_emit_safe(&surface->events.client_commit, NULL);
+
 	if (surface->role && surface->role->precommit) {
 		surface->role->precommit(surface);
 	}
@@ -668,6 +649,7 @@ static void subsurface_destroy(struct wlr_subsurface *subsurface) {
 	wlr_signal_emit_safe(&subsurface->events.destroy, subsurface);
 
 	wl_list_remove(&subsurface->surface_destroy.link);
+	wl_list_remove(&subsurface->surface_client_commit.link);
 
 	if (subsurface->parent) {
 		wl_list_remove(&subsurface->current.link);
@@ -747,6 +729,7 @@ struct wlr_surface *surface_create(struct wl_client *client,
 	surface_state_init(&surface->pending);
 	surface->pending.seq = 1;
 
+	wl_signal_init(&surface->events.client_commit);
 	wl_signal_init(&surface->events.commit);
 	wl_signal_init(&surface->events.destroy);
 	wl_signal_init(&surface->events.new_subsurface);
@@ -1108,6 +1091,23 @@ static void subsurface_handle_surface_destroy(struct wl_listener *listener,
 	subsurface_destroy(subsurface);
 }
 
+static void subsurface_handle_surface_client_commit(
+		struct wl_listener *listener, void *data) {
+	struct wlr_subsurface *subsurface =
+		wl_container_of(listener, subsurface, surface_client_commit);
+	struct wlr_surface *surface = subsurface->surface;
+
+	if (subsurface_is_synchronized(subsurface)) {
+		if (subsurface->has_cache) {
+			// We already lock a previous commit. The prevents any future
+			// commit to be applied before we release the previous commit.
+			return;
+		}
+		subsurface->has_cache = true;
+		subsurface->cached_seq = wlr_surface_lock_pending(surface);
+	}
+}
+
 struct wlr_subsurface *subsurface_create(struct wlr_surface *surface,
 		struct wlr_surface *parent, uint32_t version, uint32_t id) {
 	struct wl_client *client = wl_resource_get_client(surface->resource);
@@ -1136,6 +1136,10 @@ struct wlr_subsurface *subsurface_create(struct wlr_surface *surface,
 
 	wl_signal_add(&surface->events.destroy, &subsurface->surface_destroy);
 	subsurface->surface_destroy.notify = subsurface_handle_surface_destroy;
+	wl_signal_add(&surface->events.client_commit,
+		&subsurface->surface_client_commit);
+	subsurface->surface_client_commit.notify =
+		subsurface_handle_surface_client_commit;
 
 	// link parent
 	subsurface->parent = parent;