From 6a8f17b5f636a0ce90a4ed8342803baee30de1b3 Mon Sep 17 00:00:00 2001 From: Scott Anderson Date: Wed, 6 Mar 2019 10:49:59 +1300 Subject: [PATCH] backend/drm: Don't fail on failing to find overlay format Some hardware exists which doesn't support XRGB/ARGB overlays, and we aren't even using overlay planes, so don't fail on trying to find a format. --- backend/drm/drm.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/backend/drm/drm.c b/backend/drm/drm.c index 40a1fdbf..7fd36794 100644 --- a/backend/drm/drm.c +++ b/backend/drm/drm.c @@ -133,7 +133,10 @@ static bool init_planes(struct wlr_drm_backend *drm) { rgb_format = fmt; } } - if (rgb_format == DRM_FORMAT_INVALID) { + // Some overlays exist which don't support XRGB8888/ARGB8888 + // We aren't even using overlay planes currently, so don't fail + // on something unnecessary. + if (type != DRM_PLANE_TYPE_OVERLAY && rgb_format == DRM_FORMAT_INVALID) { wlr_log(WLR_ERROR, "Failed to find an RGB format for plane %zu", i); drmModeFreePlane(plane); goto error_planes;