From 6e8892d4d71c231120ddcfb15e1a86c30cf9e497 Mon Sep 17 00:00:00 2001 From: emersion Date: Sun, 22 Jul 2018 17:06:30 +0100 Subject: [PATCH] gamma-control-v1: don't insert control in the list before checking unicity --- types/wlr_gamma_control_v1.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/types/wlr_gamma_control_v1.c b/types/wlr_gamma_control_v1.c index 36d9296b..063837fc 100644 --- a/types/wlr_gamma_control_v1.c +++ b/types/wlr_gamma_control_v1.c @@ -148,7 +148,7 @@ static void gamma_control_manager_get_gamma_control(struct wl_client *client, gamma_control->output_destroy_listener.notify = gamma_control_handle_output_destroy; - wl_list_insert(&manager->controls, &gamma_control->link); + wl_list_init(&gamma_control->link); if (!output->impl->set_gamma) { zwlr_gamma_control_v1_send_failed(gamma_control->resource); @@ -165,6 +165,8 @@ static void gamma_control_manager_get_gamma_control(struct wl_client *client, } } + wl_list_remove(&gamma_control->link); + wl_list_insert(&manager->controls, &gamma_control->link); zwlr_gamma_control_v1_send_gamma_size(gamma_control->resource, wlr_output_get_gamma_size(output)); }