hyprwm/wlroots-hyprland
1
0
Fork 0
mirror of https://github.com/hyprwm/wlroots-hyprland.git synced 2024-11-02 11:55:59 +01:00
Code Issues Projects Releases Packages Wiki Activity

gamma-control-v1: fix handling of duplicate control

Browse source 
When a new client comes in and tries to create a
zwlr_gamma_control_v1 object for an output which already has one,
we were destroying the old object and early-returning. The early
return causes the new object to not be set up properly: it's not
inserted in the list and doesn't get the gamma_size event.

Fix this by destroying the new object, and leave the old object
intact, which is what was the intent I think.

Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3605
This commit is contained in:
Simon Ser 2023-03-06 11:37:32 +01:00
parent 3a200aa279
commit 9108717d5d
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
types/wlr_gamma_control_v1.c
View file

@ -219,8 +219,8 @@ static void gamma_control_manager_get_gamma_control(struct wl_client *client,
struct wlr_gamma_control_v1 *gc; struct wlr_gamma_control_v1 *gc;
wl_list_for_each(gc, &manager->controls, link) { wl_list_for_each(gc, &manager->controls, link) {
if (gc->output == output) { if (gc->output == output) {
zwlr_gamma_control_v1_send_failed(gc->resource); zwlr_gamma_control_v1_send_failed(gamma_control->resource);
gamma_control_destroy(gc); gamma_control_destroy(gamma_control);
return; return;
} }
} }