From bf3f60ff731472e875790633a1660b5e91abdce5 Mon Sep 17 00:00:00 2001 From: Kirill Primak Date: Fri, 4 Mar 2022 00:59:22 +0300 Subject: [PATCH] xdg-toplevel: treat unmapped parents as NULL --- types/xdg_shell/wlr_xdg_toplevel.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/types/xdg_shell/wlr_xdg_toplevel.c b/types/xdg_shell/wlr_xdg_toplevel.c index ed304cfc..a78a4e89 100644 --- a/types/xdg_shell/wlr_xdg_toplevel.c +++ b/types/xdg_shell/wlr_xdg_toplevel.c @@ -151,11 +151,13 @@ void wlr_xdg_toplevel_set_parent(struct wlr_xdg_toplevel *toplevel, wl_list_remove(&toplevel->parent_unmap.link); } - toplevel->parent = parent; - if (parent) { + if (parent && parent->base->mapped) { + toplevel->parent = parent; toplevel->parent_unmap.notify = handle_parent_unmap; wl_signal_add(&toplevel->parent->base->events.unmap, - &toplevel->parent_unmap); + &toplevel->parent_unmap); + } else { + toplevel->parent = NULL; } wlr_signal_emit_safe(&toplevel->events.set_parent, NULL);