From c2952411d388c09fa4e90aca3c27e5d2e74bd413 Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Sat, 4 Jun 2022 23:03:39 +0200 Subject: [PATCH] examples/screencopy-dmabuf: stop using strncpy strncpy doesn't guarantee that the result is zero-terminated. --- examples/screencopy-dmabuf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/examples/screencopy-dmabuf.c b/examples/screencopy-dmabuf.c index e7657e1a..f16c29da 100644 --- a/examples/screencopy-dmabuf.c +++ b/examples/screencopy-dmabuf.c @@ -76,7 +76,7 @@ static const struct format formats[] = { {DRM_FORMAT_ABGR8888, false}, }; -static bool find_render_node(char *node, size_t maxlen) { +static bool find_render_node(char *node, size_t node_size) { bool r = false; drmDevice *devices[64]; @@ -87,8 +87,7 @@ static bool find_render_node(char *node, size_t maxlen) { continue; } - strncpy(node, dev->nodes[DRM_NODE_RENDER], maxlen - 1); - node[maxlen - 1] = '\0'; + snprintf(node, node_size, "%s", dev->nodes[DRM_NODE_RENDER]); r = true; break; }