From c72efcd1ce070dc5a55625de1b0ef2c6630ce8dc Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Tue, 21 Jul 2020 13:16:28 +0200 Subject: [PATCH] xwayland/xwm: use initializer for props in xsurface_set_wm_state This avoids uninitialized items and makes it clear where the magic number 2 is coming from. --- xwayland/xwm.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/xwayland/xwm.c b/xwayland/xwm.c index a34d56a2..e1050308 100644 --- a/xwayland/xwm.c +++ b/xwayland/xwm.c @@ -913,10 +913,7 @@ static void xwm_handle_configure_notify(struct wlr_xwm *xwm, static void xsurface_set_wm_state(struct wlr_xwayland_surface *xsurface, int32_t state) { struct wlr_xwm *xwm = xsurface->xwm; - uint32_t property[2]; - - property[0] = state; - property[1] = XCB_WINDOW_NONE; + uint32_t property[] = { state, XCB_WINDOW_NONE }; xcb_change_property(xwm->xcb_conn, XCB_PROP_MODE_REPLACE, @@ -924,7 +921,7 @@ static void xsurface_set_wm_state(struct wlr_xwayland_surface *xsurface, xwm->atoms[WM_STATE], xwm->atoms[WM_STATE], 32, // format - 2, property); + sizeof(property) / sizeof(property[0]), property); } static void xwm_handle_map_request(struct wlr_xwm *xwm,