From e449c1dec877d8d33286f497e7f7db07bbbfb87e Mon Sep 17 00:00:00 2001 From: Tobias Predel Date: Sun, 14 May 2023 16:29:21 +0200 Subject: [PATCH] wlr_drm_format_set_copy: Do not allocate heap Address Sanitizer reported two memory leaks because of fmt not being freed in wlr_drm_format_set_copy. This commit fixes the memory leak by removing the allocation to the heap. The struct is allocated to the stack anyway. --- render/drm_format_set.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/render/drm_format_set.c b/render/drm_format_set.c index df3efd30..b8c33aa6 100644 --- a/render/drm_format_set.c +++ b/render/drm_format_set.c @@ -153,12 +153,6 @@ bool wlr_drm_format_set_copy(struct wlr_drm_format_set *dst, const struct wlr_dr size_t i; for (i = 0; i < src->len; i++) { - struct wlr_drm_format *fmt = calloc(1, sizeof(*fmt)); - if (!fmt) { - wlr_drm_format_set_finish(&out); - return false; - } - out.formats[out.len] = (struct wlr_drm_format){0}; if (!wlr_drm_format_copy(&out.formats[out.len], &src->formats[i])) { wlr_drm_format_set_finish(&out);