diff --git a/include/types/wlr_xdg_shell.h b/include/types/wlr_xdg_shell.h
index d8905bcf..9a34c49c 100644
--- a/include/types/wlr_xdg_shell.h
+++ b/include/types/wlr_xdg_shell.h
@@ -29,7 +29,7 @@ struct wlr_xdg_positioner_resource *get_xdg_positioner_from_resource(
 
 void create_xdg_popup(struct wlr_xdg_surface *xdg_surface,
 	struct wlr_xdg_surface *parent,
-	struct wlr_xdg_positioner_resource *positioner, int32_t id);
+	struct wlr_xdg_positioner_resource *positioner, uint32_t id);
 void handle_xdg_surface_popup_committed(struct wlr_xdg_surface *surface);
 struct wlr_xdg_popup_grab *get_xdg_shell_popup_grab_from_seat(
 	struct wlr_xdg_shell *shell, struct wlr_seat *seat);
diff --git a/types/xdg_shell/wlr_xdg_popup.c b/types/xdg_shell/wlr_xdg_popup.c
index c8d76ee1..de1987c9 100644
--- a/types/xdg_shell/wlr_xdg_popup.c
+++ b/types/xdg_shell/wlr_xdg_popup.c
@@ -299,7 +299,7 @@ const struct wlr_surface_role xdg_popup_surface_role = {
 
 void create_xdg_popup(struct wlr_xdg_surface *xdg_surface,
 		struct wlr_xdg_surface *parent,
-		struct wlr_xdg_positioner_resource *positioner, int32_t id) {
+		struct wlr_xdg_positioner_resource *positioner, uint32_t id) {
 	if (positioner->attrs.size.width == 0 ||
 			positioner->attrs.anchor_rect.width == 0) {
 		wl_resource_post_error(xdg_surface->resource,