mirror of
https://github.com/hyprwm/wlroots-hyprland.git
synced 2024-11-02 03:45:58 +01:00
2fa257313a
Previously, the clipboard and primary selections shared the same window.
This was racey, and could have led to pasting failures.
On xfixes selection owner change notification, the logic for requesting
the supported mimetypes of the new owner's selection looks like:
xcb_convert_selection(
xwm->xcb_conn,
selection->window,
selection->atom,
xwm->atoms[TARGETS],
xwm->atoms[WL_SELECTION],
selection->timestamp
);
This means ask the selection owner to write its TARGETS for the
`selection->atom` selection (one of PRIMARY, CLIPBOARD, DND_SELECTION)
to `selection->window`'s WL_SELECTION atom.
However, `selection->window` is shared for both PRIMARY and CLIPBOARD
selections, and WL_SELECTION is used as the target atom in both cases.
So, there's a race when both selections change at the same time.
The CLIPBOARD selection might support mimetypes {A, B, C}, and the
PRIMARY only {A, B}. If the ConvertSelection requests/responses "cross
on the wire", so to speak, wlroots can end up believing that the PRIMARY
selection also supports C.
A Wayland client may then ask for the PRIMARY selection in C format,
which will fail with "convert selection failed".
This commit fixes this by using a separate window for PRIMARY and
CLIPBOARD target requests, so that WL_SELECTION can be used as the
target atom in both cases.
153 lines
3.6 KiB
C
153 lines
3.6 KiB
C
#ifndef XWAYLAND_XWM_H
|
|
#define XWAYLAND_XWM_H
|
|
|
|
#include <wayland-server-core.h>
|
|
#include <wlr/config.h>
|
|
#include <wlr/xwayland.h>
|
|
#include <xcb/render.h>
|
|
#if WLR_HAS_XCB_ICCCM
|
|
#include <xcb/xcb_icccm.h>
|
|
#endif
|
|
#if WLR_HAS_XCB_ERRORS
|
|
#include <xcb/xcb_errors.h>
|
|
#endif
|
|
#include "xwayland/selection.h"
|
|
|
|
/* This is in xcb/xcb_event.h, but pulling xcb-util just for a constant
|
|
* others redefine anyway is meh
|
|
*/
|
|
#define XCB_EVENT_RESPONSE_TYPE_MASK (0x7f)
|
|
|
|
enum atom_name {
|
|
WL_SURFACE_ID,
|
|
WM_DELETE_WINDOW,
|
|
WM_PROTOCOLS,
|
|
WM_HINTS,
|
|
WM_NORMAL_HINTS,
|
|
WM_SIZE_HINTS,
|
|
WM_WINDOW_ROLE,
|
|
MOTIF_WM_HINTS,
|
|
UTF8_STRING,
|
|
WM_S0,
|
|
NET_SUPPORTED,
|
|
NET_WM_CM_S0,
|
|
NET_WM_PID,
|
|
NET_WM_NAME,
|
|
NET_WM_STATE,
|
|
NET_WM_WINDOW_TYPE,
|
|
WM_TAKE_FOCUS,
|
|
WINDOW,
|
|
NET_ACTIVE_WINDOW,
|
|
NET_WM_MOVERESIZE,
|
|
NET_SUPPORTING_WM_CHECK,
|
|
NET_WM_STATE_FOCUSED,
|
|
NET_WM_STATE_MODAL,
|
|
NET_WM_STATE_FULLSCREEN,
|
|
NET_WM_STATE_MAXIMIZED_VERT,
|
|
NET_WM_STATE_MAXIMIZED_HORZ,
|
|
NET_WM_STATE_HIDDEN,
|
|
NET_WM_PING,
|
|
WM_CHANGE_STATE,
|
|
WM_STATE,
|
|
CLIPBOARD,
|
|
PRIMARY,
|
|
WL_SELECTION,
|
|
TARGETS,
|
|
CLIPBOARD_MANAGER,
|
|
INCR,
|
|
TEXT,
|
|
TIMESTAMP,
|
|
DELETE,
|
|
NET_WM_WINDOW_TYPE_NORMAL,
|
|
NET_WM_WINDOW_TYPE_UTILITY,
|
|
NET_WM_WINDOW_TYPE_TOOLTIP,
|
|
NET_WM_WINDOW_TYPE_DND,
|
|
NET_WM_WINDOW_TYPE_DROPDOWN_MENU,
|
|
NET_WM_WINDOW_TYPE_POPUP_MENU,
|
|
NET_WM_WINDOW_TYPE_COMBO,
|
|
NET_WM_WINDOW_TYPE_MENU,
|
|
NET_WM_WINDOW_TYPE_NOTIFICATION,
|
|
NET_WM_WINDOW_TYPE_SPLASH,
|
|
DND_SELECTION,
|
|
DND_AWARE,
|
|
DND_STATUS,
|
|
DND_POSITION,
|
|
DND_ENTER,
|
|
DND_LEAVE,
|
|
DND_DROP,
|
|
DND_FINISHED,
|
|
DND_PROXY,
|
|
DND_TYPE_LIST,
|
|
DND_ACTION_MOVE,
|
|
DND_ACTION_COPY,
|
|
DND_ACTION_ASK,
|
|
DND_ACTION_PRIVATE,
|
|
NET_CLIENT_LIST,
|
|
ATOM_LAST // keep last
|
|
};
|
|
|
|
extern const char *atom_map[ATOM_LAST];
|
|
|
|
struct wlr_xwm {
|
|
struct wlr_xwayland *xwayland;
|
|
struct wl_event_source *event_source;
|
|
struct wlr_seat *seat;
|
|
uint32_t ping_timeout;
|
|
|
|
xcb_atom_t atoms[ATOM_LAST];
|
|
xcb_connection_t *xcb_conn;
|
|
xcb_screen_t *screen;
|
|
xcb_window_t window;
|
|
xcb_visualid_t visual_id;
|
|
xcb_colormap_t colormap;
|
|
xcb_render_pictformat_t render_format_id;
|
|
xcb_cursor_t cursor;
|
|
|
|
struct wlr_xwm_selection clipboard_selection;
|
|
struct wlr_xwm_selection primary_selection;
|
|
struct wlr_xwm_selection dnd_selection;
|
|
|
|
struct wlr_xwayland_surface *focus_surface;
|
|
|
|
struct wl_list surfaces; // wlr_xwayland_surface::link
|
|
struct wl_list unpaired_surfaces; // wlr_xwayland_surface::unpaired_link
|
|
|
|
struct wlr_drag *drag;
|
|
struct wlr_xwayland_surface *drag_focus;
|
|
|
|
const xcb_query_extension_reply_t *xfixes;
|
|
#if WLR_HAS_XCB_ERRORS
|
|
xcb_errors_context_t *errors_context;
|
|
#endif
|
|
unsigned int last_focus_seq;
|
|
|
|
struct wl_listener compositor_new_surface;
|
|
struct wl_listener compositor_destroy;
|
|
struct wl_listener seat_set_selection;
|
|
struct wl_listener seat_set_primary_selection;
|
|
struct wl_listener seat_start_drag;
|
|
struct wl_listener seat_drag_focus;
|
|
struct wl_listener seat_drag_motion;
|
|
struct wl_listener seat_drag_drop;
|
|
struct wl_listener seat_drag_destroy;
|
|
struct wl_listener seat_drag_source_destroy;
|
|
};
|
|
|
|
struct wlr_xwm *xwm_create(struct wlr_xwayland *wlr_xwayland, int wm_fd);
|
|
|
|
void xwm_destroy(struct wlr_xwm *xwm);
|
|
|
|
void xwm_set_cursor(struct wlr_xwm *xwm, const uint8_t *pixels, uint32_t stride,
|
|
uint32_t width, uint32_t height, int32_t hotspot_x, int32_t hotspot_y);
|
|
|
|
int xwm_handle_selection_event(struct wlr_xwm *xwm, xcb_generic_event_t *event);
|
|
int xwm_handle_selection_client_message(struct wlr_xwm *xwm,
|
|
xcb_client_message_event_t *ev);
|
|
|
|
void xwm_set_seat(struct wlr_xwm *xwm, struct wlr_seat *seat);
|
|
|
|
char *xwm_get_atom_name(struct wlr_xwm *xwm, xcb_atom_t atom);
|
|
bool xwm_atoms_contains(struct wlr_xwm *xwm, xcb_atom_t *atoms,
|
|
size_t num_atoms, enum atom_name needle);
|
|
|
|
#endif
|