mirror of
https://github.com/hyprwm/wlroots-hyprland.git
synced 2024-11-02 11:55:59 +01:00
f0d455f088
These operations are done in 32-bit arithmetics before being casted to 64-bit, thus can overflow before the cast. Casting early fixes the issue. Found through static analysis
256 lines
7.3 KiB
C
256 lines
7.3 KiB
C
#include <gbm.h>
|
|
#include <stdlib.h>
|
|
#include <wlr/util/log.h>
|
|
#include <xf86drm.h>
|
|
#include <xf86drmMode.h>
|
|
#include "backend/drm/drm.h"
|
|
#include "backend/drm/iface.h"
|
|
#include "backend/drm/util.h"
|
|
|
|
struct atomic {
|
|
drmModeAtomicReq *req;
|
|
int cursor;
|
|
bool failed;
|
|
};
|
|
|
|
static void atomic_begin(struct wlr_drm_crtc *crtc, struct atomic *atom) {
|
|
if (!crtc->atomic) {
|
|
crtc->atomic = drmModeAtomicAlloc();
|
|
if (!crtc->atomic) {
|
|
wlr_log_errno(L_ERROR, "Allocation failed");
|
|
atom->failed = true;
|
|
return;
|
|
}
|
|
}
|
|
|
|
atom->req = crtc->atomic;
|
|
atom->cursor = drmModeAtomicGetCursor(atom->req);
|
|
atom->failed = false;
|
|
}
|
|
|
|
static bool atomic_end(int drm_fd, struct atomic *atom) {
|
|
if (atom->failed) {
|
|
return false;
|
|
}
|
|
|
|
uint32_t flags = DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_NONBLOCK;
|
|
if (drmModeAtomicCommit(drm_fd, atom->req, flags, NULL)) {
|
|
wlr_log_errno(L_ERROR, "Atomic test failed");
|
|
drmModeAtomicSetCursor(atom->req, atom->cursor);
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
static bool atomic_commit(int drm_fd, struct atomic *atom,
|
|
struct wlr_drm_connector *conn, uint32_t flags, bool modeset) {
|
|
if (atom->failed) {
|
|
return false;
|
|
}
|
|
|
|
int ret = drmModeAtomicCommit(drm_fd, atom->req, flags, conn);
|
|
if (ret) {
|
|
wlr_log_errno(L_ERROR, "%s: Atomic commit failed (%s)",
|
|
conn->output.name, modeset ? "modeset" : "pageflip");
|
|
|
|
// Try to commit without new changes
|
|
drmModeAtomicSetCursor(atom->req, atom->cursor);
|
|
if (drmModeAtomicCommit(drm_fd, atom->req, flags, conn)) {
|
|
wlr_log_errno(L_ERROR,
|
|
"%s: Atomic commit without new changes failed (%s)",
|
|
conn->output.name, modeset ? "modeset" : "pageflip");
|
|
}
|
|
}
|
|
|
|
drmModeAtomicSetCursor(atom->req, 0);
|
|
|
|
return !ret;
|
|
}
|
|
|
|
static inline void atomic_add(struct atomic *atom, uint32_t id, uint32_t prop, uint64_t val) {
|
|
if (!atom->failed && drmModeAtomicAddProperty(atom->req, id, prop, val) < 0) {
|
|
wlr_log_errno(L_ERROR, "Failed to add atomic DRM property");
|
|
atom->failed = true;
|
|
}
|
|
}
|
|
|
|
static void set_plane_props(struct atomic *atom, struct wlr_drm_plane *plane,
|
|
uint32_t crtc_id, uint32_t fb_id, bool set_crtc_xy) {
|
|
uint32_t id = plane->id;
|
|
const union wlr_drm_plane_props *props = &plane->props;
|
|
|
|
// The src_* properties are in 16.16 fixed point
|
|
atomic_add(atom, id, props->src_x, 0);
|
|
atomic_add(atom, id, props->src_y, 0);
|
|
atomic_add(atom, id, props->src_w, (uint64_t)plane->surf.width << 16);
|
|
atomic_add(atom, id, props->src_h, (uint64_t)plane->surf.height << 16);
|
|
atomic_add(atom, id, props->crtc_w, plane->surf.width);
|
|
atomic_add(atom, id, props->crtc_h, plane->surf.height);
|
|
atomic_add(atom, id, props->fb_id, fb_id);
|
|
atomic_add(atom, id, props->crtc_id, crtc_id);
|
|
if (set_crtc_xy) {
|
|
atomic_add(atom, id, props->crtc_x, 0);
|
|
atomic_add(atom, id, props->crtc_y, 0);
|
|
}
|
|
}
|
|
|
|
static bool atomic_crtc_pageflip(struct wlr_drm_backend *drm,
|
|
struct wlr_drm_connector *conn,
|
|
struct wlr_drm_crtc *crtc,
|
|
uint32_t fb_id, drmModeModeInfo *mode) {
|
|
if (mode != NULL) {
|
|
if (crtc->mode_id != 0) {
|
|
drmModeDestroyPropertyBlob(drm->fd, crtc->mode_id);
|
|
}
|
|
|
|
if (drmModeCreatePropertyBlob(drm->fd, mode, sizeof(*mode), &crtc->mode_id)) {
|
|
wlr_log_errno(L_ERROR, "Unable to create property blob");
|
|
return false;
|
|
}
|
|
}
|
|
|
|
uint32_t flags = DRM_MODE_PAGE_FLIP_EVENT;
|
|
if (mode != NULL) {
|
|
flags |= DRM_MODE_ATOMIC_ALLOW_MODESET;
|
|
} else {
|
|
flags |= DRM_MODE_ATOMIC_NONBLOCK;
|
|
}
|
|
|
|
struct atomic atom;
|
|
atomic_begin(crtc, &atom);
|
|
atomic_add(&atom, conn->id, conn->props.crtc_id, crtc->id);
|
|
atomic_add(&atom, crtc->id, crtc->props.mode_id, crtc->mode_id);
|
|
atomic_add(&atom, crtc->id, crtc->props.active, 1);
|
|
set_plane_props(&atom, crtc->primary, crtc->id, fb_id, true);
|
|
return atomic_commit(drm->fd, &atom, conn, flags, mode);
|
|
}
|
|
|
|
static bool atomic_conn_enable(struct wlr_drm_backend *drm,
|
|
struct wlr_drm_connector *conn, bool enable) {
|
|
struct wlr_drm_crtc *crtc = conn->crtc;
|
|
|
|
struct atomic atom;
|
|
atomic_begin(crtc, &atom);
|
|
atomic_add(&atom, crtc->id, crtc->props.active, enable);
|
|
if (enable) {
|
|
atomic_add(&atom, conn->id, conn->props.crtc_id, crtc->id);
|
|
atomic_add(&atom, crtc->id, crtc->props.mode_id, crtc->mode_id);
|
|
} else {
|
|
atomic_add(&atom, conn->id, conn->props.crtc_id, 0);
|
|
atomic_add(&atom, crtc->id, crtc->props.mode_id, 0);
|
|
}
|
|
return atomic_commit(drm->fd, &atom, conn, DRM_MODE_ATOMIC_ALLOW_MODESET,
|
|
true);
|
|
}
|
|
|
|
bool legacy_crtc_set_cursor(struct wlr_drm_backend *drm,
|
|
struct wlr_drm_crtc *crtc, struct gbm_bo *bo);
|
|
|
|
static bool atomic_crtc_set_cursor(struct wlr_drm_backend *drm,
|
|
struct wlr_drm_crtc *crtc, struct gbm_bo *bo) {
|
|
if (!crtc || !crtc->cursor) {
|
|
return true;
|
|
}
|
|
|
|
struct wlr_drm_plane *plane = crtc->cursor;
|
|
// We can't use atomic operations on fake planes
|
|
if (plane->id == 0) {
|
|
return legacy_crtc_set_cursor(drm, crtc, bo);
|
|
}
|
|
|
|
struct atomic atom;
|
|
|
|
atomic_begin(crtc, &atom);
|
|
|
|
if (bo) {
|
|
set_plane_props(&atom, plane, crtc->id, get_fb_for_bo(bo), false);
|
|
} else {
|
|
atomic_add(&atom, plane->id, plane->props.fb_id, 0);
|
|
atomic_add(&atom, plane->id, plane->props.crtc_id, 0);
|
|
}
|
|
|
|
return atomic_end(drm->fd, &atom);
|
|
}
|
|
|
|
bool legacy_crtc_move_cursor(struct wlr_drm_backend *drm,
|
|
struct wlr_drm_crtc *crtc, int x, int y);
|
|
|
|
static bool atomic_crtc_move_cursor(struct wlr_drm_backend *drm,
|
|
struct wlr_drm_crtc *crtc, int x, int y) {
|
|
if (!crtc || !crtc->cursor) {
|
|
return true;
|
|
}
|
|
|
|
struct wlr_drm_plane *plane = crtc->cursor;
|
|
// We can't use atomic operations on fake planes
|
|
if (plane->id == 0) {
|
|
return legacy_crtc_move_cursor(drm, crtc, x, y);
|
|
}
|
|
|
|
struct atomic atom;
|
|
|
|
atomic_begin(crtc, &atom);
|
|
atomic_add(&atom, plane->id, plane->props.crtc_x, x);
|
|
atomic_add(&atom, plane->id, plane->props.crtc_y, y);
|
|
return atomic_end(drm->fd, &atom);
|
|
}
|
|
|
|
static bool atomic_crtc_set_gamma(struct wlr_drm_backend *drm,
|
|
struct wlr_drm_crtc *crtc, uint16_t *r, uint16_t *g, uint16_t *b,
|
|
uint32_t size) {
|
|
struct drm_color_lut gamma[size];
|
|
|
|
// Fallback to legacy gamma interface when gamma properties are not available
|
|
// (can happen on older intel gpu's that support gamma but not degamma)
|
|
if (crtc->props.gamma_lut == 0) {
|
|
return legacy_iface.crtc_set_gamma(drm, crtc, r, g, b, size);
|
|
}
|
|
|
|
for (uint32_t i = 0; i < size; i++) {
|
|
gamma[i].red = r[i];
|
|
gamma[i].green = g[i];
|
|
gamma[i].blue = b[i];
|
|
}
|
|
|
|
if (crtc->gamma_lut != 0) {
|
|
drmModeDestroyPropertyBlob(drm->fd, crtc->gamma_lut);
|
|
}
|
|
|
|
if (drmModeCreatePropertyBlob(drm->fd, gamma,
|
|
sizeof(struct drm_color_lut) * size, &crtc->gamma_lut)) {
|
|
wlr_log_errno(L_ERROR, "Unable to create property blob");
|
|
return false;
|
|
}
|
|
|
|
struct atomic atom;
|
|
atomic_begin(crtc, &atom);
|
|
atomic_add(&atom, crtc->id, crtc->props.gamma_lut, crtc->gamma_lut);
|
|
return atomic_end(drm->fd, &atom);
|
|
}
|
|
|
|
static uint32_t atomic_crtc_get_gamma_size(struct wlr_drm_backend *drm,
|
|
struct wlr_drm_crtc *crtc) {
|
|
uint64_t gamma_lut_size;
|
|
|
|
if (crtc->props.gamma_lut_size == 0) {
|
|
return legacy_iface.crtc_get_gamma_size(drm, crtc);
|
|
}
|
|
|
|
if (!get_drm_prop(drm->fd, crtc->id, crtc->props.gamma_lut_size,
|
|
&gamma_lut_size)) {
|
|
wlr_log(L_ERROR, "Unable to get gamma lut size");
|
|
return 0;
|
|
}
|
|
|
|
return (uint32_t)gamma_lut_size;
|
|
}
|
|
|
|
const struct wlr_drm_interface atomic_iface = {
|
|
.conn_enable = atomic_conn_enable,
|
|
.crtc_pageflip = atomic_crtc_pageflip,
|
|
.crtc_set_cursor = atomic_crtc_set_cursor,
|
|
.crtc_move_cursor = atomic_crtc_move_cursor,
|
|
.crtc_set_gamma = atomic_crtc_set_gamma,
|
|
.crtc_get_gamma_size = atomic_crtc_get_gamma_size,
|
|
};
|