mirror of
https://github.com/hyprwm/wlroots-hyprland.git
synced 2024-11-30 00:15:58 +01:00
324eeaa0cd
When the user switches away from the VT where wlroots is running,
the new DRM master may mutate the KMS state in an arbitrary manner.
For instance, let's say wlroots uses the following connector/CRTC
mapping:
- CRTC 42 drives connector DP-1
- CRTC 43 drives connector DP-2
Then the new DRM master may swap the mapping like so:
- CRTC 42 drives connector DP-2
- CRTC 43 drives connector DP-1
wlroots needs to restore its own state when the user switches back.
Some state is attached to wlr_drm_crtc (e.g. current FB), so reading
back and adopting the CRTC/connector mapping left by the previous DRM
master would be complicated (this was the source of other bugs in the
past, see [1]).
With the previous logic, wlroots merely tries to restore the state
of each connector one after the other. This fails in the scenario
described above: the kernel refuses to use CRTC 42 for DP-1, because
that CRTC is already in-use for DP-2.
Unfortunately with the legacy uAPI it's not possible to restore the
state in one go. We need to support both legacy and atomic uAPIs, so
let's fix the bug for the legacy uAPI first, and then improve the
situation for the atomic uAPI as a second step [2].
We need to disable the CRTCs we're going to switch the connectors for.
This sounds complicated, so let's just disable all CRTCs to simplify.
This causes a black screen because of the on/off modesets, but makes
VT switch much more reliable, so I'll take it.
[1]: c6d8a11d2c
[2]: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3794
Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3342
307 lines
8.9 KiB
C
307 lines
8.9 KiB
C
#include <assert.h>
|
|
#include <errno.h>
|
|
#include <drm_fourcc.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
#include <wayland-server-core.h>
|
|
#include <wlr/backend/interface.h>
|
|
#include <wlr/backend/session.h>
|
|
#include <wlr/interfaces/wlr_output.h>
|
|
#include <wlr/util/log.h>
|
|
#include <xf86drm.h>
|
|
#include "backend/drm/drm.h"
|
|
|
|
struct wlr_drm_backend *get_drm_backend_from_backend(
|
|
struct wlr_backend *wlr_backend) {
|
|
assert(wlr_backend_is_drm(wlr_backend));
|
|
return (struct wlr_drm_backend *)wlr_backend;
|
|
}
|
|
|
|
static bool backend_start(struct wlr_backend *backend) {
|
|
struct wlr_drm_backend *drm = get_drm_backend_from_backend(backend);
|
|
scan_drm_connectors(drm, NULL);
|
|
return true;
|
|
}
|
|
|
|
static void backend_destroy(struct wlr_backend *backend) {
|
|
if (!backend) {
|
|
return;
|
|
}
|
|
|
|
struct wlr_drm_backend *drm = get_drm_backend_from_backend(backend);
|
|
|
|
struct wlr_drm_connector *conn, *next;
|
|
wl_list_for_each_safe(conn, next, &drm->connectors, link) {
|
|
destroy_drm_connector(conn);
|
|
}
|
|
|
|
wlr_backend_finish(backend);
|
|
|
|
struct wlr_drm_fb *fb, *fb_tmp;
|
|
wl_list_for_each_safe(fb, fb_tmp, &drm->fbs, link) {
|
|
drm_fb_destroy(fb);
|
|
}
|
|
|
|
wl_list_remove(&drm->display_destroy.link);
|
|
wl_list_remove(&drm->session_destroy.link);
|
|
wl_list_remove(&drm->session_active.link);
|
|
wl_list_remove(&drm->parent_destroy.link);
|
|
wl_list_remove(&drm->dev_change.link);
|
|
wl_list_remove(&drm->dev_remove.link);
|
|
|
|
if (drm->parent) {
|
|
finish_drm_renderer(&drm->mgpu_renderer);
|
|
}
|
|
|
|
finish_drm_resources(drm);
|
|
|
|
free(drm->name);
|
|
wlr_session_close_file(drm->session, drm->dev);
|
|
wl_event_source_remove(drm->drm_event);
|
|
free(drm);
|
|
}
|
|
|
|
static clockid_t backend_get_presentation_clock(struct wlr_backend *backend) {
|
|
struct wlr_drm_backend *drm = get_drm_backend_from_backend(backend);
|
|
return drm->clock;
|
|
}
|
|
|
|
static int backend_get_drm_fd(struct wlr_backend *backend) {
|
|
struct wlr_drm_backend *drm = get_drm_backend_from_backend(backend);
|
|
|
|
if (drm->parent) {
|
|
return drm->parent->fd;
|
|
} else {
|
|
return drm->fd;
|
|
}
|
|
}
|
|
|
|
static uint32_t drm_backend_get_buffer_caps(struct wlr_backend *backend) {
|
|
return WLR_BUFFER_CAP_DMABUF;
|
|
}
|
|
|
|
static const struct wlr_backend_impl backend_impl = {
|
|
.start = backend_start,
|
|
.destroy = backend_destroy,
|
|
.get_presentation_clock = backend_get_presentation_clock,
|
|
.get_drm_fd = backend_get_drm_fd,
|
|
.get_buffer_caps = drm_backend_get_buffer_caps,
|
|
};
|
|
|
|
bool wlr_backend_is_drm(struct wlr_backend *b) {
|
|
return b->impl == &backend_impl;
|
|
}
|
|
|
|
static void handle_session_active(struct wl_listener *listener, void *data) {
|
|
struct wlr_drm_backend *drm =
|
|
wl_container_of(listener, drm, session_active);
|
|
struct wlr_session *session = drm->session;
|
|
|
|
if (session->active) {
|
|
wlr_log(WLR_INFO, "DRM fd resumed");
|
|
scan_drm_connectors(drm, NULL);
|
|
|
|
// The previous DRM master leaves KMS in an undefined state. We need
|
|
// to restore out own state, but be careful to avoid invalid
|
|
// configurations. The connector/CRTC mapping may have changed, so
|
|
// first disable all CRTCs, then light up the ones we were using
|
|
// before the VT switch.
|
|
// TODO: use the atomic API to improve restoration after a VT switch
|
|
for (size_t i = 0; i < drm->num_crtcs; i++) {
|
|
struct wlr_drm_crtc *crtc = &drm->crtcs[i];
|
|
|
|
if (drmModeSetCrtc(drm->fd, crtc->id, 0, 0, 0, NULL, 0, NULL) != 0) {
|
|
wlr_log_errno(WLR_ERROR, "Failed to disable CRTC %"PRIu32" after VT switch",
|
|
crtc->id);
|
|
}
|
|
}
|
|
|
|
struct wlr_drm_connector *conn;
|
|
wl_list_for_each(conn, &drm->connectors, link) {
|
|
struct wlr_output_mode *mode = NULL;
|
|
uint32_t committed = WLR_OUTPUT_STATE_ENABLED;
|
|
if (conn->status != DRM_MODE_DISCONNECTED && conn->output.enabled
|
|
&& conn->output.current_mode != NULL) {
|
|
committed |= WLR_OUTPUT_STATE_MODE;
|
|
mode = conn->output.current_mode;
|
|
}
|
|
struct wlr_output_state state = {
|
|
.committed = committed,
|
|
.allow_artifacts = true,
|
|
.enabled = mode != NULL,
|
|
.mode_type = WLR_OUTPUT_STATE_MODE_FIXED,
|
|
.mode = mode,
|
|
};
|
|
if (!drm_connector_commit_state(conn, &state)) {
|
|
wlr_drm_conn_log(conn, WLR_ERROR, "Failed to restore state after VT switch");
|
|
}
|
|
}
|
|
} else {
|
|
wlr_log(WLR_INFO, "DRM fd paused");
|
|
}
|
|
}
|
|
|
|
static void handle_dev_change(struct wl_listener *listener, void *data) {
|
|
struct wlr_drm_backend *drm = wl_container_of(listener, drm, dev_change);
|
|
struct wlr_device_change_event *change = data;
|
|
|
|
if (!drm->session->active) {
|
|
return;
|
|
}
|
|
|
|
switch (change->type) {
|
|
case WLR_DEVICE_HOTPLUG:
|
|
wlr_log(WLR_DEBUG, "Received hotplug event for %s", drm->name);
|
|
scan_drm_connectors(drm, &change->hotplug);
|
|
break;
|
|
case WLR_DEVICE_LEASE:
|
|
wlr_log(WLR_DEBUG, "Received lease event for %s", drm->name);
|
|
scan_drm_leases(drm);
|
|
break;
|
|
default:
|
|
wlr_log(WLR_DEBUG, "Received unknown change event for %s", drm->name);
|
|
}
|
|
}
|
|
|
|
static void handle_dev_remove(struct wl_listener *listener, void *data) {
|
|
struct wlr_drm_backend *drm = wl_container_of(listener, drm, dev_remove);
|
|
|
|
wlr_log(WLR_INFO, "Destroying DRM backend for %s", drm->name);
|
|
backend_destroy(&drm->backend);
|
|
}
|
|
|
|
static void handle_session_destroy(struct wl_listener *listener, void *data) {
|
|
struct wlr_drm_backend *drm =
|
|
wl_container_of(listener, drm, session_destroy);
|
|
backend_destroy(&drm->backend);
|
|
}
|
|
|
|
static void handle_display_destroy(struct wl_listener *listener, void *data) {
|
|
struct wlr_drm_backend *drm =
|
|
wl_container_of(listener, drm, display_destroy);
|
|
backend_destroy(&drm->backend);
|
|
}
|
|
|
|
static void handle_parent_destroy(struct wl_listener *listener, void *data) {
|
|
struct wlr_drm_backend *drm =
|
|
wl_container_of(listener, drm, parent_destroy);
|
|
backend_destroy(&drm->backend);
|
|
}
|
|
|
|
struct wlr_backend *wlr_drm_backend_create(struct wl_display *display,
|
|
struct wlr_session *session, struct wlr_device *dev,
|
|
struct wlr_backend *parent) {
|
|
assert(display && session && dev);
|
|
assert(!parent || wlr_backend_is_drm(parent));
|
|
|
|
char *name = drmGetDeviceNameFromFd2(dev->fd);
|
|
drmVersion *version = drmGetVersion(dev->fd);
|
|
wlr_log(WLR_INFO, "Initializing DRM backend for %s (%s)", name, version->name);
|
|
drmFreeVersion(version);
|
|
|
|
struct wlr_drm_backend *drm = calloc(1, sizeof(struct wlr_drm_backend));
|
|
if (!drm) {
|
|
wlr_log_errno(WLR_ERROR, "Allocation failed");
|
|
return NULL;
|
|
}
|
|
wlr_backend_init(&drm->backend, &backend_impl);
|
|
|
|
drm->session = session;
|
|
wl_list_init(&drm->fbs);
|
|
wl_list_init(&drm->connectors);
|
|
|
|
drm->dev = dev;
|
|
drm->fd = dev->fd;
|
|
drm->name = name;
|
|
|
|
if (parent != NULL) {
|
|
drm->parent = get_drm_backend_from_backend(parent);
|
|
|
|
drm->parent_destroy.notify = handle_parent_destroy;
|
|
wl_signal_add(&parent->events.destroy, &drm->parent_destroy);
|
|
} else {
|
|
wl_list_init(&drm->parent_destroy.link);
|
|
}
|
|
|
|
drm->dev_change.notify = handle_dev_change;
|
|
wl_signal_add(&dev->events.change, &drm->dev_change);
|
|
|
|
drm->dev_remove.notify = handle_dev_remove;
|
|
wl_signal_add(&dev->events.remove, &drm->dev_remove);
|
|
|
|
drm->display = display;
|
|
|
|
struct wl_event_loop *event_loop = wl_display_get_event_loop(display);
|
|
drm->drm_event = wl_event_loop_add_fd(event_loop, drm->fd,
|
|
WL_EVENT_READABLE, handle_drm_event, drm);
|
|
if (!drm->drm_event) {
|
|
wlr_log(WLR_ERROR, "Failed to create DRM event source");
|
|
goto error_fd;
|
|
}
|
|
|
|
drm->session_active.notify = handle_session_active;
|
|
wl_signal_add(&session->events.active, &drm->session_active);
|
|
|
|
if (!check_drm_features(drm)) {
|
|
goto error_event;
|
|
}
|
|
|
|
if (!init_drm_resources(drm)) {
|
|
goto error_event;
|
|
}
|
|
|
|
if (drm->parent) {
|
|
if (!init_drm_renderer(drm, &drm->mgpu_renderer)) {
|
|
wlr_log(WLR_ERROR, "Failed to initialize renderer");
|
|
goto error_resources;
|
|
}
|
|
|
|
// We'll perform a multi-GPU copy for all submitted buffers, we need
|
|
// to be able to texture from them
|
|
struct wlr_renderer *renderer = drm->mgpu_renderer.wlr_rend;
|
|
const struct wlr_drm_format_set *texture_formats =
|
|
wlr_renderer_get_dmabuf_texture_formats(renderer);
|
|
if (texture_formats == NULL) {
|
|
wlr_log(WLR_ERROR, "Failed to query renderer texture formats");
|
|
goto error_mgpu_renderer;
|
|
}
|
|
|
|
// Forbid implicit modifiers, because their meaning changes from one
|
|
// GPU to another.
|
|
for (size_t i = 0; i < texture_formats->len; i++) {
|
|
const struct wlr_drm_format *fmt = texture_formats->formats[i];
|
|
for (size_t j = 0; j < fmt->len; j++) {
|
|
uint64_t mod = fmt->modifiers[j];
|
|
if (mod == DRM_FORMAT_MOD_INVALID) {
|
|
continue;
|
|
}
|
|
wlr_drm_format_set_add(&drm->mgpu_formats, fmt->format, mod);
|
|
}
|
|
}
|
|
}
|
|
|
|
drm->session_destroy.notify = handle_session_destroy;
|
|
wl_signal_add(&session->events.destroy, &drm->session_destroy);
|
|
|
|
drm->display_destroy.notify = handle_display_destroy;
|
|
wl_display_add_destroy_listener(display, &drm->display_destroy);
|
|
|
|
return &drm->backend;
|
|
|
|
error_mgpu_renderer:
|
|
finish_drm_renderer(&drm->mgpu_renderer);
|
|
error_resources:
|
|
finish_drm_resources(drm);
|
|
error_event:
|
|
wl_list_remove(&drm->session_active.link);
|
|
wl_event_source_remove(drm->drm_event);
|
|
error_fd:
|
|
wl_list_remove(&drm->dev_remove.link);
|
|
wl_list_remove(&drm->dev_change.link);
|
|
wl_list_remove(&drm->parent_destroy.link);
|
|
wlr_session_close_file(drm->session, dev);
|
|
free(drm);
|
|
return NULL;
|
|
}
|