mirror of
https://github.com/hyprwm/wlroots-hyprland.git
synced 2024-11-05 21:15:59 +01:00
bf86110fc5
When gbm_bo_create is used and the GBM implementation does support modifiers, gbm_bo_get_modifier may return something other than DRM_FORMAT_MOD_INVALID. This can cause issues with the rest of the stack (e.g. EGL or KMS) in case these don't support modifiers. Instead, force the modifier to INVALID, to make sure no one uses modifiers.
204 lines
5.6 KiB
C
204 lines
5.6 KiB
C
#define _POSIX_C_SOURCE 200809L
|
|
#include <assert.h>
|
|
#include <drm_fourcc.h>
|
|
#include <fcntl.h>
|
|
#include <stdlib.h>
|
|
#include <unistd.h>
|
|
#include <wlr/util/log.h>
|
|
#include <xf86drm.h>
|
|
#include "render/gbm_allocator.h"
|
|
|
|
static const struct wlr_buffer_impl buffer_impl;
|
|
|
|
static struct wlr_gbm_buffer *get_gbm_buffer_from_buffer(
|
|
struct wlr_buffer *buffer) {
|
|
assert(buffer->impl == &buffer_impl);
|
|
return (struct wlr_gbm_buffer *)buffer;
|
|
}
|
|
|
|
static bool export_gbm_bo(struct gbm_bo *bo,
|
|
struct wlr_dmabuf_attributes *out) {
|
|
struct wlr_dmabuf_attributes attribs = {0};
|
|
|
|
attribs.n_planes = gbm_bo_get_plane_count(bo);
|
|
if (attribs.n_planes > WLR_DMABUF_MAX_PLANES) {
|
|
wlr_log(WLR_ERROR, "GBM BO contains too many planes (%d)",
|
|
attribs.n_planes);
|
|
return false;
|
|
}
|
|
|
|
attribs.width = gbm_bo_get_width(bo);
|
|
attribs.height = gbm_bo_get_height(bo);
|
|
attribs.format = gbm_bo_get_format(bo);
|
|
attribs.modifier = gbm_bo_get_modifier(bo);
|
|
|
|
int i;
|
|
for (i = 0; i < attribs.n_planes; ++i) {
|
|
union gbm_bo_handle handle = gbm_bo_get_handle_for_plane(bo, i);
|
|
if (handle.s32 < 0) {
|
|
wlr_log(WLR_ERROR, "gbm_bo_get_handle_for_plane failed");
|
|
goto error_fd;
|
|
}
|
|
|
|
int drm_fd = gbm_device_get_fd(gbm_bo_get_device(bo));
|
|
int ret = drmPrimeHandleToFD(drm_fd, handle.s32,
|
|
DRM_CLOEXEC, &attribs.fd[i]);
|
|
if (ret < 0 || attribs.fd[i] < 0) {
|
|
wlr_log_errno(WLR_ERROR, "drmPrimeHandleToFD failed");
|
|
goto error_fd;
|
|
}
|
|
|
|
attribs.offset[i] = gbm_bo_get_offset(bo, i);
|
|
attribs.stride[i] = gbm_bo_get_stride_for_plane(bo, i);
|
|
}
|
|
|
|
memcpy(out, &attribs, sizeof(attribs));
|
|
return true;
|
|
|
|
error_fd:
|
|
for (int j = 0; j < i; ++j) {
|
|
close(attribs.fd[j]);
|
|
}
|
|
return false;
|
|
}
|
|
|
|
static struct wlr_gbm_buffer *create_buffer(struct wlr_gbm_allocator *alloc,
|
|
int width, int height, const struct wlr_drm_format *format) {
|
|
struct gbm_device *gbm_device = alloc->gbm_device;
|
|
|
|
struct gbm_bo *bo = NULL;
|
|
bool has_modifier = true;
|
|
if (format->len > 0) {
|
|
bo = gbm_bo_create_with_modifiers(gbm_device, width, height,
|
|
format->format, format->modifiers, format->len);
|
|
}
|
|
if (bo == NULL) {
|
|
uint32_t usage = GBM_BO_USE_SCANOUT | GBM_BO_USE_RENDERING;
|
|
if (format->len == 1 &&
|
|
format->modifiers[0] == DRM_FORMAT_MOD_LINEAR) {
|
|
usage |= GBM_BO_USE_LINEAR;
|
|
}
|
|
bo = gbm_bo_create(gbm_device, width, height, format->format, usage);
|
|
has_modifier = false;
|
|
}
|
|
if (bo == NULL) {
|
|
wlr_log(WLR_ERROR, "gbm_bo_create failed");
|
|
return NULL;
|
|
}
|
|
|
|
struct wlr_gbm_buffer *buffer = calloc(1, sizeof(*buffer));
|
|
if (buffer == NULL) {
|
|
gbm_bo_destroy(bo);
|
|
return NULL;
|
|
}
|
|
wlr_buffer_init(&buffer->base, &buffer_impl, width, height);
|
|
buffer->gbm_bo = bo;
|
|
wl_list_insert(&alloc->buffers, &buffer->link);
|
|
|
|
if (!export_gbm_bo(bo, &buffer->dmabuf)) {
|
|
free(buffer);
|
|
gbm_bo_destroy(bo);
|
|
return NULL;
|
|
}
|
|
|
|
// If the buffer has been allocated with an implicit modifier, make sure we
|
|
// don't populate the modifier field: other parts of the stack may not
|
|
// understand modifiers, and they can't strip the modifier.
|
|
if (!has_modifier) {
|
|
buffer->dmabuf.modifier = DRM_FORMAT_MOD_INVALID;
|
|
}
|
|
|
|
wlr_log(WLR_DEBUG, "Allocated %dx%d GBM buffer (format 0x%"PRIX32", "
|
|
"modifier 0x%"PRIX64")", buffer->base.width, buffer->base.height,
|
|
buffer->dmabuf.format, buffer->dmabuf.modifier);
|
|
|
|
return buffer;
|
|
}
|
|
|
|
static void buffer_destroy(struct wlr_buffer *wlr_buffer) {
|
|
struct wlr_gbm_buffer *buffer =
|
|
get_gbm_buffer_from_buffer(wlr_buffer);
|
|
wlr_dmabuf_attributes_finish(&buffer->dmabuf);
|
|
if (buffer->gbm_bo != NULL) {
|
|
gbm_bo_destroy(buffer->gbm_bo);
|
|
}
|
|
wl_list_remove(&buffer->link);
|
|
free(buffer);
|
|
}
|
|
|
|
static bool buffer_get_dmabuf(struct wlr_buffer *wlr_buffer,
|
|
struct wlr_dmabuf_attributes *attribs) {
|
|
struct wlr_gbm_buffer *buffer =
|
|
get_gbm_buffer_from_buffer(wlr_buffer);
|
|
memcpy(attribs, &buffer->dmabuf, sizeof(buffer->dmabuf));
|
|
return true;
|
|
}
|
|
|
|
static const struct wlr_buffer_impl buffer_impl = {
|
|
.destroy = buffer_destroy,
|
|
.get_dmabuf = buffer_get_dmabuf,
|
|
};
|
|
|
|
static const struct wlr_allocator_interface allocator_impl;
|
|
|
|
static struct wlr_gbm_allocator *get_gbm_alloc_from_alloc(
|
|
struct wlr_allocator *alloc) {
|
|
assert(alloc->impl == &allocator_impl);
|
|
return (struct wlr_gbm_allocator *)alloc;
|
|
}
|
|
|
|
struct wlr_gbm_allocator *wlr_gbm_allocator_create(int fd) {
|
|
struct wlr_gbm_allocator *alloc = calloc(1, sizeof(*alloc));
|
|
if (alloc == NULL) {
|
|
return NULL;
|
|
}
|
|
wlr_allocator_init(&alloc->base, &allocator_impl);
|
|
|
|
alloc->fd = fd;
|
|
wl_list_init(&alloc->buffers);
|
|
|
|
alloc->gbm_device = gbm_create_device(fd);
|
|
if (alloc->gbm_device == NULL) {
|
|
wlr_log(WLR_ERROR, "gbm_create_device failed");
|
|
free(alloc);
|
|
return NULL;
|
|
}
|
|
|
|
wlr_log(WLR_DEBUG, "Created GBM allocator with backend %s",
|
|
gbm_device_get_backend_name(alloc->gbm_device));
|
|
|
|
return alloc;
|
|
}
|
|
|
|
static void allocator_destroy(struct wlr_allocator *wlr_alloc) {
|
|
struct wlr_gbm_allocator *alloc = get_gbm_alloc_from_alloc(wlr_alloc);
|
|
|
|
// The gbm_bo objects need to be destroyed before the gbm_device
|
|
struct wlr_gbm_buffer *buf, *buf_tmp;
|
|
wl_list_for_each_safe(buf, buf_tmp, &alloc->buffers, link) {
|
|
gbm_bo_destroy(buf->gbm_bo);
|
|
buf->gbm_bo = NULL;
|
|
wl_list_remove(&buf->link);
|
|
wl_list_init(&buf->link);
|
|
}
|
|
|
|
gbm_device_destroy(alloc->gbm_device);
|
|
close(alloc->fd);
|
|
free(alloc);
|
|
}
|
|
|
|
static struct wlr_buffer *allocator_create_buffer(
|
|
struct wlr_allocator *wlr_alloc, int width, int height,
|
|
const struct wlr_drm_format *format) {
|
|
struct wlr_gbm_allocator *alloc = get_gbm_alloc_from_alloc(wlr_alloc);
|
|
struct wlr_gbm_buffer *buffer = create_buffer(alloc, width, height, format);
|
|
if (buffer == NULL) {
|
|
return NULL;
|
|
}
|
|
return &buffer->base;
|
|
}
|
|
|
|
static const struct wlr_allocator_interface allocator_impl = {
|
|
.destroy = allocator_destroy,
|
|
.create_buffer = allocator_create_buffer,
|
|
};
|