wlroots-hyprland/backend
Simon Ser 98a83ce14c backend/drm: fix EINVAL atomic commits after VT switch
The drm_connector_commit_state() call in handle_session_active()
was not resulting in any atomic commit, because it didn't match any
of the if branches: active = true, no new buffer was committed,
and adaptive sync/gamma LUT were unchanged. Thus the commit was a
no-op.

Later on, when the compositor performs regular page-flips, the
kernel would return EINVAL indicating that a modeset was needed.

Rework the logic to use a non-blocking page-flip commit if a buffer
was committed, and use a blocking commit if the connector is on or
is being disabled. The only case where we should skip the atomic
commit is when disabling (active = false) an already-disabled
connector (conn->crtc == NULL).

Note, 6936e163b5 ("backend/drm: short-circuit no-op commits")
has introduced early returns for other situations where we don't
need to perform an atomic commit (e.g. updating scale or transform
of an output).

Fixes: f216e97983 ("backend/drm: drop drm_connector_set_mode()")
Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3432
2022-10-17 15:14:02 +00:00
..
drm backend/drm: fix EINVAL atomic commits after VT switch 2022-10-17 15:14:02 +00:00
headless backend: use global output name counters 2022-10-13 13:12:43 +02:00
libinput backend/libinput: Fix SIGSEGV found in low-memory fuzzing 2022-09-22 13:37:32 -04:00
multi Use wl_signal_emit_mutable 2022-08-18 07:16:16 -04:00
session Use wl_signal_emit_mutable 2022-08-18 07:16:16 -04:00
wayland backend: use global output name counters 2022-10-13 13:12:43 +02:00
x11 backend: use global output name counters 2022-10-13 13:12:43 +02:00
backend.c Use env helpers 2022-08-22 10:18:52 -04:00
meson.build backend: remove noop backend 2021-11-25 16:49:05 +00:00