From 45699637d1c71842372323d39deb9f9a43a0fd7e Mon Sep 17 00:00:00 2001 From: Dan Shick Date: Fri, 13 Mar 2020 12:43:24 -0400 Subject: [PATCH] Fix CI with libpipewire02, libdrm. Remove png.h unused import. Cleanup style. --- .build.yml | 3 +- .gitignore | 2 +- include/logger.h | 17 +- include/screencast_common.h | 4 +- include/wlr_screencast.h | 6 +- meson.build | 1 - protocols/meson.build | 2 +- protocols/wlr-screencopy-unstable-v1.xml | 346 +++++++++++------------ protocols/xdg-output-unstable-v1.xml | 216 +++++++------- src/core/logger.c | 32 +-- src/core/main.c | 23 +- src/screencast/pipewire_screencast.c | 101 ++++--- src/screencast/screencast.c | 71 +++-- src/screencast/screencast_common.c | 54 ++-- src/screencast/wlr_screencast.c | 116 ++++---- 15 files changed, 480 insertions(+), 514 deletions(-) diff --git a/.build.yml b/.build.yml index 5e8bff3..482756f 100644 --- a/.build.yml +++ b/.build.yml @@ -5,7 +5,8 @@ packages: - meson - wayland - wayland-protocols - - pipewire + - libpipewire02 + - libdrm sources: - https://github.com/emersion/xdg-desktop-portal-wlr tasks: diff --git a/.gitignore b/.gitignore index 54f6d86..fc62187 100644 --- a/.gitignore +++ b/.gitignore @@ -53,4 +53,4 @@ dkms.conf # build folder build/ -build-*/ \ No newline at end of file +build-*/ diff --git a/include/logger.h b/include/logger.h index 241a778..3b6c17d 100644 --- a/include/logger.h +++ b/include/logger.h @@ -1,27 +1,20 @@ #ifndef LOGGER_H #define LOGGER_H +#include #include #include -#include #include #include -enum LOGLEVEL { - QUIET, - ERROR, - WARN, - INFO, - DEBUG, - TRACE -}; +enum LOGLEVEL { QUIET, ERROR, WARN, INFO, DEBUG, TRACE }; -struct logger_properties{ +struct logger_properties { enum LOGLEVEL level; - FILE *__restrict__ dst; + FILE *dst; }; -void init_logger(FILE *__restrict__ dst, enum LOGLEVEL level); +void init_logger(FILE *dst, enum LOGLEVEL level); enum LOGLEVEL get_loglevel(const char *level); void logprint(enum LOGLEVEL level, char *msg, ...); diff --git a/include/screencast_common.h b/include/screencast_common.h index ca4e94b..ad099eb 100644 --- a/include/screencast_common.h +++ b/include/screencast_common.h @@ -1,6 +1,7 @@ #ifndef SCREENCAST_COMMON_H #define SCREENCAST_COMMON_H +#include #include #include #include @@ -24,7 +25,6 @@ struct simple_frame { uint32_t tv_nsec; enum wl_shm_format format; struct damage *damage; - struct wl_buffer *buffer; void *data; }; @@ -38,7 +38,6 @@ struct pwr_type { }; struct screencast_context { - // pipewire struct pwr_type type; struct pw_loop *loop; @@ -97,6 +96,5 @@ struct wayland_output { }; uint32_t pipewire_from_wl_shm(void *data); -char *strdup(const char *src); #endif /* SCREENCAST_COMMON_H */ diff --git a/include/wlr_screencast.h b/include/wlr_screencast.h index b5ab873..c80ea66 100644 --- a/include/wlr_screencast.h +++ b/include/wlr_screencast.h @@ -5,7 +5,6 @@ #include "xdg-output-unstable-v1-client-protocol.h" #include #include -#include #include #include #include @@ -27,9 +26,10 @@ void wlr_frame_free(struct xdpw_state *state); int wlr_screencopy_init(struct xdpw_state *state); void wlr_screencopy_uninit(struct screencast_context *ctx); -struct wayland_output *wlr_output_find_by_name(struct wl_list *output_list, const char* name); +struct wayland_output *wlr_output_find_by_name(struct wl_list *output_list, + const char *name); struct wayland_output *wlr_output_find(struct screencast_context *ctx, - struct wl_output *out, uint32_t id); + struct wl_output *out, uint32_t id); struct wayland_output *wlr_output_first(struct wl_list *output_list); void wlr_register_cb(struct xdpw_state *state); diff --git a/meson.build b/meson.build index e46e472..0b3a4d6 100644 --- a/meson.build +++ b/meson.build @@ -8,7 +8,6 @@ project( 'c_std=c11', 'warning_level=2', 'werror=true', - 'debug=true', ], ) diff --git a/protocols/meson.build b/protocols/meson.build index be773a9..bdd1c65 100644 --- a/protocols/meson.build +++ b/protocols/meson.build @@ -47,4 +47,4 @@ lib_wl_protos = static_library( wlr_protos = declare_dependency( link_with: lib_wl_protos, sources: wl_protos_headers, -) \ No newline at end of file +) diff --git a/protocols/wlr-screencopy-unstable-v1.xml b/protocols/wlr-screencopy-unstable-v1.xml index e4c21f8..a07cbca 100644 --- a/protocols/wlr-screencopy-unstable-v1.xml +++ b/protocols/wlr-screencopy-unstable-v1.xml @@ -1,207 +1,207 @@ - - Copyright © 2018 Simon Ser - Copyright © 2019 Andri Yngvason + + Copyright © 2018 Simon Ser + Copyright © 2019 Andri Yngvason - Permission is hereby granted, free of charge, to any person obtaining a - copy of this software and associated documentation files (the "Software"), - to deal in the Software without restriction, including without limitation - the rights to use, copy, modify, merge, publish, distribute, sublicense, - and/or sell copies of the Software, and to permit persons to whom the - Software is furnished to do so, subject to the following conditions: + Permission is hereby granted, free of charge, to any person obtaining a + copy of this software and associated documentation files (the "Software"), + to deal in the Software without restriction, including without limitation + the rights to use, copy, modify, merge, publish, distribute, sublicense, + and/or sell copies of the Software, and to permit persons to whom the + Software is furnished to do so, subject to the following conditions: - The above copyright notice and this permission notice (including the next - paragraph) shall be included in all copies or substantial portions of the - Software. + The above copyright notice and this permission notice (including the next + paragraph) shall be included in all copies or substantial portions of the + Software. - THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL - THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - DEALINGS IN THE SOFTWARE. - + THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + DEALINGS IN THE SOFTWARE. + - - This protocol allows clients to ask the compositor to copy part of the - screen content to a client buffer. + + This protocol allows clients to ask the compositor to copy part of the + screen content to a client buffer. - Warning! The protocol described in this file is experimental and - backward incompatible changes may be made. Backward compatible changes - may be added together with the corresponding interface version bump. - Backward incompatible changes are done by bumping the version number in - the protocol and interface names and resetting the interface version. - Once the protocol is to be declared stable, the 'z' prefix and the - version number in the protocol and interface names are removed and the - interface version number is reset. - + Warning! The protocol described in this file is experimental and + backward incompatible changes may be made. Backward compatible changes + may be added together with the corresponding interface version bump. + Backward incompatible changes are done by bumping the version number in + the protocol and interface names and resetting the interface version. + Once the protocol is to be declared stable, the 'z' prefix and the + version number in the protocol and interface names are removed and the + interface version number is reset. + - - - This object is a manager which offers requests to start capturing from a - source. - + + + This object is a manager which offers requests to start capturing from a + source. + - - - Capture the next frame of an entire output. - - - - - + + + Capture the next frame of an entire output. + + + + + - - - Capture the next frame of an output's region. + + + Capture the next frame of an output's region. - The region is given in output logical coordinates, see - xdg_output.logical_size. The region will be clipped to the output's - extents. - - - - - - - - - + The region is given in output logical coordinates, see + xdg_output.logical_size. The region will be clipped to the output's + extents. + + + + + + + + + - - - All objects created by the manager will still remain valid, until their - appropriate destroy request has been called. - - - + + + All objects created by the manager will still remain valid, until their + appropriate destroy request has been called. + + + - - - This object represents a single frame. + + + This object represents a single frame. - When created, a "buffer" event will be sent. The client will then be able - to send a "copy" request. If the capture is successful, the compositor - will send a "flags" followed by a "ready" event. + When created, a "buffer" event will be sent. The client will then be able + to send a "copy" request. If the capture is successful, the compositor + will send a "flags" followed by a "ready" event. - If the capture failed, the "failed" event is sent. This can happen anytime - before the "ready" event. + If the capture failed, the "failed" event is sent. This can happen anytime + before the "ready" event. - Once either a "ready" or a "failed" event is received, the client should - destroy the frame. - + Once either a "ready" or a "failed" event is received, the client should + destroy the frame. + - - - Provides information about the frame's buffer. This event is sent once - as soon as the frame is created. + + + Provides information about the frame's buffer. This event is sent once + as soon as the frame is created. - The client should then create a buffer with the provided attributes, and - send a "copy" request. - - - - - - + The client should then create a buffer with the provided attributes, and + send a "copy" request. + + + + + + - - - Copy the frame to the supplied buffer. The buffer must have a the - correct size, see zwlr_screencopy_frame_v1.buffer. The buffer needs to - have a supported format. + + + Copy the frame to the supplied buffer. The buffer must have a the + correct size, see zwlr_screencopy_frame_v1.buffer. The buffer needs to + have a supported format. - If the frame is successfully copied, a "flags" and a "ready" events are - sent. Otherwise, a "failed" event is sent. - - - + If the frame is successfully copied, a "flags" and a "ready" events are + sent. Otherwise, a "failed" event is sent. + + + - - - - + + + + - - - + + + - - - Provides flags about the frame. This event is sent once before the - "ready" event. - - - + + + Provides flags about the frame. This event is sent once before the + "ready" event. + + + - - - Called as soon as the frame is copied, indicating it is available - for reading. This event includes the time at which presentation happened - at. + + + Called as soon as the frame is copied, indicating it is available + for reading. This event includes the time at which presentation happened + at. - The timestamp is expressed as tv_sec_hi, tv_sec_lo, tv_nsec triples, - each component being an unsigned 32-bit value. Whole seconds are in - tv_sec which is a 64-bit value combined from tv_sec_hi and tv_sec_lo, - and the additional fractional part in tv_nsec as nanoseconds. Hence, - for valid timestamps tv_nsec must be in [0, 999999999]. The seconds part - may have an arbitrary offset at start. + The timestamp is expressed as tv_sec_hi, tv_sec_lo, tv_nsec triples, + each component being an unsigned 32-bit value. Whole seconds are in + tv_sec which is a 64-bit value combined from tv_sec_hi and tv_sec_lo, + and the additional fractional part in tv_nsec as nanoseconds. Hence, + for valid timestamps tv_nsec must be in [0, 999999999]. The seconds part + may have an arbitrary offset at start. - After receiving this event, the client should destroy the object. - - - - - + After receiving this event, the client should destroy the object. + + + + + - - - This event indicates that the attempted frame copy has failed. + + + This event indicates that the attempted frame copy has failed. - After receiving this event, the client should destroy the object. - - + After receiving this event, the client should destroy the object. + + - - - Destroys the frame. This request can be sent at any time by the client. - - + + + Destroys the frame. This request can be sent at any time by the client. + + - - - - Same as copy, except it waits until there is damage to copy. - - - + + + + Same as copy, except it waits until there is damage to copy. + + + - - - This event is sent right before the ready event when copy_with_damage is - requested. It may be generated multiple times for each copy_with_damage - request. + + + This event is sent right before the ready event when copy_with_damage is + requested. It may be generated multiple times for each copy_with_damage + request. - The arguments describe a box around an area that has changed since the - last copy request that was derived from the current screencopy manager - instance. + The arguments describe a box around an area that has changed since the + last copy request that was derived from the current screencopy manager + instance. - The union of all regions received between the call to copy_with_damage - and a ready event is the total damage since the prior ready event. - - - - - - - + The union of all regions received between the call to copy_with_damage + and a ready event is the total damage since the prior ready event. + + + + + + + diff --git a/protocols/xdg-output-unstable-v1.xml b/protocols/xdg-output-unstable-v1.xml index fe3a70a..8cfb714 100644 --- a/protocols/xdg-output-unstable-v1.xml +++ b/protocols/xdg-output-unstable-v1.xml @@ -1,119 +1,119 @@ - - Copyright © 2017 Red Hat Inc. + + Copyright © 2017 Red Hat Inc. - Permission is hereby granted, free of charge, to any person obtaining a - copy of this software and associated documentation files (the "Software"), - to deal in the Software without restriction, including without limitation - the rights to use, copy, modify, merge, publish, distribute, sublicense, - and/or sell copies of the Software, and to permit persons to whom the - Software is furnished to do so, subject to the following conditions: + Permission is hereby granted, free of charge, to any person obtaining a + copy of this software and associated documentation files (the "Software"), + to deal in the Software without restriction, including without limitation + the rights to use, copy, modify, merge, publish, distribute, sublicense, + and/or sell copies of the Software, and to permit persons to whom the + Software is furnished to do so, subject to the following conditions: - The above copyright notice and this permission notice (including the next - paragraph) shall be included in all copies or substantial portions of the - Software. + The above copyright notice and this permission notice (including the next + paragraph) shall be included in all copies or substantial portions of the + Software. - THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL - THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER - DEALINGS IN THE SOFTWARE. - + THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + DEALINGS IN THE SOFTWARE. + - - This protocol aims at describing outputs in a way which is more in line - with the concept of an output on desktop oriented systems. + + This protocol aims at describing outputs in a way which is more in line + with the concept of an output on desktop oriented systems. - Some information are more specific to the concept of an output for - a desktop oriented system and may not make sense in other applications, - such as IVI systems for example. + Some information are more specific to the concept of an output for + a desktop oriented system and may not make sense in other applications, + such as IVI systems for example. - Typically, the global compositor space on a desktop system is made of - a contiguous or overlapping set of rectangular regions. + Typically, the global compositor space on a desktop system is made of + a contiguous or overlapping set of rectangular regions. - Some of the information provided in this protocol might be identical - to their counterparts already available from wl_output, in which case - the information provided by this protocol should be preferred to their - equivalent in wl_output. The goal is to move the desktop specific - concepts (such as output location within the global compositor space, - the connector name and types, etc.) out of the core wl_output protocol. + Some of the information provided in this protocol might be identical + to their counterparts already available from wl_output, in which case + the information provided by this protocol should be preferred to their + equivalent in wl_output. The goal is to move the desktop specific + concepts (such as output location within the global compositor space, + the connector name and types, etc.) out of the core wl_output protocol. - Warning! The protocol described in this file is experimental and - backward incompatible changes may be made. Backward compatible - changes may be added together with the corresponding interface - version bump. - Backward incompatible changes are done by bumping the version - number in the protocol and interface names and resetting the - interface version. Once the protocol is to be declared stable, - the 'z' prefix and the version number in the protocol and - interface names are removed and the interface version number is - reset. - + Warning! The protocol described in this file is experimental and + backward incompatible changes may be made. Backward compatible + changes may be added together with the corresponding interface + version bump. + Backward incompatible changes are done by bumping the version + number in the protocol and interface names and resetting the + interface version. Once the protocol is to be declared stable, + the 'z' prefix and the version number in the protocol and + interface names are removed and the interface version number is + reset. + - - - A global factory interface for xdg_output objects. - + + + A global factory interface for xdg_output objects. + - - + + Using this request a client can tell the server that it is not going to use the xdg_output_manager object anymore. Any objects already created through this instance are not affected. - - + + - - + + This creates a new xdg_output object for the given wl_output. - - - - - + + + + + - - - An xdg_output describes part of the compositor geometry. + + + An xdg_output describes part of the compositor geometry. - This typically corresponds to a monitor that displays part of the - compositor space. + This typically corresponds to a monitor that displays part of the + compositor space. - For objects version 3 onwards, after all xdg_output properties have been - sent (when the object is created and when properties are updated), a - wl_output.done event is sent. This allows changes to the output - properties to be seen as atomic, even if they happen via multiple events. - + For objects version 3 onwards, after all xdg_output properties have been + sent (when the object is created and when properties are updated), a + wl_output.done event is sent. This allows changes to the output + properties to be seen as atomic, even if they happen via multiple events. + - - + + Using this request a client can tell the server that it is not going to use the xdg_output object anymore. - - + + - - + + The position event describes the location of the wl_output within the global compositor space. The logical_position event is sent after creating an xdg_output (see xdg_output_manager.get_xdg_output) and whenever the location of the output changes within the global compositor space. - - - - + + + + - - + + The logical_size event describes the size of the output in the global compositor space. @@ -132,13 +132,13 @@ For example, for a wl_output mode 3840×2160 and a scale factor 2: - A compositor not scaling the surface buffers will advertise a - logical size of 3840×2160, + logical size of 3840×2160, - A compositor automatically scaling the surface buffers will - advertise a logical size of 1920×1080, + advertise a logical size of 1920×1080, - A compositor using a fractional scale of 1.5 will advertise a - logical size to 2560×1620. + logical size to 2560×1620. For example, for a wl_output mode 1920×1080 and a 90 degree rotation, the compositor will advertise a logical size of 1080x1920. @@ -148,15 +148,15 @@ size of the output changes, either as a result of a change in the applied scale or because of a change in the corresponding output mode(see wl_output.mode) or transform (see wl_output.transform). - - - - + + + + - - + + This event is sent after all other properties of an xdg_output have been sent. @@ -166,13 +166,13 @@ For objects version 3 onwards, this event is deprecated. Compositors are not required to send it anymore and must send wl_output.done instead. - - + + - + - - + + Many compositors will assign names to their outputs, show them to the user, allow them to be configured by name, etc. The client may wish to know this name as well to offer the user similar behaviors. @@ -191,12 +191,12 @@ xdg_output_manager.get_xdg_output). This event is only sent once per xdg_output, and the name does not change over the lifetime of the wl_output global. - - - + + + - - + + Many compositors can produce human-readable descriptions of their outputs. The client may wish to know this description as well, to communicate the user for various purposes. @@ -212,9 +212,9 @@ For objects of version 2 and lower, this event is only sent once per xdg_output, and the description does not change over the lifetime of the wl_output global. - - - + + + - + diff --git a/src/core/logger.c b/src/core/logger.c index a169e2c..2f4bdfe 100644 --- a/src/core/logger.c +++ b/src/core/logger.c @@ -13,29 +13,31 @@ static const char *loglevels[] = { static struct logger_properties logprops; -void init_logger(FILE *__restrict__ dst, enum LOGLEVEL level){ +void init_logger(FILE *dst, enum LOGLEVEL level) { logprops.dst = dst; logprops.level = level; } -enum LOGLEVEL get_loglevel(const char *level){ +enum LOGLEVEL get_loglevel(const char *level) { int i; - for(i = 0; i < NUM_LEVELS; i++){ - if(!strcmp(level, loglevels[i])) return (enum LOGLEVEL) i; + for (i = 0; i < NUM_LEVELS; i++) { + if (!strcmp(level, loglevels[i])) { + return (enum LOGLEVEL) i; + } } fprintf(stderr, "Could not understand log level %s\n", level); - exit(EXIT_FAILURE); + abort(); } -void logprint(enum LOGLEVEL level, char *msg, ...){ - - if(!logprops.dst){ +void logprint(enum LOGLEVEL level, char *msg, ...) { + if (!logprops.dst) { fprintf(stderr, "Logger has been called, but was not initialized\n"); - exit(EXIT_FAILURE); + abort(); } - if(level > logprops.level || level == QUIET) return ; - + if (level > logprops.level || level == QUIET) { + return; + } va_list args; char timestr[200]; @@ -44,15 +46,12 @@ void logprint(enum LOGLEVEL level, char *msg, ...){ if (strftime(timestr, sizeof(timestr), "%Y/%m/%d %H:%M:%S", tmp) == 0) { fprintf(stderr, "strftime returned 0"); - exit(EXIT_FAILURE); + abort(); } fprintf(logprops.dst, "%s", timestr); - fprintf(logprops.dst, " "); - fprintf(logprops.dst, "[%s]", loglevels[level]); - fprintf(logprops.dst, " - "); va_start(args, msg); @@ -62,5 +61,4 @@ void logprint(enum LOGLEVEL level, char *msg, ...){ fprintf(logprops.dst, "\n"); fflush(logprops.dst); - -} \ No newline at end of file +} diff --git a/src/core/main.c b/src/core/main.c index 655a4c3..25b5366 100644 --- a/src/core/main.c +++ b/src/core/main.c @@ -14,26 +14,23 @@ enum event_loop_fd { static const char service_name[] = "org.freedesktop.impl.portal.desktop.wlr"; -int xdpw_usage(FILE* stream, int rc) -{ +int xdpw_usage(FILE* stream, int rc) { static const char* usage = -"Usage: xdg-desktop-portal-wlr [options]\n" -"\n" -" -l, --loglevel= Select log level (default is ERROR).\n" -" QUIET, ERROR, WARN, INFO, DEBUG, TRACE\n" -" -o, --output= Select output to capture.\n" -" -p,--pixelformat=BGRx|RGBx Force a pixelformat in pipewire\n" -" metadata (performs no conversion).\n" -" -h,--help Get help (this text).\n" -"\n"; + "Usage: xdg-desktop-portal-wlr [options]\n" + "\n" + " -l, --loglevel= Select log level (default is ERROR).\n" + " QUIET, ERROR, WARN, INFO, DEBUG, TRACE\n" + " -o, --output= Select output to capture.\n" + " -p,--pixelformat=BGRx|RGBx Force a pixelformat in pipewire\n" + " metadata (performs no conversion).\n" + " -h,--help Get help (this text).\n" + "\n"; fprintf(stream, "%s", usage); - return rc; } int main(int argc, char *argv[]) { - const char* output_name = NULL; const char* forced_pixelformat = NULL; enum LOGLEVEL loglevel = ERROR; diff --git a/src/screencast/pipewire_screencast.c b/src/screencast/pipewire_screencast.c index 0e28909..e7199ab 100644 --- a/src/screencast/pipewire_screencast.c +++ b/src/screencast/pipewire_screencast.c @@ -1,6 +1,6 @@ #include "pipewire_screencast.h" -static inline void init_type(struct pwr_type *type, struct pw_type *map) { +static void init_type(struct pwr_type *type, struct pw_type *map) { pw_type_get(map, SPA_TYPE__MediaType, &type->media_type); pw_type_get(map, SPA_TYPE__MediaSubtype, &type->media_subtype); pw_type_get(map, SPA_TYPE_FORMAT__Video, &type->format_video); @@ -9,8 +9,7 @@ static inline void init_type(struct pwr_type *type, struct pw_type *map) { }; static void writeFrameData(void *pwFramePointer, void *wlrFramePointer, - uint32_t height, uint32_t stride, bool inverted) { - + uint32_t height, uint32_t stride, bool inverted) { if (!inverted) { memcpy(pwFramePointer, wlrFramePointer, height * stride); return; @@ -21,6 +20,7 @@ static void writeFrameData(void *pwFramePointer, void *wlrFramePointer, void *pwRowPointer = pwFramePointer + (i * stride); memcpy(pwRowPointer, flippedWlrRowPointer, stride); } + return; } @@ -63,7 +63,7 @@ static void pwr_on_event(void *data, uint64_t expirations) { d[0].fd = -1; writeFrameData(d[0].data, ctx->simple_frame.data, ctx->simple_frame.height, - ctx->simple_frame.stride, ctx->simple_frame.y_invert); + ctx->simple_frame.stride, ctx->simple_frame.y_invert); logprint(TRACE, "pipewire: pointer %p", d[0].data); logprint(TRACE, "pipewire: size %d", d[0].maxsize); @@ -76,17 +76,15 @@ static void pwr_on_event(void *data, uint64_t expirations) { pw_stream_queue_buffer(ctx->stream, pw_buf); wlr_frame_free(state); - } static void pwr_handle_stream_state_changed(void *data, - enum pw_stream_state old, - enum pw_stream_state state, - const char *error) { + enum pw_stream_state old, enum pw_stream_state state, const char *error) { struct screencast_context *ctx = data; ctx->node_id = pw_stream_get_node_id(ctx->stream); - logprint(INFO, "pipewire: stream state changed to \"%s\"", pw_stream_state_as_string(state)); + logprint(INFO, "pipewire: stream state changed to \"%s\"", + pw_stream_state_as_string(state)); logprint(INFO, "pipewire: node id is %d", ctx->node_id); switch (state) { @@ -100,45 +98,46 @@ static void pwr_handle_stream_state_changed(void *data, } static void pwr_handle_stream_format_changed(void *data, - const struct spa_pod *format) { + const struct spa_pod *format) { struct screencast_context *ctx = data; struct pw_stream *stream = ctx->stream; struct pw_type *t = ctx->t; uint8_t params_buffer[1024]; struct spa_pod_builder b = - SPA_POD_BUILDER_INIT(params_buffer, sizeof(params_buffer)); + SPA_POD_BUILDER_INIT(params_buffer, sizeof(params_buffer)); const struct spa_pod *params[2]; if (format == NULL) { pw_stream_finish_format(stream, 0, NULL, 0); return; } + spa_format_video_raw_parse(format, &ctx->pwr_format, &ctx->type.format_video); params[0] = spa_pod_builder_object( - &b, t->param.idBuffers, t->param_buffers.Buffers, ":", - t->param_buffers.size, "i", ctx->simple_frame.size, ":", - t->param_buffers.stride, "i", ctx->simple_frame.stride, ":", - t->param_buffers.buffers, "iru", BUFFERS, SPA_POD_PROP_MIN_MAX(1, 32), - ":", t->param_buffers.align, "i", ALIGN); + &b, t->param.idBuffers, t->param_buffers.Buffers, ":", + t->param_buffers.size, "i", ctx->simple_frame.size, ":", + t->param_buffers.stride, "i", ctx->simple_frame.stride, ":", + t->param_buffers.buffers, "iru", BUFFERS, SPA_POD_PROP_MIN_MAX(1, 32), + ":", t->param_buffers.align, "i", ALIGN); - params[1] = spa_pod_builder_object(&b, t->param.idMeta, t->param_meta.Meta, - ":", t->param_meta.type, "I", - t->meta.Header, ":", t->param_meta.size, - "i", sizeof(struct spa_meta_header)); + params[1] = spa_pod_builder_object(&b, + t->param.idMeta, t->param_meta.Meta, + ":", t->param_meta.type, "I", + t->meta.Header, ":", t->param_meta.size, + "i", sizeof(struct spa_meta_header)); pw_stream_finish_format(stream, 0, params, 2); } static const struct pw_stream_events pwr_stream_events = { - PW_VERSION_STREAM_EVENTS, - .state_changed = pwr_handle_stream_state_changed, - .format_changed = pwr_handle_stream_format_changed, + PW_VERSION_STREAM_EVENTS, + .state_changed = pwr_handle_stream_state_changed, + .format_changed = pwr_handle_stream_format_changed, }; static void pwr_handle_state_changed(void *data, enum pw_remote_state old, - enum pw_remote_state pwr_remote_state, - const char *error) { + enum pw_remote_state pwr_remote_state, const char *error) { struct xdpw_state *state = data; struct screencast_context *ctx = &state->screencast; struct pw_remote *remote = ctx->remote; @@ -146,7 +145,7 @@ static void pwr_handle_state_changed(void *data, enum pw_remote_state old, switch (pwr_remote_state) { case PW_REMOTE_STATE_ERROR: logprint(INFO, "pipewire: remote state changed to \"%s\"", - pw_remote_state_as_string(pwr_remote_state)); + pw_remote_state_as_string(pwr_remote_state)); logprint(ERROR, "pipewire: remote error: %s", error); pw_loop_leave(state->pw_loop); pw_loop_destroy(state->pw_loop); @@ -159,47 +158,47 @@ static void pwr_handle_state_changed(void *data, enum pw_remote_state old, struct spa_pod_builder b = SPA_POD_BUILDER_INIT(buffer, sizeof(buffer)); logprint(INFO, "pipewire: remote state changed to \"%s\"", - pw_remote_state_as_string(pwr_remote_state)); + pw_remote_state_as_string(pwr_remote_state)); ctx->stream = pw_stream_new( - remote, "wlr_screeencopy", - pw_properties_new("media.class", "Video/Source", PW_NODE_PROP_MEDIA, - "Video", PW_NODE_PROP_CATEGORY, "Source", - PW_NODE_PROP_ROLE, "Screen", NULL)); + remote, "wlr_screeencopy", + pw_properties_new("media.class", + "Video/Source", PW_NODE_PROP_MEDIA, + "Video", PW_NODE_PROP_CATEGORY, "Source", + PW_NODE_PROP_ROLE, "Screen", NULL)); params[0] = spa_pod_builder_object( - &b, ctx->t->param.idEnumFormat, ctx->t->spa_format, "I", - ctx->type.media_type.video, "I", ctx->type.media_subtype.raw, ":", - ctx->type.format_video.format, "I", pipewire_from_wl_shm(ctx), ":", - ctx->type.format_video.size, "Rru", - &SPA_RECTANGLE(ctx->simple_frame.width, ctx->simple_frame.height), - SPA_POD_PROP_MIN_MAX(&SPA_RECTANGLE(1, 1), &SPA_RECTANGLE(4096, 4096)), - ":", ctx->type.format_video.framerate, "F", - // specify variable framerate - &SPA_FRACTION(0, 1), - ":", ctx->type.format_video.max_framerate, "F", - // with a maximum at the wlroots specified hardware framerate - &SPA_FRACTION(ctx->framerate, 1)); + &b, ctx->t->param.idEnumFormat, ctx->t->spa_format, "I", + ctx->type.media_type.video, "I", ctx->type.media_subtype.raw, ":", + ctx->type.format_video.format, "I", pipewire_from_wl_shm(ctx), ":", + ctx->type.format_video.size, "Rru", + &SPA_RECTANGLE(ctx->simple_frame.width, ctx->simple_frame.height), + SPA_POD_PROP_MIN_MAX(&SPA_RECTANGLE(1, 1), &SPA_RECTANGLE(4096, 4096)), + ":", ctx->type.format_video.framerate, "F", + // specify variable framerate + &SPA_FRACTION(0, 1), + ":", ctx->type.format_video.max_framerate, "F", + // with a maximum at the wlroots specified hardware framerate + &SPA_FRACTION(ctx->framerate, 1)); pw_stream_add_listener(ctx->stream, &ctx->stream_listener, - &pwr_stream_events, ctx); + &pwr_stream_events, ctx); pw_stream_connect(ctx->stream, PW_DIRECTION_OUTPUT, NULL, - PW_STREAM_FLAG_DRIVER | PW_STREAM_FLAG_MAP_BUFFERS, - params, 1); + PW_STREAM_FLAG_DRIVER | PW_STREAM_FLAG_MAP_BUFFERS, params, 1); break; } default: logprint(INFO, "pipewire: remote state changed to \"%s\"", - pw_remote_state_as_string(pwr_remote_state)); + pw_remote_state_as_string(pwr_remote_state)); break; } } static const struct pw_remote_events pwr_remote_events = { - PW_VERSION_REMOTE_EVENTS, - .state_changed = pwr_handle_state_changed, + PW_VERSION_REMOTE_EVENTS, + .state_changed = pwr_handle_state_changed, }; void *pwr_start(struct xdpw_state *state) { @@ -216,10 +215,10 @@ void *pwr_start(struct xdpw_state *state) { /* make an event to signal frame ready */ ctx->event = - pw_loop_add_event(state->pw_loop, pwr_on_event, state); + pw_loop_add_event(state->pw_loop, pwr_on_event, state); pw_remote_add_listener(ctx->remote, &ctx->remote_listener, &pwr_remote_events, - state); + state); pw_remote_connect(ctx->remote); return NULL; diff --git a/src/screencast/screencast.c b/src/screencast/screencast.c index a5c0dfa..c7fd8e4 100644 --- a/src/screencast/screencast.c +++ b/src/screencast/screencast.c @@ -9,8 +9,8 @@ int setup_outputs(struct xdpw_state *state) { struct wayland_output *output, *tmp_o; wl_list_for_each_reverse_safe(output, tmp_o, &ctx->output_list, link) { - logprint(INFO, "wlroots: capturable output: %s model: %s: id: %i name: %s", output->make, - output->model, output->id, output->name); + logprint(INFO, "wlroots: capturable output: %s model: %s: id: %i name: %s", + output->make, output->model, output->id, output->name); } struct wayland_output *out; @@ -18,13 +18,13 @@ int setup_outputs(struct xdpw_state *state) { out = wlr_output_find_by_name(&ctx->output_list, ctx->output_name); if (!out) { logprint(ERROR, "wlroots: no such output"); - exit(EXIT_FAILURE); + abort(); } } else { out = wlr_output_first(&ctx->output_list); if (!out) { logprint(ERROR, "wlroots: no output found"); - exit(EXIT_FAILURE); + abort(); } } @@ -39,12 +39,10 @@ int setup_outputs(struct xdpw_state *state) { } -void *start_screencast(void *data){ - +void *start_screencast(void *data) { struct xdpw_state *state = data; wlr_register_cb(state); - // process at least one frame so that we know // some of the metadata required for the pipewire // remote state connected event @@ -54,7 +52,6 @@ void *start_screencast(void *data){ pwr_start(state); return NULL; - } static int method_screencast_create_session(sd_bus_message *msg, void *data, @@ -80,13 +77,13 @@ static int method_screencast_create_session(sd_bus_message *msg, void *data, char* key; int innerRet = 0; - while((ret = sd_bus_message_enter_container(msg, 'e', "sv")) > 0) { + while ((ret = sd_bus_message_enter_container(msg, 'e', "sv")) > 0) { innerRet = sd_bus_message_read(msg, "s", &key); if (innerRet < 0) { return innerRet; } - if(strcmp(key, "session_handle_token") == 0) { + if (strcmp(key, "session_handle_token") == 0) { char* token; sd_bus_message_read(msg, "v", "s", &token); logprint(INFO, "dbus: option token: %s", token); @@ -142,8 +139,8 @@ static int method_screencast_create_session(sd_bus_message *msg, void *data, } -static int method_screencast_select_sources(sd_bus_message *msg, void *data, sd_bus_error *ret_error) { - +static int method_screencast_select_sources(sd_bus_message *msg, void *data, + sd_bus_error *ret_error) { struct xdpw_state *state = data; int ret = 0; @@ -168,20 +165,20 @@ static int method_screencast_select_sources(sd_bus_message *msg, void *data, sd_ char* key; int innerRet = 0; - while((ret = sd_bus_message_enter_container(msg, 'e', "sv")) > 0) { + while ((ret = sd_bus_message_enter_container(msg, 'e', "sv")) > 0) { innerRet = sd_bus_message_read(msg, "s", &key); if (innerRet < 0) { return innerRet; } - if(strcmp(key, "multiple") == 0) { + if (strcmp(key, "multiple") == 0) { bool multiple; sd_bus_message_read(msg, "v", "b", &multiple); logprint(INFO, "dbus: option multiple: %x", multiple); - } else if(strcmp(key, "types") == 0) { + } else if (strcmp(key, "types") == 0) { uint32_t mask; sd_bus_message_read(msg, "v", "u", &mask); - logprint(INFO, "dbus: option types: %x", mask); + logprint(INFO, "dbus: option types:%x", mask); } else { logprint(WARN, "dbus: unknown option %s", key); sd_bus_message_skip(msg, "v"); @@ -219,8 +216,8 @@ static int method_screencast_select_sources(sd_bus_message *msg, void *data, sd_ return 0; } -static int method_screencast_start(sd_bus_message *msg, void *data, sd_bus_error *ret_error) { - +static int method_screencast_start(sd_bus_message *msg, void *data, + sd_bus_error *ret_error) { struct xdpw_state *state = data; struct screencast_context *ctx = &state->screencast; @@ -247,7 +244,7 @@ static int method_screencast_start(sd_bus_message *msg, void *data, sd_bus_error char* key; int innerRet = 0; - while((ret = sd_bus_message_enter_container(msg, 'e', "sv")) > 0) { + while ((ret = sd_bus_message_enter_container(msg, 'e', "sv")) > 0) { innerRet = sd_bus_message_read(msg, "s", &key); if (innerRet < 0) { return innerRet; @@ -275,19 +272,19 @@ static int method_screencast_start(sd_bus_message *msg, void *data, sd_bus_error return ret; } - while(ctx->node_id == 0){ + while (ctx->node_id == 0) { int ret = pw_loop_iterate(state->pw_loop, 0); if (ret < 0) { - logprint(ERROR, "pipewire_loop_iterate failed: %s", - spa_strerror(ret)); + logprint(ERROR, "pipewire_loop_iterate failed: %s", spa_strerror(ret)); } } ret = sd_bus_message_append(reply, "ua{sv}", PORTAL_RESPONSE_SUCCESS, 1, - "streams", "a(ua{sv})", 1, - ctx->node_id, 2, - "position", "(ii)", 0, 0, - "size", "(ii)", ctx->simple_frame.width, ctx->simple_frame.height); + "streams", "a(ua{sv})", 1, + ctx->node_id, 2, + "position", "(ii)", 0, 0, + "size", "(ii)", ctx->simple_frame.width, ctx->simple_frame.height); + if (ret < 0) { return ret; } @@ -303,9 +300,12 @@ static int method_screencast_start(sd_bus_message *msg, void *data, sd_bus_error static const sd_bus_vtable screencast_vtable[] = { SD_BUS_VTABLE_START(0), - SD_BUS_METHOD("CreateSession", "oosa{sv}", "ua{sv}", method_screencast_create_session, SD_BUS_VTABLE_UNPRIVILEGED), - SD_BUS_METHOD("SelectSources", "oosa{sv}", "ua{sv}", method_screencast_select_sources, SD_BUS_VTABLE_UNPRIVILEGED), - SD_BUS_METHOD("Start", "oossa{sv}", "ua{sv}", method_screencast_start, SD_BUS_VTABLE_UNPRIVILEGED), + SD_BUS_METHOD("CreateSession", "oosa{sv}", "ua{sv}", + method_screencast_create_session, SD_BUS_VTABLE_UNPRIVILEGED), + SD_BUS_METHOD("SelectSources", "oosa{sv}", "ua{sv}", + method_screencast_select_sources, SD_BUS_VTABLE_UNPRIVILEGED), + SD_BUS_METHOD("Start", "oossa{sv}", "ua{sv}", + method_screencast_start, SD_BUS_VTABLE_UNPRIVILEGED), SD_BUS_VTABLE_END }; @@ -316,11 +316,10 @@ int init_screencast(struct xdpw_state *state, const char *output_name, const cha state->screencast = (struct screencast_context) { 0 }; state->screencast.forced_pixelformat = forced_pixelformat; state->screencast.output_name = output_name; - state->screencast.simple_frame = (struct simple_frame){0}; - state->screencast.simple_frame.damage = &(struct damage){0}; + state->screencast.simple_frame = (struct simple_frame) { 0 }; + state->screencast.simple_frame.damage = &(struct damage) { 0 }; - int err; - err = wlr_screencopy_init(state); + int err = wlr_screencopy_init(state); if (err) { goto end; } @@ -328,7 +327,7 @@ int init_screencast(struct xdpw_state *state, const char *output_name, const cha return sd_bus_add_object_vtable(state->bus, &slot, object_path, interface_name, screencast_vtable, state); - end: - wlr_screencopy_uninit(&state->screencast); - return err; +end: + wlr_screencopy_uninit(&state->screencast); + return err; } diff --git a/src/screencast/screencast_common.c b/src/screencast/screencast_common.c index 03089a8..7b5631e 100644 --- a/src/screencast/screencast_common.c +++ b/src/screencast/screencast_common.c @@ -1,45 +1,37 @@ #include "screencast_common.h" -char *strdup(const char *src) { - char *dst = malloc(strlen(src) + 1); // Space for length plus nul - if (dst == NULL) - return NULL; // No memory - strcpy(dst, src); // Copy the characters - return dst; // Return the new string -} - uint32_t pipewire_from_wl_shm(void *data) { struct screencast_context *ctx = data; - if(ctx->forced_pixelformat){ - if(strcmp(ctx->forced_pixelformat, "BGRx") == 0) { + if (ctx->forced_pixelformat) { + if (strcmp(ctx->forced_pixelformat, "BGRx") == 0) { return ctx->type.video_format.BGRx; } - if(strcmp(ctx->forced_pixelformat, "RGBx") == 0){ + if (strcmp(ctx->forced_pixelformat, "RGBx") == 0) { return ctx->type.video_format.RGBx; } } switch (ctx->simple_frame.format) { - case WL_SHM_FORMAT_ARGB8888: - return ctx->type.video_format.BGRA; - case WL_SHM_FORMAT_XRGB8888: - return ctx->type.video_format.BGRx; - case WL_SHM_FORMAT_RGBA8888: - return ctx->type.video_format.ABGR; - case WL_SHM_FORMAT_RGBX8888: - return ctx->type.video_format.xBGR; - case WL_SHM_FORMAT_ABGR8888: - return ctx->type.video_format.RGBA; - case WL_SHM_FORMAT_XBGR8888: - return ctx->type.video_format.RGBx; - case WL_SHM_FORMAT_BGRA8888: - return ctx->type.video_format.ARGB; - case WL_SHM_FORMAT_BGRX8888: - return ctx->type.video_format.xRGB; - case WL_SHM_FORMAT_NV12: - return ctx->type.video_format.NV12; - default: - exit(EXIT_FAILURE); + case WL_SHM_FORMAT_ARGB8888: + return ctx->type.video_format.BGRA; + case WL_SHM_FORMAT_XRGB8888: + return ctx->type.video_format.BGRx; + case WL_SHM_FORMAT_RGBA8888: + return ctx->type.video_format.ABGR; + case WL_SHM_FORMAT_RGBX8888: + return ctx->type.video_format.xBGR; + case WL_SHM_FORMAT_ABGR8888: + return ctx->type.video_format.RGBA; + case WL_SHM_FORMAT_XBGR8888: + return ctx->type.video_format.RGBx; + case WL_SHM_FORMAT_BGRA8888: + return ctx->type.video_format.ARGB; + case WL_SHM_FORMAT_BGRX8888: + return ctx->type.video_format.xRGB; + case WL_SHM_FORMAT_NV12: + return ctx->type.video_format.NV12; + default: + abort(); } } diff --git a/src/screencast/wlr_screencast.c b/src/screencast/wlr_screencast.c index 3300006..7b80847 100644 --- a/src/screencast/wlr_screencast.c +++ b/src/screencast/wlr_screencast.c @@ -1,23 +1,22 @@ +#define _POSIX_C_SOURCE 200809L + #include "wlr_screencast.h" #include "xdpw.h" void wlr_frame_free(struct xdpw_state *state) { - zwlr_screencopy_frame_v1_destroy(state->screencast.wlr_frame); munmap(state->screencast.simple_frame.data, state->screencast.simple_frame.size); wl_buffer_destroy(state->screencast.simple_frame.buffer); logprint(TRACE, "wlroots: frame destroyed"); - if(!state->screencast.quit && !state->screencast.err){ + if (!state->screencast.quit && !state->screencast.err) { wlr_register_cb(state); } - } static struct wl_buffer *create_shm_buffer(struct screencast_context *ctx, - enum wl_shm_format fmt, int width, - int height, int stride, - void **data_out) { + enum wl_shm_format fmt, int width, int height, int stride, + void **data_out) { int size = stride * height; const char shm_name[] = "/wlroots-screencopy"; @@ -47,7 +46,7 @@ static struct wl_buffer *create_shm_buffer(struct screencast_context *ctx, struct wl_shm_pool *pool = wl_shm_create_pool(ctx->shm, fd, size); close(fd); struct wl_buffer *buffer = - wl_shm_pool_create_buffer(pool, 0, width, height, stride, fmt); + wl_shm_pool_create_buffer(pool, 0, width, height, stride, fmt); wl_shm_pool_destroy(pool); *data_out = data; @@ -55,8 +54,7 @@ static struct wl_buffer *create_shm_buffer(struct screencast_context *ctx, } static void wlr_frame_buffer(void *data, struct zwlr_screencopy_frame_v1 *frame, - uint32_t format, uint32_t width, uint32_t height, - uint32_t stride) { + uint32_t format, uint32_t width, uint32_t height, uint32_t stride) { struct xdpw_state *state = data; struct screencast_context *ctx = &state->screencast; @@ -68,10 +66,11 @@ static void wlr_frame_buffer(void *data, struct zwlr_screencopy_frame_v1 *frame, ctx->simple_frame.size = stride * height; ctx->simple_frame.format = format; ctx->simple_frame.buffer = create_shm_buffer(ctx, format, width, height, - stride, &ctx->simple_frame.data); + stride, &ctx->simple_frame.data); + if (ctx->simple_frame.buffer == NULL) { logprint(ERROR, "wlroots: failed to create buffer"); - exit(EXIT_FAILURE); + abort(); } zwlr_screencopy_frame_v1_copy_with_damage(frame, ctx->simple_frame.buffer); @@ -79,18 +78,16 @@ static void wlr_frame_buffer(void *data, struct zwlr_screencopy_frame_v1 *frame, } static void wlr_frame_flags(void *data, struct zwlr_screencopy_frame_v1 *frame, - uint32_t flags) { + uint32_t flags) { struct xdpw_state *state = data; struct screencast_context *ctx = &state->screencast; logprint(TRACE, "wlroots: flags event handler"); ctx->simple_frame.y_invert = flags & ZWLR_SCREENCOPY_FRAME_V1_FLAGS_Y_INVERT; - } static void wlr_frame_ready(void *data, struct zwlr_screencopy_frame_v1 *frame, - uint32_t tv_sec_hi, uint32_t tv_sec_lo, - uint32_t tv_nsec) { + uint32_t tv_sec_hi, uint32_t tv_sec_lo, uint32_t tv_nsec) { struct xdpw_state *state = data; struct screencast_context *ctx = &state->screencast; @@ -105,11 +102,10 @@ static void wlr_frame_ready(void *data, struct zwlr_screencopy_frame_v1 *frame, } wlr_frame_free(state); - } static void wlr_frame_failed(void *data, - struct zwlr_screencopy_frame_v1 *frame) { + struct zwlr_screencopy_frame_v1 *frame) { struct xdpw_state *state = data; struct screencast_context *ctx = &state->screencast; @@ -120,8 +116,7 @@ static void wlr_frame_failed(void *data, } static void wlr_frame_damage(void *data, struct zwlr_screencopy_frame_v1 *frame, - uint32_t x, uint32_t y, uint32_t width, - uint32_t height) { + uint32_t x, uint32_t y, uint32_t width, uint32_t height) { struct xdpw_state *state = data; struct screencast_context *ctx = &state->screencast; @@ -134,38 +129,34 @@ static void wlr_frame_damage(void *data, struct zwlr_screencopy_frame_v1 *frame, } static const struct zwlr_screencopy_frame_v1_listener wlr_frame_listener = { - .buffer = wlr_frame_buffer, - .flags = wlr_frame_flags, - .ready = wlr_frame_ready, - .failed = wlr_frame_failed, - .damage = wlr_frame_damage, + .buffer = wlr_frame_buffer, + .flags = wlr_frame_flags, + .ready = wlr_frame_ready, + .failed = wlr_frame_failed, + .damage = wlr_frame_damage, }; void wlr_register_cb(struct xdpw_state *state) { - struct screencast_context *ctx = &state->screencast; - + ctx->frame_callback = zwlr_screencopy_manager_v1_capture_output( - ctx->screencopy_manager, ctx->with_cursor, ctx->target_output->output); + ctx->screencopy_manager, ctx->with_cursor, ctx->target_output->output); zwlr_screencopy_frame_v1_add_listener(ctx->frame_callback, - &wlr_frame_listener, state); + &wlr_frame_listener, state); logprint(TRACE, "wlroots: callbacks registered"); } static void wlr_output_handle_geometry(void *data, struct wl_output *wl_output, - int32_t x, int32_t y, int32_t phys_width, - int32_t phys_height, int32_t subpixel, - const char *make, const char *model, - int32_t transform) { + int32_t x, int32_t y, int32_t phys_width, int32_t phys_height, + int32_t subpixel, const char *make, const char *model, int32_t transform) { struct wayland_output *output = data; output->make = strdup(make); output->model = strdup(model); } static void wlr_output_handle_mode(void *data, struct wl_output *wl_output, - uint32_t flags, int32_t width, - int32_t height, int32_t refresh) { + uint32_t flags, int32_t width, int32_t height, int32_t refresh) { if (flags & WL_OUTPUT_MODE_CURRENT) { struct wayland_output *output = data; output->framerate = (float)refresh/1000; @@ -177,49 +168,49 @@ static void wlr_output_handle_done(void *data, struct wl_output *wl_output) { } static void wlr_output_handle_scale(void *data, struct wl_output *wl_output, - int32_t factor) { + int32_t factor) { /* Nothing to do */ } static const struct wl_output_listener wlr_output_listener = { - .geometry = wlr_output_handle_geometry, - .mode = wlr_output_handle_mode, - .done = wlr_output_handle_done, - .scale = wlr_output_handle_scale, + .geometry = wlr_output_handle_geometry, + .mode = wlr_output_handle_mode, + .done = wlr_output_handle_done, + .scale = wlr_output_handle_scale, }; static void wlr_xdg_output_name(void* data, struct zxdg_output_v1* xdg_output, - const char* name){ + const char* name) { struct wayland_output *output = data; output->name = strdup(name); }; -static void dontcare(){ +static void noop() { + // This space intentionally left blank } static const struct zxdg_output_v1_listener wlr_xdg_output_listener = { - .logical_position = dontcare, - .logical_size = dontcare, + .logical_position = noop, + .logical_size = noop, .done = NULL, /* Deprecated */ - .description = dontcare, + .description = noop, .name = wlr_xdg_output_name, }; void wlr_add_xdg_output_listener(struct wayland_output *output, - struct zxdg_output_v1* xdg_output){ + struct zxdg_output_v1* xdg_output) { output->xdg_output = xdg_output; zxdg_output_v1_add_listener(output->xdg_output, &wlr_xdg_output_listener, - output); + output); } -static void wlr_init_xdg_outputs(struct screencast_context *ctx){ +static void wlr_init_xdg_outputs(struct screencast_context *ctx) { struct wayland_output *output, *tmp; wl_list_for_each_safe(output, tmp, &ctx->output_list, link) { struct zxdg_output_v1 *xdg_output = - zxdg_output_manager_v1_get_xdg_output( - ctx->xdg_output_manager, output->output); - + zxdg_output_manager_v1_get_xdg_output( ctx->xdg_output_manager, + output->output); wlr_add_xdg_output_listener(output, xdg_output); } } @@ -232,19 +223,19 @@ struct wayland_output *wlr_output_first(struct wl_list *output_list) { return NULL; } -struct wayland_output *wlr_output_find_by_name(struct wl_list *output_list, const char* name) { +struct wayland_output *wlr_output_find_by_name(struct wl_list *output_list, + const char* name) { struct wayland_output *output, *tmp; - wl_list_for_each_safe(output, tmp, output_list, link){ - if (strcmp(output->name, name) == 0){ + wl_list_for_each_safe(output, tmp, output_list, link) { + if (strcmp(output->name, name) == 0) { return output; } } return NULL; } - struct wayland_output *wlr_output_find(struct screencast_context *ctx, - struct wl_output *out, uint32_t id) { + struct wl_output *out, uint32_t id) { struct wayland_output *output, *tmp; wl_list_for_each_safe(output, tmp, &ctx->output_list, link) { if ((output->output == out) || (output->id == id)) { @@ -259,8 +250,7 @@ static void wlr_remove_output(struct wayland_output *out) { } static void wlr_registry_handle_add(void *data, struct wl_registry *reg, - uint32_t id, const char *interface, - uint32_t ver) { + uint32_t id, const char *interface, uint32_t ver) { struct screencast_context *ctx = data; if (!strcmp(interface, wl_output_interface.name)) { @@ -275,7 +265,7 @@ static void wlr_registry_handle_add(void *data, struct wl_registry *reg, if (!strcmp(interface, zwlr_screencopy_manager_v1_interface.name)) { ctx->screencopy_manager = wl_registry_bind( - reg, id, &zwlr_screencopy_manager_v1_interface, SC_MANAGER_VERSION); + reg, id, &zwlr_screencopy_manager_v1_interface, SC_MANAGER_VERSION); } if (strcmp(interface, wl_shm_interface.name) == 0) { @@ -289,14 +279,14 @@ static void wlr_registry_handle_add(void *data, struct wl_registry *reg, } static void wlr_registry_handle_remove(void *data, struct wl_registry *reg, - uint32_t id) { + uint32_t id) { wlr_remove_output( - wlr_output_find((struct screencast_context *)data, NULL, id)); + wlr_output_find((struct screencast_context *)data, NULL, id)); } static const struct wl_registry_listener wlr_registry_listener = { - .global = wlr_registry_handle_add, - .global_remove = wlr_registry_handle_remove, + .global = wlr_registry_handle_add, + .global_remove = wlr_registry_handle_remove, }; int wlr_screencopy_init(struct xdpw_state *state) { @@ -330,7 +320,7 @@ int wlr_screencopy_init(struct xdpw_state *state) { // make sure our wlroots supports screencopy protocol if (!ctx->screencopy_manager) { logprint(ERROR, "Compositor doesn't support %s!", - zwlr_screencopy_manager_v1_interface.name); + zwlr_screencopy_manager_v1_interface.name); return -1; }