hyprwm/xdg-desktop-portal-hyprland
1
0
Fork 0
mirror of https://github.com/hyprwm/xdg-desktop-portal-hyprland.git synced 2024-11-26 07:55:58 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix potential memory corruption when reading bools

Browse source 
As per `man sd_bus_message_read`, boolean items should be read into an
int rather than a bool as the latter can cause memory corruption.
This commit is contained in:
GermainZ 2021-07-01 13:38:21 +02:00 committed by Simon Ser
parent e23e109e41
commit 668509e317
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/screencast/screencast.c
View file

@ -267,9 +267,9 @@ static int method_screencast_select_sources(sd_bus_message *msg, void *data,
} }
if (strcmp(key, "multiple") == 0) { if (strcmp(key, "multiple") == 0) {
bool multiple; int multiple;
sd_bus_message_read(msg, "v", "b", &multiple); sd_bus_message_read(msg, "v", "b", &multiple);
logprint(INFO, "dbus: option multiple: %x", multiple); logprint(INFO, "dbus: option multiple: %d", multiple);
} else if (strcmp(key, "types") == 0) { } else if (strcmp(key, "types") == 0) {
uint32_t mask; uint32_t mask;
sd_bus_message_read(msg, "v", "u", &mask); sd_bus_message_read(msg, "v", "u", &mask);

8
src/screenshot/screenshot.c
View file

@ -83,14 +83,14 @@ static int method_screenshot(sd_bus_message *msg, void *data,
} }
if (strcmp(key, "interactive") == 0) { if (strcmp(key, "interactive") == 0) {
bool mode; int mode;
sd_bus_message_read(msg, "v", "b", &mode); sd_bus_message_read(msg, "v", "b", &mode);
logprint(DEBUG, "dbus: option interactive: %x", mode); logprint(DEBUG, "dbus: option interactive: %d", mode);
interactive = mode; interactive = mode;
} else if (strcmp(key, "modal") == 0) { } else if (strcmp(key, "modal") == 0) {
bool modal; int modal;
sd_bus_message_read(msg, "v", "b", &modal); sd_bus_message_read(msg, "v", "b", &modal);
logprint(DEBUG, "dbus: option modal: %x", modal); logprint(DEBUG, "dbus: option modal: %d", modal);
} else { } else {
logprint(WARN, "dbus: unknown option %s", key); logprint(WARN, "dbus: unknown option %s", key);
sd_bus_message_skip(msg, "v"); sd_bus_message_skip(msg, "v");