From c34d09877cb55eb353311b5e85bf50443be9439d Mon Sep 17 00:00:00 2001 From: columbarius Date: Tue, 18 Jan 2022 02:42:52 +0100 Subject: [PATCH] screencast: fix check on loop_iterate According to the documentation [1] pw_loop_iterate (a macro for spa_loop_control_iterate) will return the number of dispatched fd's and thus we should check only negative return values. [1] https://docs.pipewire.org/group__spa__loop.html#ga3bae0b32100f5752b3372a505c8e04f6 --- src/screencast/screencast.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/screencast/screencast.c b/src/screencast/screencast.c index b03ad6d..ace7a1b 100644 --- a/src/screencast/screencast.c +++ b/src/screencast/screencast.c @@ -432,8 +432,9 @@ static int method_screencast_start(sd_bus_message *msg, void *data, while (cast->node_id == SPA_ID_INVALID) { int ret = pw_loop_iterate(state->pw_loop, 0); - if (ret != 0) { + if (ret < 0) { logprint(ERROR, "pipewire_loop_iterate failed: %s", spa_strerror(ret)); + return ret; } }