feat: make visible borders optional

modules/completion/nvim-cmp/config.nix

@@ -200,12 +200,13 @@ in {
 
       local cmp = require'cmp'
       cmp.setup({
+        ${optionalString (config.vim.ui.borders.enable) ''
+        -- explicitly enabled by setting ui.borders.enable = true
         window = {
-          -- TODO: at some point, those need to be optional
-          -- but first nvim cmp module needs to be detached from "cfg.autocomplete"
           completion = cmp.config.window.bordered(),
           documentation = cmp.config.window.bordered(),
         },
+      ''}
 
         snippet = {
           expand = function(args)

modules/lsp/lspconfig/config.nix

@@ -16,6 +16,11 @@ in {
 
       vim.luaConfigRC.lspconfig = nvim.dag.entryAfter ["lsp-setup"] ''
         local lspconfig = require('lspconfig')
+
+        ${
+          # TODO: make border style configurable
+          optionalString (config.vim.ui.borders.enable) "require('lspconfig.ui.windows').default_options.border = 'single'"
+        }
       '';
     }
     {

modules/ui/borders/borders.nix

@@ -0,0 +1,9 @@
+{lib, ...}: let
+  inherit (lib) mkEnableOption mkOption;
+in {
+  options.vim.ui.borders = {
+    enable = mkEnableOption "visible borders for most windows";
+
+    # TODO: make per-plugin borders configurable
+  };
+}

modules/ui/borders/default.nix

@@ -0,0 +1,5 @@
+_: {
+  imports = [
+    ./borders.nix
+  ];
+}

modules/ui/default.nix

@@ -6,5 +6,6 @@ _: {
     ./smartcolumn
     ./colorizer
     ./illuminate
+    ./borders
   ];
 }