hyprwm/wlroots-hyprland
1
0
Fork 0
mirror of https://github.com/hyprwm/wlroots-hyprland.git synced 2024-11-02 11:55:59 +01:00
Code Issues Projects Releases Packages Wiki Activity

wlr_drm_format_set_copy: Do not allocate heap

Browse source 
Address Sanitizer reported two memory leaks because of
fmt not being freed in wlr_drm_format_set_copy.

This commit fixes the memory leak by removing the
allocation to the heap. The struct is allocated to the
stack anyway.
This commit is contained in:
Tobias Predel 2023-05-14 16:29:21 +02:00
parent 10dd416694
commit e449c1dec8
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
render/drm_format_set.c
View file

@ -153,12 +153,6 @@ bool wlr_drm_format_set_copy(struct wlr_drm_format_set *dst, const struct wlr_dr
size_t i; size_t i;
for (i = 0; i < src->len; i++) { for (i = 0; i < src->len; i++) {
struct wlr_drm_format *fmt = calloc(1, sizeof(*fmt));
if (!fmt) {
wlr_drm_format_set_finish(&out);
return false;
}
out.formats[out.len] = (struct wlr_drm_format){0}; out.formats[out.len] = (struct wlr_drm_format){0};
if (!wlr_drm_format_copy(&out.formats[out.len], &src->formats[i])) { if (!wlr_drm_format_copy(&out.formats[out.len], &src->formats[i])) {
wlr_drm_format_set_finish(&out); wlr_drm_format_set_finish(&out);