hyprwm/wlroots-hyprland
1
0
Fork 0
mirror of https://github.com/hyprwm/wlroots-hyprland.git synced 2024-11-02 11:55:59 +01:00
Code Issues Projects Releases Packages Wiki Activity
4614 commits 3 branches 0 tags 13 MiB
Commit graph

179 commits

Author SHA1 Message Date
Simon Ser
641c223d3c surface: don't send protocol error on invalid buffer size 
A libwayland-cursor bug [1] makes many clients crash.

[1]: https://gitlab.freedesktop.org/wayland/wayland/-/issues/194

Fixes: 91fa2ff395 ("surface: check buffer size is compatible with scale")
Closes: https://github.com/swaywm/sway/issues/6014
 2021-02-17 10:47:54 +01:00
Simon Ser
2530235139 surface: move INVALID_SIZE check into surface_state_finalize 
This fixes some build warnings.

Closes: https://github.com/swaywm/wlroots/issues/2740
References: https://github.com/swaywm/wlroots/pull/2736
 2021-02-17 10:47:54 +01:00
Simon Ser
91fa2ff395 surface: check buffer size is compatible with scale 
This relies on [1].

[1]: 8d5fadad47
 2021-02-08 13:38:48 +01:00
Isaac Freund
f6fc4c2883 subsurface: handle NULL parent in get_root_surface 2020-12-22 15:55:05 +01:00
Kenny Levinsen
ebecc5404b surface: Make send_enter store entered outputs 
wlr_surface_send_enter now stores outputs that have been entered.
Combined with a new 'bind' event on wlr_output, this allows us to delay
enter events as necessary until the respective wl_output global has been
bound.

Closes: https://github.com/swaywm/wlroots/issues/2466
 2020-11-23 10:58:50 +01:00
Antonin Décimo
d9bb792794 Fix incorrect format parameters 2020-07-27 10:49:19 +02:00
Simon Ser
d177abecae surface: ignore viewport src rect on NULL buffer 
According to the viewporter protocol:

> If the wl_buffer is NULL, the surface has no content and therefore no size.
 2020-06-18 07:55:33 -06:00
Rouven Czerwinski
c18c419b56 surface: don't unset width and height in finalize 
During surface finalization we may not have received a new buffer,
resetting width and height in this case is wrong since we display the
old buffer in this case.
 2020-06-18 09:54:15 +02:00
Simon Ser
c618a76540 surface: introduce wlr_surface_get_buffer_source_box 
This helper allows compositors to retrieve the buffer source box in
buffer-local coordinates.
 2020-06-17 09:10:54 -06:00
Simon Ser
eb22ae97b0 surface: add wlr_surface_state.viewport 
This field contains the viewport source and destination parameters. It's
intended to be updated by a third-party protocol, for instance
viewporter.
 2020-06-17 09:10:54 -06:00
Tudor Brindus
c9c31f803e util/time: de-duplicate timespec_to_msec 2020-06-06 00:09:19 +02:00
Simon Ser
6595db6409 buffer: add a release event 
Consumers call wlr_buffer_lock. Once all consumers are done with the
buffer, only the producer should have a reference to the buffer. In this
case, we can release the buffer (and let the producer re-use it).
 2020-04-02 15:03:43 +02:00
Scott Anderson
34303e1b47 wlr_surface: Post error if multiple role objects created 
This fixes an assertion failure if a client tries to do this, e.g. by
creating multiple toplevel objects for the same surface. If the same
role data is set multiple times, this does not cause an error, which is
how cursors use this interface.
 2020-03-21 13:58:27 +01:00
Simon Ser
41f9916ae5 buffer: remove unused wlr_client_buffer fields 
Forgot to remove these, they are superseded by fields in wlr_buffer. Some
functions were still using them.

Fixes: 8afc1ed68c ("Introduce wlr_client_buffer")
Closes: https://github.com/swaywm/sway/issues/5087
 2020-03-09 19:26:12 +01:00
Simon Ser
8afc1ed68c Introduce wlr_client_buffer 
Split out the client/resource handling out of wlr_buffer by introducing
wlr_client_buffer. Make wlr_buffer an interface so that compositors can
create their own wlr_buffers (e.g. backed by GBM, like glider [1]).

[1]: c66847dd1c/include/gbm_allocator.h (L7)
 2020-03-06 21:32:06 +01:00
Simon Ser
7fc58e704a surface: don't unref the current buffer on failure 
If wlr_buffer_create fails, keep the previous buffer.
 2019-12-14 09:19:44 -05:00
Alynx Zhou
aa9ea95e1f Skip assign when sub_x or sub_y is NULL in wlr_surface_surface_at 2019-11-08 08:48:30 +01:00
Antonin Décimo
8f3d73e3a3 wlr_surface: condition is always false 2019-08-12 09:37:21 +09:00
Simon Ser
ca45f4490c Remove all wayland-server.h includes 
The documentation for wayland-server.h says:

> Use of this header file is discouraged. Prefer including
> wayland-server-core.h instead, which does not include the server protocol
> header and as such only defines the library PI, excluding the deprecated API
> below.

Replacing wayland-server.h with wayland-server-core.h allows us to drop the
WL_HIDE_DEPRECATED declaration.
 2019-07-27 15:49:32 -04:00
emersion
943e918a96
subsurface: add map/unmap events 
Fixes https://github.com/swaywm/wlroots/issues/1414
 2019-02-17 12:01:15 +01:00
emersion
d238cc9f56
surface: error out on invalid transform 2019-02-15 00:50:18 +01:00
Sebastian Krzyszkowiak
69b9e2ae8f Post protocol error on invalid wl_surface scale 
Letting the scale be set to 0 causes division by zero errors.
 2019-02-15 00:45:12 +01:00
emersion
a5b8ea90d2
surface: fix destroyed subsurfaces handling 
wlr_subsurface_from_wlr_surface can return NULL if the wl_surface is still
alive and if the wl_subsurface has been destroyed. Make sure we check for NULL.

Fixes https://github.com/swaywm/sway/issues/3195
 2018-11-26 23:17:52 +01:00
Drew DeVault
d7b010024a
Merge pull request #1261 from arandomhuman/damage-control 
Fix damage tracking for surfaces with transforms
 2018-11-04 14:31:17 +01:00
emersion
dec303bea6
surface: fix wlr_surface_get_effective_damage to give surface coords 
Transforms were applied, but scale wasn't.
 2018-11-04 11:13:10 +01:00
random human
3e0a0f3c3a
wlr_surface: add wlr_surface_get_effective_damage 
This calculates and returns the effective damage of the surface in
surface coordinates, including the client damage (in buffer
coordinates), and damage induced by resize or move events.
 2018-10-04 02:19:09 +05:30
random human
84ecfb546b
wlr_surface: more consistent argument naming in surface_update_damage 2018-09-25 02:06:02 +05:30
random human
5eca5d8946
wlr_surface: remove duplicated damage calculation 
The damage is already calculated and stored in surface->buffer_damage
by surface_update_damage().
 2018-09-25 01:38:09 +05:30
random human
3fd5da58a0
wlr_surface: fix surface damage on resize 
Instead of damaging the buffer, damage only the surface on surface (not
buffer) resize.
 2018-09-25 01:25:30 +05:30
random human
971cbeaa19
wlr_surface: fix surface damage transformation 
Damage tracking on transformed surfaces now work (see
"weston-simple-damage --rotation=90"), using either of buffer or surface
damage.
 2018-09-24 22:03:41 +05:30
Las
afa2e399aa Fix implicit conversion of floats to ints in calls to pixman_region32_contains_point 
I do not think the conversion is specifically defined, but on my system and SirCmpwn's
the floats are rounded instead of floored, which is incorrect in this case, since
for a range from 0 to 256, any value greater or equal to 0 and less than 256 is valid.
I.e. [0;256[, or 0 <= x < 256, but if x is e.g. -0.1, then it will be rounded to 0, which
is invalid. The correct behavior would be to floor to -1.
 2018-09-18 13:05:44 +02:00
Las
6367e0bc93 Add wlr_surface::input_region member 
This is analogous to the opaque_region member.

In addition the code for setting the opaque region is cleaned up.
 2018-09-18 10:14:33 +02:00
emersion
16d7e09d99 surface: add wlr_surface_role.precommit 
This allows to emit the unmap event before the surface becomes
actually unmapped for most shells.
 2018-07-15 19:30:19 +01:00
emersion
5bb272d7f3 surface: add wlr_surface.opaque_region 2018-07-13 10:54:51 +01:00
Drew DeVault
c0b4217fce
Merge pull request #1116 from emersion/surface-role 
surface: replace wlr_surface_set_role_committed with wlr_surface_role
 2018-07-11 15:27:42 -07:00
emersion
7cbef15206
util: add wlr_ prefix to log symbols 2018-07-09 22:49:54 +01:00
emersion
deeca53e33
Rename wl_resources to resource, wl_global to global 2018-07-08 19:21:31 +01:00
emersion
33db4263a0
surface: replace wlr_surface_set_role_committed with wlr_surface_role 2018-07-07 22:45:16 +01:00
emersion
515d682312
surface: fix damage when moving subsurfaces with scale > 1 2018-07-04 19:16:16 +01:00
emersion
e665a74122
surface: don't clip input and opaque regions 
These can be set to e.g. regions larger than the surface. If the
surface resizes itself, it doesn't need to set again these regions.
 2018-07-04 19:12:18 +01:00
emersion
226306ed45
surface: rename wlr_surface_state.buffer to buffer_resource 2018-07-04 19:12:18 +01:00
emersion
68c133da2f
surface: fix crash on NULL commit 2018-07-04 19:12:18 +01:00
emersion
6f0eb11024
surface: fix previous state eating current state resources 2018-07-04 19:12:18 +01:00
emersion
012e38fbe5
surface: add wlr_surface.previous 2018-07-04 19:12:18 +01:00
emersion
78555abba3
surface: move position and scale out of wlr_surface_state 2018-07-04 19:12:17 +01:00
emersion
233bfe2f4f
surface: do not monkey-patch state damage 2018-07-04 19:12:17 +01:00
emersion
adf0423f7c
surface: better buffer position handling 2018-07-04 19:12:17 +01:00
emersion
3c0d672ebd
surface: make pending and current embedded structs 2018-07-04 19:12:17 +01:00
emersion
64836ddfe7
surface: remove wlr_surface_state.subsurface_position 2018-07-04 19:12:17 +01:00
emersion
3ee86b6105
surface: rename invalid state 2018-07-04 19:12:16 +01:00