Simon Ser
fffa1908af
backend/drm: fix libliftoff_plane double-free
...
Destroying the liftoff_device invalidates all of the liftoff_planes.
Destroy the liftoff_planes before the liftoff_device to fix this.
2023-06-22 18:00:34 +00:00
Simon Ser
8714657d7b
xwayland: unset wlr_xwayland.server on destroy
...
This fixes a use-after-free in the Sway patch to filter the Xwayland
shell [1].
The server is destroyed first, then the shell. The Xwayland process
might still be using the shell while running.
When the shell is destroyed, libwayland will invoke the global
filter (to figure out whether to send a wl_registry.global_remove
to clients). Then Sway will compare the client with
wlr_xwayland_server.client. However, at that point, the server is
gone.
Reset the server to NULL so that Sway can check whether the server
is still running.
[1]: https://github.com/swaywm/sway/pull/7647
2023-06-22 16:28:43 +02:00
Simon Ser
d59749aa44
cursor: add support for animated XCursor
2023-06-22 14:55:32 +02:00
Simon Ser
6dd8b092e9
output/swapchain: fix error return value types
...
This function returns a bool, not a pointer.
2023-06-22 13:55:45 +02:00
Alexander Orzechowski
b5eaa47049
scene: Use wlr_output_state_copy for direct scanout path
2023-06-22 11:56:30 +02:00
Alexander Orzechowski
4b7c526578
output: Introduce wlr_output_state_copy()
2023-06-22 11:56:20 +02:00
Alexander Orzechowski
38d451bcb5
render/vulkan: Don't compute texture.has_alpha until first...
...
...texture view is dynamically created
2023-06-21 11:37:54 -04:00
Alexander Orzechowski
ecbe48f3bc
backend/drm: Fix typo
2023-06-21 10:23:56 +02:00
Simon Ser
1e68e1f661
seat: fix keyboard/pointer/touch resource destroy
...
We need to always unlink the resource, even if it's already inert.
seat_client_destroy_*() may be called multiple times on the same
resource.
Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3638
2023-06-20 20:14:49 +00:00
Simon Ser
c4d4409deb
output: stop using wlr_output.back_buffer in output_ensure_buffer()
...
This allows us to use the new render pass API, and drops some
implicit state usage.
2023-06-20 16:33:41 +00:00
Simon Ser
b625a13156
output: attach buffer to state in output_ensure_buffer()
2023-06-20 16:33:41 +00:00
Alexander Orzechowski
2ac31fc630
wlr_scene: Introduce wlr_scene_buffer_set_filter_mode
2023-06-20 09:04:35 +00:00
Alexander Orzechowski
06c0b0a204
render/vulkan: Initialize to fix compilation error
2023-06-19 18:00:26 -04:00
Simon Ser
be73da28b2
allocator: only use DRM auth if we are master
...
Legacy DRM auth will only work if we are DRM master. Keep using an
unauthenticated DRM FD if we are not DRM master. This should be
enough for GBM.
Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3674
2023-06-19 19:36:17 +00:00
Alexander Orzechowski
e8887f76ed
backend/drm: Use texture blend_mode for multigpu blit
2023-06-19 13:16:35 -04:00
Alexander Orzechowski
2044cc2311
render: Introduce wlr_render_texture_options.blend_mode
2023-06-19 13:16:34 -04:00
Alexander Orzechowski
693005ac99
pixman: Remove dead code
2023-06-19 12:44:57 -04:00
Alexander Orzechowski
6bd44c4fcd
renderer: Introduce wlr_scale_filter_mode
2023-06-19 12:25:38 -04:00
Alexander Orzechowski
64c0272f81
output_state: Gamma lut should be freed only if committed
...
We consider state that is not committed to be uninitialized.
2023-06-19 00:19:50 -04:00
Alexander Orzechowski
3ee0f52e09
render/vulkan: Dynamically create texture views
...
Now that we are dynamically creating pipeline layouts, we need separate
texture views for each pipeline layout we choose to use with a texture.
2023-06-17 21:21:35 -04:00
Alexander Orzechowski
7c5a3afd60
render/vulkan: Inline init_sampler
2023-06-17 21:21:35 -04:00
Alexander Orzechowski
8a387b5558
render/vulkan: Dynamically create pipeline layouts
...
These will happen lazily when pipelines get created.
2023-06-17 21:21:31 -04:00
Alexander Orzechowski
3623005858
render/vulkan/pipeline_key: Add blending
...
This will become necessary when we switch away from scissoring. For the
time being, this cleans things up a bit and allows for a trivial
blending implementation for textures when that comes.
2023-06-16 19:20:04 -04:00
Alexander Orzechowski
9d31372930
render/vulkan: Handle quad pipeline through generic pipeline path
2023-06-16 19:20:03 -04:00
Alexander Orzechowski
97fdd57eb2
render/vulkan: Dynamically handle pipeline creation for textures
...
If we ever wanted to handle dynamic state that requires new pipelines
such as using different texture filters those can be added here with more
ease.
2023-06-16 19:09:23 -04:00
Simon Ser
220402b717
cursor: add wlr_cursor_unset_image()
...
It's pretty awkward to call wlr_cursor_set_image() with 6 zeroes.
Hide that awkwardness in wlroots.
2023-06-15 18:40:33 +02:00
Simon Ser
da04b066ea
cursor: add wlr_cursor_set_xcursor()
...
This keeps track of the last set XCursor. If it hasn't changed,
skip the texture upload.
In the future, support for animated XCursors can be added.
Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3436
2023-06-15 18:28:43 +02:00
Alexander Orzechowski
58a2f8bd5c
wlr_scene: Clear damage ring on transform change
2023-06-15 14:57:51 +00:00
Alexander Orzechowski
61667404ce
wlr_scene: Clear damage ring on scale change
...
If we were trying to change the scale in wlr_scene_output_build_state,
we would be using incorrect damage
2023-06-15 14:57:51 +00:00
Alexander Orzechowski
96b95bf775
wlr_scene: Reset damage ring bounds every frame
...
This fixes damage issues when a output state attempts to change
the transformed size in some way
2023-06-15 14:57:51 +00:00
Alexander Orzechowski
4391845910
wlr_damage_ring_set_bounds: Ignore duplicate size requests
2023-06-15 14:57:51 +00:00
Alexander Orzechowski
3896b6b107
wlr_scene: Fix transforms with non 1 scale
...
wlr_region_transform / wlr_box_transform want unscaled coordinates here
2023-06-15 14:57:51 +00:00
Alexander Orzechowski
7ce9459715
output: add documentation for wlr_output_state
2023-06-15 12:57:36 +00:00
Simon Ser
7e7633abf0
build: drop proto_inc
...
protocol/meson.build adds protocol header files to wlr_files. No
need to add them via include dirs.
2023-06-14 16:35:31 +02:00
Simon Ser
840fd7dce6
examples: drop unnecessary include_directories
...
wlr_inc is already pulled in via the wlroots dep. proto_inc is
already pulled in because extra_src contains these headers.
2023-06-14 16:33:18 +02:00
Kirill Primak
753f3cc4fa
compositor: add wlr_surface_role.no_object
...
This commit allows to make a role as not represented by an object,
which fixes calling role commit handlers for roles like cursor
surfaces.
Fixes: 099b9de752
2023-06-14 14:06:28 +00:00
Simon Ser
2d9659d765
backend/libinput: use struct initializers for events
...
This is more readable and consistent with the rest of wlroots.
2023-06-14 15:20:41 +02:00
Simon Ser
e1c6801b65
backend/libinput: ignore multiple events for same pointer button
...
If the same button is pressed on two devices on the same seat,
ignore the second event.
This is also what Mutter does.
Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3665
2023-06-14 10:48:44 +00:00
Simon Ser
670915eeea
output: add wlr_output_state_set_layers()
2023-06-13 12:02:49 +00:00
Alexander Orzechowski
73ca1ea48a
tinywl: Drop usage of wlr_output.pending
2023-06-13 09:19:51 +00:00
Alexander Orzechowski
495bcbeedd
examples: Drop usage of wlr_output.pending
2023-06-13 09:19:51 +00:00
Alexander Orzechowski
0925a500d1
wlr_scene: Don't use direct scanout if trying to commit a new render_format
...
Found by inspection.
2023-06-12 20:30:09 -04:00
Simon Ser
ac426c0c24
examples/output-layers: fix layers not included in commit
...
wlr_output_set_layers() attaches layers to the output's pending
state, but then uses a detached wlr_output_state in
wlr_output_state_commit(). This results in layers being left out
of the committed state.
Fixes: 8e81b4bb42
("examples: convert to new rendering API")
2023-06-12 21:52:16 +00:00
Simon Ser
4339c37f99
backend/drm: clip FB damage
...
The kernel complains when the damage exceeds the FB bounds:
[73850.448326] i915 0000:00:02.0: [drm:drm_atomic_check_only] [PLANE:31:plane 1A] invalid damage clip 0 0 2147483647 2147483647
Make the DRM backend behave like the Wayland one and allow compositors
to damage (0, 0, INT32_MAX, INT32_MAX) to repaint everything without
needing to know the exact buffer size.
Closes: https://github.com/swaywm/sway/issues/7632
2023-06-12 20:38:03 +00:00
Alexander Orzechowski
a09bb1314d
wlr_output_state: Consider gamma_lut uninitialized if not committed
2023-06-12 18:24:00 +00:00
Alexander Orzechowski
b80e67d6e6
wlr_output_state: Consider buffer uninitialized if not committed
2023-06-12 18:24:00 +00:00
Kirill Primak
96f1fdd113
seat: remove a TODO comment about simulating keyboard events
2023-06-12 20:54:53 +03:00
Simon Ser
6e8fb5509f
cursor: only reset the cursor when the surface changes
...
If the set_cursor request is used with the same surface, don't call
cursor_output_cursor_reset_image(). That function sends
wl_surface.leave and can cause an infinite feedback loop with some
clients (submitting a LoDPI cursor when the surface leaves an HiDPI
output).
Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3669
2023-06-12 12:42:31 +00:00
Alexander Orzechowski
05dd08afe5
scene: introduce wlr_scene_output_build_state()
2023-06-12 14:13:09 +02:00
Alexander Orzechowski
7e67b8152b
scene: Don't rely on output current state during rendering
...
In the next commit, state such as scale, transform, width/height that
we gather from the output might be outdated and incorrect.
2023-06-12 14:13:02 +02:00